From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FC2AA00C2 for ; Mon, 7 Mar 2022 21:17:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 362F1411FE; Mon, 7 Mar 2022 21:17:45 +0100 (CET) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mails.dpdk.org (Postfix) with ESMTP id E3277411FE for ; Mon, 7 Mar 2022 21:17:43 +0100 (CET) Received: by mail-ej1-f42.google.com with SMTP id a8so34489544ejc.8 for ; Mon, 07 Mar 2022 12:17:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=KER78l4fw5+Zrb/kLQ+2DPhiglKmF6pHyfB9GPzaquE=; b=EYiXHlqtWPqY4A7auFU1kWWNpxTO1iXNVyU6x5oqpEeDj3uPDPLcveEKHyAsDkOv0I Asq12wmDDl4fL6VroV0gBlOwacbTzlr4vE/iz6OsKYS32mJjnRCrmPR93zqFYL8n3VyE h/pPVQY72g/X4isIK3nA57yTLUdxQ+QkV23lzgxeqNTtSTWhGkfHzrPV2eEGWGD8mV4w /+FYm8ZyMsPSuPG0cJ+YU2eL/Klg3yx8roG3X39Uq64gFFNJuRcVXQ96Dv5yDyPGbMzj XMZ7ICO7rQ5VHn9V0LAEhXVS72TB4UU+956ecRqt2+YOFRRyCBJ6/t+hBCF1GXoMjVXO fOYQ== X-Gm-Message-State: AOAM532kX2DUiUHJFqM5ZZA1F7bOz6MhGBE/nKMwGSOVLOARbU/MYxu3 kccpscq2bFZf3n5ihZGqybAPzmST9+MoyA== X-Google-Smtp-Source: ABdhPJy+g4clRhHi9vBuF9KoZMmFOC1Lx91aesgQhUI8WdGKCEPWcY7YNySpqFVAl0Do7XoIy0ji/w== X-Received: by 2002:a17:907:a40f:b0:6d7:9f56:b511 with SMTP id sg15-20020a170907a40f00b006d79f56b511mr10427358ejc.674.1646684263405; Mon, 07 Mar 2022 12:17:43 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id z21-20020a1709063a1500b006da6436819dsm5125415eje.173.2022.03.07.12.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 12:17:42 -0800 (PST) Message-ID: Subject: Re: [PATCH 20.11] net/mlx5: fix sibling device config check From: Luca Boccassi To: Michael Baum , stable@dpdk.org Cc: Matan Azrad , Viacheslav Ovsiienko Date: Mon, 07 Mar 2022 20:17:42 +0000 In-Reply-To: <20220307182955.626660-1-michaelba@nvidia.com> References: <20220307182955.626660-1-michaelba@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 2022-03-07 at 20:29 +0200, Michael Baum wrote: > [ upstream commit dcbaafdc8f70987c6b610af7d43817b560fb646b ] >=20 > The MLX5 net driver supports "probe again". In probing again, it > creates a new ethdev under an existing infiniband device context. >=20 > Sibling devices sharing infiniband device context should have compatible > configurations, so some of the devargs given in the probe again, the > ones that are mainly relevant to the sharing device context are sent to > the mlx5_dev_check_sibling_config function which makes sure that they > compatible its siblings. > However, the arguments are adjusted according to the capability of the > device, and the function compares the arguments of the probe again > before the adjustment with the arguments of the siblings after the > adjustment. A user who sends the same values to all siblings may fail in > this comparison if he requested something that the device does not > support and adjusted. >=20 > This patch moves the call to the mlx5_dev_check_sibling_config function > after the relevant adjustments. >=20 > Fixes: 92d5dd483450 ("net/mlx5: check sibling device configurations misma= tch") > Fixes: 2d241515ebaf ("net/mlx5: add devarg for extensive metadata support= ") >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > =C2=A0drivers/net/mlx5/linux/mlx5_os.c | 53 +++++++++++++++++------------= --- > =C2=A01 file changed, 29 insertions(+), 24 deletions(-) Thanks, applied and pushed. --=20 Kind regards, Luca Boccassi