From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wei Dai <wei.dai@intel.com>,
wenzhuo.lu@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, Roger B Melton <rmelton@cisco.com>,
Laurent Hardy <laurent.hardy@6wind.com>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF
Date: Wed, 10 May 2017 10:50:52 +0100 [thread overview]
Message-ID: <a16fd390-4efb-8ddc-244d-1b4bd9313684@intel.com> (raw)
In-Reply-To: <1494399602-33955-1-git-send-email-wei.dai@intel.com>
On 5/10/2017 8:00 AM, Wei Dai wrote:
> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
> be called directly. It had better be replaced by calling
> ixgbe_get_media_type( ) to avoid crash.
>
> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
Hi Roger and Laurent,
This is very close the release, can you please support verifying this
defect?
An explicit Acked-by and/or Tested-by would help a lot.
Thanks,
ferruh
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec667d8..ed2baec 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
> hw->mac.get_link_status = true;
>
> if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
> - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
> + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
> speed = hw->phy.autoneg_advertised;
> if (!speed)
> ixgbe_get_link_capabilities(hw, &speed, &autoneg);
>
next prev parent reply other threads:[~2017-05-10 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 7:00 Wei Dai
2017-05-10 9:34 ` [dpdk-stable] [dpdk-dev] " Gregory Etelson
2017-05-10 9:49 ` Ferruh Yigit
2017-05-10 9:50 ` Ferruh Yigit [this message]
2017-05-10 12:20 ` [dpdk-stable] " Roger B. Melton
2017-05-10 12:33 ` Laurent Hardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16fd390-4efb-8ddc-244d-1b4bd9313684@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=laurent.hardy@6wind.com \
--cc=rmelton@cisco.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).