From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 381B143BA8 for ; Wed, 28 Feb 2024 18:32:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27B5C41148; Wed, 28 Feb 2024 18:32:47 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2088.outbound.protection.outlook.com [40.107.243.88]) by mails.dpdk.org (Postfix) with ESMTP id 99C9D4003C; Wed, 28 Feb 2024 18:32:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K+B/eSwcS5t9/tuldC6uPILYa2JEud2uWmtd15jtPYYAXBs9h/xFHAB1KzYC0inLWYaWMP90mDYBg3uLsLF99L8mV9KkvtdtIpjDbrY/7XE2Y2uDo2pDC3BkoFIB1lk8hcNskNvTyqwUki5PiI58xKrGhrdfIMimR9xYZSu6aBdo5USV/3Mh+/2yE+J2Xyi6j45qg+H+cQ8eo38eZ8u5ZUEW5F9IPzFbwcfSIKwrRZ55QsmmsEHcsr1nhC9mT/38NOV2Hy1cTDDBxKmNK/qDmZALgd07ITyaeOfdjEzH4dvZQHCnX3hkrAMiNNk+BdiYya2nI6OuNPjNv7rmOtRQAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fo9ytW6IkymtSGOTUG9B7xl7oip3AyrMAvJO+aRI96I=; b=CCaiqay21oK6w3385Xl6Mx+tAUfk2TB+WJrr5jOuGQIQi9QmlKdW32utHFhWPLQfa05VdAxFsi5MtBjq4K0F3aYOxTAGMMTtZR3ruDFmb2FX64JcDz/HYKnw8dsRnd/81NXs+aQffV1Pd9KUxc0znha+50M2Srq09e2mqyu2X0bCeI1LKzGFh1F/sCIgPgOiqqTeHDBx3FGBAfemE6yo1O/8/71w0pW1yCsFjiZIsGZUE8xiPsf/jD0DY9hCf5oDYXpLGi6DgWfqsmcvH/FVGk2HjIyI8POUEv+YxvWuX37mvjLHdnkkGhIplBu5MLFqmWY8i3R/dIN6mbcok12a2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fo9ytW6IkymtSGOTUG9B7xl7oip3AyrMAvJO+aRI96I=; b=KPYW1fJfi0rYv7b0IFH15QvUMZt4MBTZtYYEvbBz3jeZUU30A5qH89fT1DJjUGQcoEL8FKPE3kbO4TnGA0WyYajphxBQRQDMwjC9B3ibYKPr5fdUIuTyV3XgE8pv5HuakrUj4MrcMGXGzgiKNik881lSRn0IATnC0xC14+bFN64= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB8442.namprd12.prod.outlook.com (2603:10b6:8:125::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Wed, 28 Feb 2024 17:32:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.039; Wed, 28 Feb 2024 17:32:40 +0000 Message-ID: Date: Wed, 28 Feb 2024 17:32:36 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [v9 2/3] net/af_xdp: fix multi interface support for K8s Content-Language: en-US To: "Loftus, Ciara" , "Tahhan, Maryam" , "stephen@networkplumber.org" , "lihuisong@huawei.com" , "fengchengwen@huawei.com" , "liuyonglong@huawei.com" , "Marchand, David" , "Koikkara Reeny, Shibin" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20240214170404.3318857-1-mtahhan@redhat.com> <20240214170404.3318857-3-mtahhan@redhat.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0634.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB8442:EE_ X-MS-Office365-Filtering-Correlation-Id: 531e7163-0065-45a0-4580-08dc388343a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wqZ8Sq4Bo8t2zl8fSdEcY1dGYsguA5DHKPi/WPn5vzsBQNXovNpIQ1Wco1pW9vBWnikTUDbpHWirmvNh+M8zZgJgELFvN54eo/gU/4MexYA/ASqN2RWC2n3kidxB+rsKD0053GUM8OXvv4OV8+lz5RXTKUNxWqb+A7+RCswxTsLtEK2UASl9mU6+NVqr/LhJmcOoTk29yIlXioS2QOs5CyA4tYockwppZGi9jYyVsRaf2h0Ck9Wsg+3r1zN5j/Kaq33nTzHLA5MO5RHyTo9I5XzkQDnmgNl158hjDL6PVr+lU500J5Sx2bK4Bn3MdTTAOBQGAyT7DgDuIiDHlAYh++vyIxklkfmPzekMIwCUspQqOC/dlEQQ818xXkf0A26ip8FZqqlpIffRDbGKlo88s9n0eYDeMPkdAG9K7FODK3KD7kpcH55prubkC3sUt+z50EGfKUPXDTT1VDblH++PK5xdDCjJHA03fjEmG+K3TS74H3leVmFjSh3CAYVCoz/mVMqmeDE372pRH/74KOWMvR27xcmk1OHfCr1wxxvoe5dWvAllVUKuZOpVMx0c3yRBsovqiDEVGR2pTUhs5Xo3BdAcV/zn2WuQ4YzSTSj9AE3fVNjyuqSznSQi3D7QHK+LseOPN/kmnHoX66XmyqVG5YMhU6WemM52fjrVir+Ju4vJAm4yAwLoNQVaqSExaVMP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(921011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YklhQlNscUpVWllkYXVmb29pN0Q5cjZEVFAya3pwMzhxbXJIRnBxdlF4REU1?= =?utf-8?B?b3duTTFoVzBLc25BNWdJWFdQY2pnb0dTS3VoSDhRc0ZtOXJRM0xiRGhlMGtz?= =?utf-8?B?WmcvY2c5ZkN4Z2gxTTM0bjFWSThtS2Zqdm1nYmNXVE9uVkUvbWdteWNIdkx4?= =?utf-8?B?OXlqeDJPUkQyUlRheVFnSnkxdGo4S2tTdlVRWWIrMi9EMnFnTHF6TmxSSWpG?= =?utf-8?B?dDc2eXhXdjlzSnZZRjRCTms0bDlCZFhiWkF5NmNqUGZLOXg0Y08ySlhVR0Ji?= =?utf-8?B?b3oyL2N1RlBqbXhiTTJidUlXa3R0TnZhT2hRUFRHSEJzMXVuYWRNL3M4ZTk4?= =?utf-8?B?dnZUUHVYekZCV3RJblJTNlM1WWwyc2hFWithLzhFbHl3VzlWMFd1K2tMaHpt?= =?utf-8?B?MHlGUERoamtVWWtjQS96OXM3MXZRRnZhQnJ5NFU1Y3FiTnhSVGpzcnNvOXdy?= =?utf-8?B?MlNlTEQzcTR2MzVKNjFucEMzeWo4K0crRURNZld6VEM1NjdFSHlwbXJGaTQx?= =?utf-8?B?VE1SQ2F0WnZIT1Ribm5mbWx0azhOK3NDQ2dnNUt1alhQUEs1SFB4M1M2elVx?= =?utf-8?B?R1RJdVl3VnIzNnl2ejQ2bTdyNFpJYVVVK2h6ckxBZ3h5Z1JBQ0J6S1JzWTdJ?= =?utf-8?B?UURJTFp2WTVqQStKa2F2QnZPUy9jUjhqWEpKSmVhUmtYd09wVGxOM0pVL0JW?= =?utf-8?B?UWVwR3E5VXg5eWtadUpnRi9RQUJxcnJBU2dnYytwWlMxUUJSM0g4SldXV3Bw?= =?utf-8?B?K2N3LzBKTUd3OTlWOEdrZk9lRXl5cGdCYzg1NGUzRXcxdHJHaTQzVHNkVmRi?= =?utf-8?B?R2dwUjJxbXJZRFFEWnNhU1VCNldrdnlMRFNudXVLcXgyMFkyL1pObGwrNEkx?= =?utf-8?B?bEE5cGV4c0VmRmM0QU93d3lna2pEQW16dVVzNUJ0WTczM0hBWXR5cXNXU0d4?= =?utf-8?B?Sm0wZmZrZUgvT3ZYWDRiZEdpYkoxRDJxbElFbVJHd0FYaEJYaVpkZDljMmhV?= =?utf-8?B?M1Urdnh2YUpjWTgzMDdvbzczL1dkcWRFQXRjZnlUN3JYdmYwNnNMTlk4Mngv?= =?utf-8?B?WWFvaFhxaWhOWG9BWG5LekhCdFJPRGtobWZwejQwSVBaejJzeUwyTlhsTmUw?= =?utf-8?B?eVNBemZoYTl1cUw5TlFNY3RYcjgzT1JMZVozc3JTYit2QzNOVEZYZTR5OWZm?= =?utf-8?B?Y0JlcHBzdTVwcVJVM1BsY3hBcFk4QjlFUzhWMVQyN014TzFsbmF4bWdhZWIv?= =?utf-8?B?TEZXbjhrNTkwZ3RQSC9lZTFsejlMQ2QzOHIvWkRhQ3Z0OStsTXNSdUN0NFVy?= =?utf-8?B?bkkvejV4ckZ5dGM5MHdaUXFLYVQ0dUZPTnR5NEh3TTlmNmY3cTN0MEtkcDFZ?= =?utf-8?B?b0ZGUVNHUzJFc3Z3ZXFGbkRWSUtQUjZzQVZibXZBNkl0SjRXQlVhTldsRy9F?= =?utf-8?B?WnV3MmVFdEJqVFpIZzAzbGhvWjNpSFdDNlBmWVVxLzJ2a2YyakR3Q3FmV2Fm?= =?utf-8?B?eHBudXl2Vy92bzVLREh5SGxEUUkrU1BVWEJXREIxd3B2aHM0a0YwZzJtU0kx?= =?utf-8?B?MkJULzJBYXhjQ3p5WkpDVnE5eUY1MnBreVZ6UDlhN2RyRHJ4T0FiQm5sSmll?= =?utf-8?B?TGJhVHZKMjAyRGtHeDlDL0o4V2ovYUwrd2dJNFQyRkdDZElmRElDOUFqYXFC?= =?utf-8?B?ZUFnTkx1djYyd3lUbGVHVXM1Tk41OExyQmN5aHRmckxUWWtTWnpKWE5JK05q?= =?utf-8?B?Rlptck45UVAraWFnb2FJTlk2cWVPMWdOZ3lmQkdlWlRNUm50SjFsektuR005?= =?utf-8?B?MUE2TkszdEtFbE50NzFYdHBPcEJpakZjc0k3LzZ4VmJzQ1drSGhwaGl5SzUx?= =?utf-8?B?SHZBaTlyY0VhcFNuQ1RjWWhzdjZaSXdyc3J0b1ZqMk5ZcEJuNUpuWHFDeDVP?= =?utf-8?B?K25kRjVnU2NjcW02SkNDdCtXSkM5cFBDSUtjam5wTUxRdVZzZktmUFEyZzBl?= =?utf-8?B?TTlQcnN4cUU2d0x3ZlVVYU00MVVlb2tYamI5ZmIzcWdiVmQ1OGNhaEtRSFA3?= =?utf-8?B?MDNNbzhZcVVDcnVGRVdSTVlNSG05V1U2QW4rai95UGpGTnJzaTNIa0d1eU54?= =?utf-8?Q?Gt9HDv2kTcDzcDwRhqJX8QaXr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 531e7163-0065-45a0-4580-08dc388343a2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 17:32:40.8396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4SfSK4HpH7oTLLQZ+KKGqeJwLgXUgwyY3vt0vILpoPmFrzy5aXaqPBzSXcZV3SOh X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8442 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/22/2024 1:46 PM, Loftus, Ciara wrote: >> Subject: [v9 2/3] net/af_xdp: fix multi interface support for K8s >> >> The original 'use_cni' implementation, was added >> to enable support for the AF_XDP PMD in a K8s env >> without any escalated privileges. >> However 'use_cni' used a hardcoded socket rather >> than a configurable one. If a DPDK pod is requesting >> multiple net devices and these devices are from >> different pools, then the AF_XDP PMD attempts to >> mount all the netdev UDSes in the pod as /tmp/afxdp.sock. >> Which means that at best only 1 netdev will handshake >> correctly with the AF_XDP DP. This patch addresses >> this by making the socket parameter configurable using >> a new vdev param called 'dp_path' alongside the >> original 'use_cni' param. If the 'dp_path' parameter >> is not set alongside the 'use_cni' parameter, then >> it's configured inside the AF_XDP PMD (transparently >> to the user). This change has been tested >> with the AF_XDP DP PR 81[1], with both single and > [1] does not point to any reference. > >> multiple interfaces. >> >> Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") >> Cc: stable@dpdk.org >> >> Signed-off-by: Maryam Tahhan >> --- >> doc/guides/howto/af_xdp_dp.rst | 43 ++++++++++-- >> doc/guides/nics/af_xdp.rst | 14 ++++ >> doc/guides/rel_notes/release_24_03.rst | 7 ++ >> drivers/net/af_xdp/rte_eth_af_xdp.c | 94 ++++++++++++++++---------- >> 4 files changed, 116 insertions(+), 42 deletions(-) >> >> diff --git a/doc/guides/howto/af_xdp_dp.rst >> b/doc/guides/howto/af_xdp_dp.rst >> index 657fc8d52c..8a64ec5599 100644 >> --- a/doc/guides/howto/af_xdp_dp.rst >> +++ b/doc/guides/howto/af_xdp_dp.rst >> @@ -52,13 +52,18 @@ should be used when creating the socket >> to instruct libbpf not to load the default libbpf program on the netdev. >> Instead the loading is handled by the AF_XDP Device Plugin. >> >> +The EAL vdev argument ``dp_path`` is used alongside the ``use_cni`` >> argument >> +to explicitly tell the AF_XDP PMD where to find the UDS to interact with the >> +AF_XDP Device Plugin. If this argument is not passed alongside the ``use_cni`` >> +argument then the AF_XDP PMD configures it internally. >> + >> Limitations >> ----------- >> >> For DPDK versions <= v23.11 the Unix Domain Socket file path appears in >> the pod at "/tmp/afxdp.sock". The handshake implementation in the AF_XDP >> PMD >> -is only compatible with the AF_XDP Device Plugin up to commit id `38317c2`_ >> -and the pod is limited to a single netdev. >> +is only compatible with the `AF_XDP Device Plugin for Kubernetes`_ up to >> +commit id `38317c2`_ and the pod is limited to a single netdev. >> >> .. note:: >> >> @@ -75,6 +80,14 @@ in the PMD alongside the `use_cni` parameter. >> >> .. _38317c2: https://github.com/intel/afxdp-plugins-for- >> kubernetes/commit/38317c256b5c7dfb39e013a0f76010c2ded03669 >> >> +.. note:: >> + >> + The introduction of the ``dp_path`` EAL vdev argument fixes the limitation >> above. If a >> + user doesn't explicitly set the ``dp_path``parameter when using ``use_cni`` >> then that >> + path is transparently configured in the AF_XDP PMD to the default >> + `AF_XDP Device Plugin for Kubernetes`_ mount point path. This is >> compatible with the latest >> + AF_XDP Device Plugin. For backwards compatibility with versions of the >> AF_XDP DP <= commit >> + id `38317c2`_ please explicitly set ``dp_path`` to ``/tmp/afxdp.sock``. > I think instead of adding a note here we can just simply remove the limitation. When the user has this patch, they most likely will not care about limitations that were previously present. > Just make sure that the information about the behaviour when dp_path is not set and how to set dp_path to be backwards compatible is still captured in the docs somewhere. > I just think it's confusing to state a limitation followed by a note that it is resolved. > > The remainder of the changes in this series LGTM. > > Thanks, > Ciara > Hi Maryam, It would be nice to have the patch for -rc2, otherwise there will be small time for anyone test the new feature (or existing `use_cni` one), do you think can the comment be addressed before -rc2?