From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F16F5A0352 for ; Tue, 25 Jan 2022 12:27:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E846342941; Tue, 25 Jan 2022 12:27:44 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A01C942941; Tue, 25 Jan 2022 12:27:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643110063; x=1674646063; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Uhz9YVwwXOvgA8Sxq7a6RT/aZlETuVWCw1lMXh9f4NQ=; b=Cz9ciPya/ZG1X/u/Zq9SDe16ig1JU1T6Omc+8kK51pk5KLGHqcsFCH95 B6CLZZvWt+WgyRiq37p+pDCCOcLmGtvsnYHggFlDgQjsp2GZf7HNpxWuu F+7Y+phKS/55kLfBOW1fKgODGDeENS3u9puW0oxbGBOHGkmxhJFvTorii MUNxKknN2xR5X1MJTETI2hZzbtPRX25MLBauBcDvpUGoUJAJ+R3p86NJa 3xsvBeLI0SS6LEa4hxJkSCMNfKyH1/Er2vz1eHbPUzSyElCCv/JzSLq7N qg9/vCw046dHkhQJeYFlxDbi/t0XXEQNgaMWtDvBQZ6OwVf1ih1sfNRna w==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="229854551" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="229854551" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 03:27:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="532389604" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 25 Jan 2022 03:27:42 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 03:27:42 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 03:27:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 03:27:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfaAOTNrXyGCwwUN7QOuJ1P4ejZ5dhtaKebf6+ITdPV1j3mJ7WF+1sLdsVMlcVXMGzfz1MN5iW2MSVDxq4n7fa210QnZgv6mQecIOkfI3AfX6MGLdWpa+a36NSz2UPaAzRKOz0ylORbnSA2pXYxoN4ZTNoOZQPLbNQULgbASCrEDgEvcGvbogJsI+HUYn1xW2cUj4QoReyHFLclZZtv9QhvE7dEUAe6ux+LjYdFqNIxYMWJG/ec4JRkuQiLa6hvlgrxXCpzovX5eeIupaTqrYx1LAMzmRk4umKgTZ5Pl8/OZzvsFffMh/wRDkUajQvRcrCbefr+wkFbbftLb2M/tlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D3wAKTPxu5rD0XNpImXxQUL/ERnfSyLmKDftWT72GG8=; b=eMIjzSJTmWGquTQf5c45VuOVaQQrIlkZgA8VBxazBOf2YIdQ+NhrUmy6YgH1xOrfpvS33aio0uHDiAtAhAmg027XSQakZLmpMN03bgpqp//TB2CMHAff3AkO3Go6yDhm0v0E0mhp6wcA+qOHxMqhW+FqriDIgtH1I0LuEOoN6M/eR6R/4gun26sKMtDPc3lC4ZC/a12qCmNAdCOUrRfaXv+jUW+UgXzDPAZydgs258BkODx4JQHOwH427FVwaTATdmWM2cuEeNB6UQ4RMDgMWWJHwSkG86GdnpL2zNUPflMOV5O1o09NjULIGATNnEt+Z79c/q6kCFFtoPHfTm+mzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB2764.namprd11.prod.outlook.com (2603:10b6:5:bf::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.14; Tue, 25 Jan 2022 11:27:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.017; Tue, 25 Jan 2022 11:27:40 +0000 Message-ID: Date: Tue, 25 Jan 2022 11:27:34 +0000 Subject: Re: [PATCH] net/sfc: validate queue span when parsing flow action RSS Content-Language: en-US To: Ivan Malov , CC: , Andrew Rybchenko , Andrew Lee , Andy Moreton References: <20220110214845.4033371-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220110214845.4033371-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0008.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d7ad325-26e7-45cd-6de8-08d9dff5b21d X-MS-TrafficTypeDiagnostic: DM6PR11MB2764:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZfqFk2bCX2d3ea/ayRUrdWmLgFigHw7MfRT9MNvNmnpzBpmVH6LpItlwl6gGZ+5AK7h+kGomPAK2Bf21yMnSyfpSTjqYjuNwZJsYgEh8vS4SISt1EFYIO/AXZt8yqEtAO8Yk+mDmsalXx6Kb5NKhJePfO9+R3ShiESgg0sjK/J/A4JNAIsljNHSRjb+GQS/cC6KwBDPfh/YQrTIhw7dypXmKAB4/ELi+kdSDX8ncGNUFcPUMbwUHDo/UvFOcjJc6f+2epgOLyUF+Ir9QdyQ0ciCDBi0iEj+5USCJeFnGXxrQV1dY2cycBGYi8o/nzr63n6JsrKSBtjJqSy2dKve5R8EXO28VZHYgigjQspxEbMqJYQD61sDNPMmmKJq5z1HJF62H340ivq5gCsm6mgPc/L/yF7NFKLZFjcqhqzM0KDICHfop0QTTlkW+ro05BKwoX1uFoIbdiAgmLDLtomLjxmyeyvxTQ7QVk5kc18bfnh3Tcl6MOYzKHQsQrm66KwUfPsIGPrbFXXzV4PCHtVupoTS0M7y/ZTSBApRLzt3IhG9V3qoP2FirHTCcZrlSMeodsYe7zUt6pm13mAW0OPV4cgkutMzNZ5VjPIzSQWVz73z6TAQ3OD7deCgj2oLwQPzMG0kkaLS6aUgMjl8L/Qw1Q2DGGvU0BOzuiU4dzhj6slpbQjPWiwS58V/P+hNiEIwm5JYoBu3L8o9VSCWIpviVzA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(31696002)(2906002)(44832011)(6506007)(8676002)(2616005)(316002)(6666004)(54906003)(53546011)(4744005)(6512007)(82960400001)(508600001)(83380400001)(8936002)(26005)(66556008)(66476007)(15650500001)(4326008)(186003)(31686004)(5660300002)(36756003)(86362001)(38100700002)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWNBaWNmTlcyVWJreFMwNlUvV29FSWx1K0lPanAvbEg2cmt3MzZSeEk4eGMx?= =?utf-8?B?dm5tNytwZjdjdlZMandyNDcxR05VOGI0cEloOHhNNUQrMW9hRlhibG4wSTNy?= =?utf-8?B?bUR6Z3QvWWFmTFF2aHFtbjBQK0RreGszcExCSjliVDB1ejcrdnhmc3E5SVEy?= =?utf-8?B?cG0rSEFMYXczcVlqdmx3RHEvZ0c3UWhVUjF4Tnkxam5XdHdpanBrZ0tOL3Qx?= =?utf-8?B?cGJ6SjZyNUwxM2FmTHluQkNQVG4zSWlOV3FwYnZFejFrWlZUdkQ2NTg2dkdQ?= =?utf-8?B?RUY5WmxZUEVONllUUXFUbGdBYUl6cUd3Vzl5SzQvM0ozY0FXUEdqYTVXVmI4?= =?utf-8?B?QmozYUs4RStFUWk4Y2p2ekptRkhIbVUzcWFkWXRCenhJWlJ0RVF6Z3NVUC9a?= =?utf-8?B?cE1La3lVSEpNOG00b2ExU3NLUmZCaWZUYzUxdG93Tjh1cjBjekJzejlFaEJs?= =?utf-8?B?VjVsd1ZyZnAxNkNhSVFtSXErb2xWRnU5ZklicStKUktLeVdMS3kwdlByNkxO?= =?utf-8?B?T3J1dm9vanhVVkVDK1NKYjg5eWsvUmJjRVJ1WCtORlZFZTkreHM5TkNwaEFC?= =?utf-8?B?dGY1NlVFR1pzd3RnbFV6eGJLT2oxendYTUZaVjNmaWFCeng4TWVTdUx6UUZ0?= =?utf-8?B?azkrNVBtMnlPbm1vNFNidStwa0VKekw4TGFzRDJEaU51RE1pOTVOZUEwWmky?= =?utf-8?B?VUhILzBOMXdyZERQd1phT1ZzOVZJWklFSUU5d2NHQmZpcmdpT3g2dkYrV0xO?= =?utf-8?B?NHhPZmdIclc4bmwxVnQ3cnZiUlRNVlJKODQydWxHWlRMMHVmTmVNY0ZNZlg4?= =?utf-8?B?S0pmcEJYL3hleUNjK2xiSHdJZkJ3UXR3Y1dwOEVwWDE1VWwyZXY3S1dIdUVQ?= =?utf-8?B?QlJ1bWtIUlQ3SHVkdCtzck84MmtLOHBFbmI5OENERlRJK2Zla2lWS09Wc1Fl?= =?utf-8?B?QmRTR29yRWM2M2FMc2tzUHVvUGc5cFZzOUoyVVdSeUdLSDhUbWZnRlhTbE9x?= =?utf-8?B?T2taMndMREx0d0ZLTW9vWlBhSGJrMmk1Vk1TY0JqYzJZVXlzbzI2SVVTNVQy?= =?utf-8?B?K2pxRDU3eW5GWVhuYTdmbWdtTUYrOFJwVkhxR0lkdytFQW0xVHZJNFFZRG1a?= =?utf-8?B?bUhUTW1QVG82RmQ0ZWI4ci9scEJYaUFKZzBmcnJ4OVhiOWxkOVI0UU5idS9W?= =?utf-8?B?aFdHSHNmQThPQ1pqS1MvM0daYWtZcDgyZnJTTjVwNThEWmhqQzE0RjVnb0Vk?= =?utf-8?B?Sjdzc2srQ2MrUmh2eCtjL0xLcXFhblZrZ29Hd1JaaGErQzdqQ3AyVUdPSVYr?= =?utf-8?B?bTZwUzA4WXdWbFZ1Q2R0UVJmNUJKTFhSR251QXZmZzBZNGNyTnk2cXVVcUtm?= =?utf-8?B?OExqT3Z5amhZencxMUNVMmhKZlZwWXBEd0NKaUNFRFJWcVNNeWtTK3hqc3ly?= =?utf-8?B?UVU1VHBYclNlVkpBZis4Z2tWNGpORWNNSjB3d29WdUNTS1VZZE9uUHY1Q1hG?= =?utf-8?B?bUVOVFR2Q3NxYVh5RWdYR0ZDOW1GWjIvenU3dWJ4MGJKU1dOMlNEWENaakRl?= =?utf-8?B?U0t5VHhmRkozdXRsRlNNY0UyL25jbGFKMEVPR3VvNzQ1M3Iva2h3TFdDY0pz?= =?utf-8?B?MXVEVVNXU0ZZcnBRbUhIQ2htVjNLZDBFTVJ1V016WDh6WDA3MkpjZFRoNHJz?= =?utf-8?B?ZUJTenRiT2YycDh2VnRBNllLZVB2U1dtZUJKYUlMN3dkQ0xmUmtXcGtJSC9N?= =?utf-8?B?VjJYcjhqSFhPSmJPQ0piNHFQK0xaaXBvY1N0bWFwM0FDR2ZSVVVqMWpsMjdx?= =?utf-8?B?bERhRCtNczhCamFzcG1IY2dRK254WVA1YWZMUy9nak9KY3FobjRybkc1V3NF?= =?utf-8?B?bndTYjBmdDFxNHJ1bUtYd0tYVFhUOVBGMXlPNFJKSFV6anZjdW9sNWtMbXh6?= =?utf-8?B?THhFZmxhVFp4MnhUL2ozRGRaWlJXMEJpNEVjMUZpYzROc2hnYlpCZEJXUlp4?= =?utf-8?B?NGlCM29sWjZXVFR6T2JtVm1oOWRnUTFYcGZLS1o3N2xpWnR3RGhudHMxRStp?= =?utf-8?B?NHRNV2VyZHdCbGxPZ0g4U3FaRnk4MVJDWEY0TXI5VW5yZHM1YXBzVjZmZWZm?= =?utf-8?B?WUpqbmIrdTlzam5xQ003U216RXJtZnhsdS82UTBWdzBCK3ZXb1EyWDJPd09X?= =?utf-8?Q?OyJxjLAdsbeUFzFGUzxp75Y=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2d7ad325-26e7-45cd-6de8-08d9dff5b21d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 11:27:40.1171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hl3F1hYMib178R4c6AcErMBFk/KgHz2fWZ1s16j3nviJKjH19bKzFbvB5Kir2HTP/bOQXu520YgK5d7BT03AUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2764 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 1/10/2022 9:48 PM, Ivan Malov wrote: > The current code silently shrinks the value if it exceeds > the supported maximum. Do not do that. Validate the value. > > Fixes: d77d07391d4d ("net/sfc: support flow API RSS action") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko Applied to dpdk-next-net/main, thanks.