From: David Christensen <drc@linux.vnet.ibm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Stephen Hemminger <sthemmin@microsoft.com>,
dpdk stable <stable@dpdk.org>, Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix link status issue on ppc_64
Date: Tue, 15 Oct 2019 13:50:42 -0700 [thread overview]
Message-ID: <a39c61b4-735f-c029-1f78-bcbadedb96d5@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJFAV8wCZh8JB+QTYzPFCMq1RHCPWm=CsVX7bEUr5WqJGLrqVQ@mail.gmail.com>
>> The rte_atomic64_exchange operation for ppc_64 incorrectly linked
>> back to a 32 bit generic operation (__atomic_exchange_4) rather than
>> the 64 bit generic operation (__atomic_exchange_8). As a result,
>> only the link speed was passed to the application, not the link
>> state, link duplex, on link autoneg properties.
>
> Good catch.
> The first impact is the link status, but you can imagine applications
> calling this, so I would prefer a title like "eal/ppc: fix 64bits
> exchange operation".
> WDYT ?
Sure, I can do that as a v2.
>
> rte_atomic64_exchange has no unit test.
> This kind of problem could (should?) have been caught in unit tests.
> Maybe something to add later.
>
I was surprised too. I'll look at adding a change to the rte_atomic.c
test application.
Dave
next prev parent reply other threads:[~2019-10-15 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 23:07 [dpdk-stable] " David Christensen
2019-10-15 7:33 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-10-15 20:50 ` David Christensen [this message]
2019-10-15 21:16 ` [dpdk-stable] [PATCH v2] eal/ppc: fix 64 bit atomic exchange operation David Christensen
2019-10-16 15:10 ` David Marchand
2019-10-17 5:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a39c61b4-735f-c029-1f78-bcbadedb96d5@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).