From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx4: fix flow creation before start
Date: Mon, 31 Jul 2017 17:48:29 +0100 [thread overview]
Message-ID: <a4a24f0d-8e13-7d80-db2f-386655fcde1d@intel.com> (raw)
In-Reply-To: <1501151244-2917-1-git-send-email-matan@mellanox.com>
On 7/27/2017 11:27 AM, Matan Azrad wrote:
> The corrupted code causes segmentation fault when user creates
> flow with drop action before device starting.
>
> For example, failsafe PMD recreates all the flows before calling
> dev_start in plug-in sequence and mlx4 allocated its flow drop
> queue in dev_start.
> Hence, when failsafe created flow with drop action after plug-in
> event, mlx4 tried to dereference flow drop queue which was uninitialized.
>
> The fix added check to the drop qp accesibale and conditioned the
> ibv_create_flow calling on device starting.
>
> Fixes: 642fe56a1ba5 ("net/mlx4: use a single drop queue for all drop flows")
> Fixes: 46d5736a7049 ("net/mlx4: support basic flow items and actions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-07-31 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 11:18 [dpdk-stable] [PATCH] net/mlx4: fix drop action setting " Matan Azrad
2017-07-26 9:34 ` Adrien Mazarguil
2017-07-27 10:27 ` [dpdk-stable] [PATCH v2] net/mlx4: fix flow creation " Matan Azrad
2017-07-31 16:48 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a24f0d-8e13-7d80-db2f-386655fcde1d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).