From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABF9DA04C0 for ; Fri, 9 Oct 2020 23:04:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7FF271D55F; Fri, 9 Oct 2020 23:04:01 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id AAB5F1B686 for ; Fri, 9 Oct 2020 23:03:58 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201009210347euoutp01c3e3408d27ca6403f1315727a6af5431~8btSyl_Pe3068230682euoutp01a for ; Fri, 9 Oct 2020 21:03:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201009210347euoutp01c3e3408d27ca6403f1315727a6af5431~8btSyl_Pe3068230682euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602277427; bh=rFDNPFmBhO30/alqx+Z4OJUdXkXR4yDsmKvgfr/c/OA=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=dytTvPEy83HXmqQxHWdbPJotblLmls09jETdxdW9LCfZCtnQ1C8O+Yz9q6qsG/NNL Gl2gDeI7bClhddxfywsNRd95wHG3RgohFURHUDsiC+OeGVN7f3x0GBENO7jRPcMds8 Dh2wEPYG/bjwd6CV9d6OF0LFpJlsIDXkwBkN9Af8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20201009210341eucas1p1b7c2c5290fb67ab0b0d049a73b4abb06~8btNRNbQz1382513825eucas1p1M; Fri, 9 Oct 2020 21:03:41 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 99.96.06456.D20D08F5; Fri, 9 Oct 2020 22:03:41 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201009210340eucas1p253ed0eecbe06dda4a9125d82d863161c~8btM2QJ0T0733307333eucas1p2H; Fri, 9 Oct 2020 21:03:40 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201009210340eusmtrp259e9b12c0cce3e63d814226039877ea3~8btM1pu8x2072820728eusmtrp27; Fri, 9 Oct 2020 21:03:40 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-01-5f80d02d8000 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id A2.AE.06017.C20D08F5; Fri, 9 Oct 2020 22:03:40 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201009210239eusmtip1a1b5fbc1a4385cdc73557fac176bb11c~8bsT6yBQ22005420054eusmtip1B; Fri, 9 Oct 2020 21:02:36 +0000 (GMT) To: David Hunt , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, "\"'Lukasz Wojciechowski'\"," From: Lukasz Wojciechowski Message-ID: Date: Fri, 9 Oct 2020 23:02:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <5dbcfb04-35c5-5d69-7958-47e5a50bc82e@intel.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsWy7djP87q6FxriDb6c4bG4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsEroz/e/Yy F7SKVxx9uYWxgbFfuIuRk0NCwETi6/Nt7F2MXBxCAisYJXb+OMcE4XxhlLi9/TA7SJWQwGdG iY4jUl2MHGAdB/ZyQ9QsZ5T4sfsBVM1bRok1hy1BbGEBO4mXU/+wgNgiAmESzc17WUB6mQVS Jbb/dgcJswnYShyZ+ZUVJMwr4CZx7gIbSJhFQEVi09yHjCC2qECcxISNLWBTeAUEJU7OfAJm cwK1Xv57hxnEZhaQl2jeOhvKFpe49WQ+2PkSAtPZJQ7cf8sM8aSLxJZ5q6FsYYlXx7ewQ9gy Ev93wjRsY5S4+vsnI4Szn1Hieu8KqCpricP/frNBPKApsX6XPkTYUWLK+9vskDDhk7jxVhDi CD6JSdumM0OEeSU62oQgqvUknvZMZYRZ+2ftE5YJjEqzkLw2C8k7s5C8Mwth7wJGllWM4qml xbnpqcWGeanlesWJucWleel6yfm5mxiBSeX0v+OfdjB+vZR0iFGAg1GJh7chuSFeiDWxrLgy 9xCjBAezkgiv09nTcUK8KYmVValF+fFFpTmpxYcYpTlYlMR5jRe9jBUSSE8sSc1OTS1ILYLJ MnFwSjUwss6IfnSe93eimGeAPxur9bbPs2S8nzrseFd68+Ta4tYQrrxYGUeWk+eK569Wmuv9 q2Dt1N83u85OaQu/WWftfv0a/3v5XMZjftO1/fcdOnHt4Z6/P9x6m3LfC39pL+hb8XDySpuo v4+MRCxi5EvNvF2szTTN5rmX1SvrtX+yvbfkdu5bF60tSizFGYmGWsxFxYkAhU3uAyYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t/xu7o6FxriDfZ0G1vcWGVv0TfpI5PF u0/bmSye9axjtPjX8YfdgdXj14KlrB6L97xk8jj4bg9TAHOUnk1RfmlJqkJGfnGJrVK0oYWR nqGlhZ6RiaWeobF5rJWRqZK+nU1Kak5mWWqRvl2CXsb/PXuZC1rFK46+3MLYwNgv3MXIwSEh YCJxYC93FyMXh5DAUkaJhvtf2CDiMhIfLgl0MXICmcISf651sUHUvGaUWHHpJRNIQljATuLl 1D8sILaIQJjE9a/32UFsZoFUiWcdZ5lBbCGBH0wSz+64gNhsArYSR2Z+ZQWZzyvgJnHuAhtI mEVARWLT3IeMILaoQJzEj4m9YHFeAUGJkzOfgI3nBGq9/PcOM8R4M4l5mx9C2fISzVtnQ9ni EreezGeawCg0C0n7LCQts5C0zELSsoCRZRWjSGppcW56brGRXnFibnFpXrpecn7uJkZgHG07 9nPLDsaud8GHGAU4GJV4eDUSG+KFWBPLiitzDzFKcDArifA6nT0dJ8SbklhZlVqUH19UmpNa fIjRFOi5icxSosn5wBjPK4k3NDU0t7A0NDc2NzazUBLn7RA4GCMkkJ5YkpqdmlqQWgTTx8TB KdXAGFJ3dcsnrnd2b+KM59VLsPYbbL2XKrF6/dQPMc3HGUJ3zZp0UWqzLCPHzMToQ8ty//AK yE6c588xia2goqnn4CK5rzPuJAXKZnutyLZ4/99kStDFL6ovZqyYemX3cafTD13n7ln+5rsT u+EN0y2f/Zesm5a9SGNJUOejRJP6jDfl2+x1Pry881SJpTgj0VCLuag4EQCsWB8CuQIAAA== X-CMS-MailID: 20201009210340eucas1p253ed0eecbe06dda4a9125d82d863161c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201008052345eucas1p17a05f99986032885a0316d3419cdea2d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201008052345eucas1p17a05f99986032885a0316d3419cdea2d References: <20200925224209.12173-1-l.wojciechow@partner.samsung.com> <20201008052323.11547-1-l.wojciechow@partner.samsung.com> <20201008052323.11547-13-l.wojciechow@partner.samsung.com> <3b991d39-1697-5b55-bdb9-83f71d0a8f9d@intel.com> <5dbcfb04-35c5-5d69-7958-47e5a50bc82e@intel.com> Subject: Re: [dpdk-stable] [PATCH v5 12/15] distributor: fix scalar matching X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" W dniu 09.10.2020 o 14:35, David Hunt pisze: > Hi Lukasz, > > On 9/10/2020 1:31 PM, David Hunt wrote: >> >> On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote: >>> Fix improper indexes while comparing tags. >>> In the find_match_scalar() function: >>> * j iterates over flow tags of following packets; >>> * w iterates over backlog or in flight tags positions. >>> >>> Fixes: 775003ad2f96 ("distributor: add new burst-capable library") >>> Cc: david.hunt@intel.com >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Lukasz Wojciechowski >>> --- >>>   lib/librte_distributor/rte_distributor.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/lib/librte_distributor/rte_distributor.c >>> b/lib/librte_distributor/rte_distributor.c >>> index 9fd7dcab7..4bd23a990 100644 >>> --- a/lib/librte_distributor/rte_distributor.c >>> +++ b/lib/librte_distributor/rte_distributor.c >>> @@ -261,13 +261,13 @@ find_match_scalar(struct rte_distributor *d, >>>             for (j = 0; j < RTE_DIST_BURST_SIZE ; j++) >>>               for (w = 0; w < RTE_DIST_BURST_SIZE; w++) >>> -                if (d->in_flight_tags[i][j] == data_ptr[w]) { >>> +                if (d->in_flight_tags[i][w] == data_ptr[j]) { >>>                       output_ptr[j] = i+1; >>>                       break; >>>                   } >>>           for (j = 0; j < RTE_DIST_BURST_SIZE; j++) >>>               for (w = 0; w < RTE_DIST_BURST_SIZE; w++) >>> -                if (bl->tags[j] == data_ptr[w]) { >>> +                if (bl->tags[w] == data_ptr[j]) { >>>                       output_ptr[j] = i+1; >>>                       break; >>>                   } >> >> Hi Lukasz, >> >> Could you give a bit more information on the problem that this is >> fixing? >> >> Were you finding that flows were not being assigned to workers >> correctly in the scalar code? >> >> > > You answer this question in the next patch in the series, as you are > adding a test to check the flows go to the correct workers, etc. You > can igonore this question, and: > > Acked-by: David Hunt > Thanks for the ack. And you already probably know the answer about flows, but let me show an example: worker 0 tags:   3 5 7 0 0 0 0 0 incoming flow:   1 2 3 4 5 6 7 8 expected result: 0 0 1 0 1 0 1 0 unfixed result:  1 1 1 0 0 0 0 0 The tags were iterated with "j" variable same that indexed the result table Best regards Lukasz > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com