From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2905AA0A03 for ; Mon, 18 Jan 2021 10:05:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9733B140D25; Mon, 18 Jan 2021 10:05:46 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 6D019140CCB; Mon, 18 Jan 2021 10:05:43 +0100 (CET) IronPort-SDR: OyBRntgtENBm49Gvdi06cbviaK4hg4uNDjc0tjyuWS6VrLsZIWckmDGoKItYfwcRGgtA/8Xy01 PMIXM2IEvkVQ== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="175274187" X-IronPort-AV: E=Sophos;i="5.79,355,1602572400"; d="scan'208";a="175274187" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 01:05:23 -0800 IronPort-SDR: VWyuDRX+oZnJuUMhsVy8GCS1/DaorhWzjdAwU/g+KG0Q4PT3ZxN2ZRJThJzzK5sfw3ljWbcl0Y T2wAkfU2ouhg== X-IronPort-AV: E=Sophos;i="5.79,355,1602572400"; d="scan'208";a="383499967" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24]) ([10.213.241.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 01:05:20 -0800 To: Ivan Malov , dev@dpdk.org Cc: stable@dpdk.org, Andy Moreton , Andrew Rybchenko References: <20210106100601.29299-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit Message-ID: Date: Mon, 18 Jan 2021 09:05:16 +0000 MIME-Version: 1.0 In-Reply-To: <20210106100601.29299-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH 1/3] common/sfc_efx/base: fix MAE match spec validation helper X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 1/6/2021 10:05 AM, Ivan Malov wrote: > A particular FW version is aware of some set of match fields. > Depending on FW configuration and match specification type, a > known field may not necessarily be allowed to have a non-zero > mask. FW communicates such restrictions via field capabilities > MCDI. Newer FW may be aware of more fields. For such fields, > older FW simply does not report any capabilities. > > A situation may occur when libefx is aware of a match field > which the FW is unaware of (eg., older FW), that is, FW does > not report capability status for this field. In this case, > libefx must consider such field as unsupported and demand > all-zeros mask for it when validating match specifications. > > Currently, the helper in question simply exits and reports > that the specification is valid when it encounters a field > with no capability status available. This is clearly wrong. > > Introduce the missing check to fix the problem. > > Fixes: 34285fd0891d ("common/sfc_efx/base: add match spec validate API") > Cc: stable@dpdk.org > > Reviewed-by: Andy Moreton > Reviewed-by: Andrew Rybchenko > Signed-off-by: Ivan Malov Series applied to dpdk-next-net/main, thanks.