Re: [dpdk-stable] patch 'net/tap: fix RxQ errors stat' has been queued to LTS release 18.11.3

[Kevin Traynor <ktraynor@redhat.com>]

On 21/06/2019 17:46, Kevin Traynor wrote:
> Hi,
> 
> FYI, your patch has been queued to LTS release 18.11.3
> 
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 06/26/19. So please
> shout if anyone has objections.
> 
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
> 
> Queued patches are on a temporary branch at:
> https://github.com/kevintraynor/dpdk-stable-queue
> 
> This queued commit can be viewed at:
> https://github.com/kevintraynor/dpdk-stable-queue/commit/639afbff95223fd194cf0865432dbb1e248c83fe
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> From 639afbff95223fd194cf0865432dbb1e248c83fe Mon Sep 17 00:00:00 2001
> From: David Marchand <david.marchand@redhat.com>
> Date: Mon, 4 Mar 2019 12:18:35 +0100
> Subject: [PATCH] net/tap: fix RxQ errors stat
> 

Chatted with David and this series of RxQ error stat fixes needs some
more discussion about backporting. Will postpone applying them at the
moment.

> [ upstream commit 6d84612124417acbe0bbb0b9952cf3270b3b3a0f ]
> 
> Transmit errors must not be reported in q_errors[] which is for
> reception.
> 
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 867873683..e6d1ed6b4 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -971,8 +971,7 @@ tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats)
>  	for (i = 0; i < imax; i++) {
>  		tap_stats->q_opackets[i] = pmd->txq[i].stats.opackets;
> -		tap_stats->q_errors[i] = pmd->txq[i].stats.errs;
>  		tap_stats->q_obytes[i] = pmd->txq[i].stats.obytes;
>  		tx_total += tap_stats->q_opackets[i];
> -		tx_err_total += tap_stats->q_errors[i];
> +		tx_err_total += pmd->txq[i].stats.errs;
>  		tx_bytes_total += tap_stats->q_obytes[i];
>  	}
>