From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE94CA046B for ; Thu, 27 Jun 2019 18:48:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8ECDE20BD; Thu, 27 Jun 2019 18:48:31 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 85CC220BD for ; Thu, 27 Jun 2019 18:48:30 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4DFD83F3B; Thu, 27 Jun 2019 16:48:29 +0000 (UTC) Received: from [10.36.116.250] (ovpn-116-250.ams2.redhat.com [10.36.116.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id E53D35C1B4; Thu, 27 Jun 2019 16:48:26 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Keith Wiles , dpdk stable References: <20190621164626.31219-1-ktraynor@redhat.com> <20190621164626.31219-40-ktraynor@redhat.com> Message-ID: Date: Thu, 27 Jun 2019 17:48:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190621164626.31219-40-ktraynor@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Jun 2019 16:48:29 +0000 (UTC) Subject: Re: [dpdk-stable] patch 'net/tap: fix RxQ errors stat' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 21/06/2019 17:46, Kevin Traynor wrote: > Hi, > > FYI, your patch has been queued to LTS release 18.11.3 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 06/26/19. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable-queue > > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk-stable-queue/commit/639afbff95223fd194cf0865432dbb1e248c83fe > > Thanks. > > Kevin Traynor > > --- > From 639afbff95223fd194cf0865432dbb1e248c83fe Mon Sep 17 00:00:00 2001 > From: David Marchand > Date: Mon, 4 Mar 2019 12:18:35 +0100 > Subject: [PATCH] net/tap: fix RxQ errors stat > Chatted with David and this series of RxQ error stat fixes needs some more discussion about backporting. Will postpone applying them at the moment. > [ upstream commit 6d84612124417acbe0bbb0b9952cf3270b3b3a0f ] > > Transmit errors must not be reported in q_errors[] which is for > reception. > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > > Signed-off-by: David Marchand > Acked-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 867873683..e6d1ed6b4 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -971,8 +971,7 @@ tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats) > for (i = 0; i < imax; i++) { > tap_stats->q_opackets[i] = pmd->txq[i].stats.opackets; > - tap_stats->q_errors[i] = pmd->txq[i].stats.errs; > tap_stats->q_obytes[i] = pmd->txq[i].stats.obytes; > tx_total += tap_stats->q_opackets[i]; > - tx_err_total += tap_stats->q_errors[i]; > + tx_err_total += pmd->txq[i].stats.errs; > tx_bytes_total += tap_stats->q_obytes[i]; > } >