From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FE58A054A for ; Fri, 19 Feb 2021 11:36:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AA6040042; Fri, 19 Feb 2021 11:36:29 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 5DF9F40042 for ; Fri, 19 Feb 2021 11:36:28 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id l17so6596091wmq.2 for ; Fri, 19 Feb 2021 02:36:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=cMD4Xx7h2jp+j+bSmAfS8OqlAuemAA2BD1YwigEm5DE=; b=ILVxwnxFll91wL9zXbrc6OkhpgNU74BmuNWUQ9OCj0TsH2KB40IwkEXumG07dH7SYB D5qVsqNfHUmtJIAZTinEQ9/spVsTEUjgij5LT0xWP8c/Vp0h2pBpO1tFm69At13Q953x CZeZiJGxyE070cRJ9yJ5kTv2NnRK3AGWGF3vLeWI5nowyvPwSVpmZzdLpE/UN0D5ykKN JidxTjc/PcVjDha6C0RWugKmY1KqNZD87VtLNHG9LhlTtbu38BIXPbISrMdb0c7GYn+G Tao2zM/TXJa/pSnbgFPTYmb9rhJUyUBFtoMpuMOrYHb4vgfWRUZH1Iw9VLnauectOxUa y9gQ== X-Gm-Message-State: AOAM5313vvJNMI5JEX/mN/LNp1jMwukc2c0vZJcivZZeYquZhosNdQ6f ppRbjUGmCYdqvK+4aZ4teY0= X-Google-Smtp-Source: ABdhPJzbq35n57o9fMlebEjTup9P7+fWOgCWudya18CujUbB3tUUQ5yr03qdC4yTp7bv/wvQPpwZfQ== X-Received: by 2002:a1c:ed1a:: with SMTP id l26mr7756826wmh.114.1613730988049; Fri, 19 Feb 2021 02:36:28 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w25sm10949999wmc.42.2021.02.19.02.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 02:36:27 -0800 (PST) Message-ID: From: Luca Boccassi To: Viacheslav Ovsiienko , stable@dpdk.org Cc: xuemingl@nvidia.com Date: Fri, 19 Feb 2021 10:36:26 +0000 In-Reply-To: <20210218183922.34371-1-viacheslavo@nvidia.com> References: <20210218183922.34371-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 20.11] net/mlx5: fix Tx queue size created with DevX X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 2021-02-18 at 20:39 +0200, Viacheslav Ovsiienko wrote: > [ upstream commit 00984de53312b8af1bb1b6579d69a3eeda4be381 ] >=20 > The number of descriptors specified for queue creation > implies the queue should be able to contain the specified > amount of packets being sent. Typically one packet takes > one queue descriptor (WQE) to be handled. If there is inline > data option enabled one packet might require more WQEs to > embrace the inline data and the overall queue size (the > number of queue descriptors) should be adjusted accordingly. >=20 > In mlx5 PMD the queues can be created either via Verbs, using > the rdma-core library or via DevX as direct kernel/firmware call. > The rdma-core does queue size adjustment internally, depending on > TSO and inline setting. The DevX approach missed this point. > This caused the queue size discrepancy and performance variations. >=20 > The patch adjusts the Tx queue size for the DevX approach > in the same as it is done in rdma-core implementation. >=20 > Fixes: 86d259cec852 ("net/mlx5: separate Tx queue object creations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_devx.c | 34 +++++++++++++++++++++++++++++----- > 1 file changed, 29 insertions(+), 5 deletions(-) Acked-by: Luca Boccassi Thanks, applied and pushed. --=20 Kind regards, Luca Boccassi