From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Christensen <drc@linux.vnet.ibm.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le
Date: Tue, 16 May 2023 10:55:04 +0100 [thread overview]
Message-ID: <a6163214-4612-7175-84e3-49801686bf34@amd.com> (raw)
In-Reply-To: <20230515182838.08e49a7c@hermes.local>
On 5/16/2023 2:28 AM, Stephen Hemminger wrote:
> On Tue, 16 May 2023 00:35:56 +0100
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
>> Yes only some scripts and possible applications that hotplug tap
>> interface with hardcoded parameters may impacted, don't know how big is
>> this amount but this ends up breaking something that was working before
>> upgrading DPDK for them.
>>
>> And I believe the motivation is weak to break the behavior.
>>
>> Won't it be better to update 'rte_ether_unformat_addr()' to accept more
>> flexible syntax, and use it? Is there any disadvantage of this approach?
>
> It is already more flexible than the standard ether_aton().
I mean to accept single chars, as 'tap' currently does, like "a:a:a:a:a:a".
Agree that impact of tap change is small, but if we can eliminate it
completely without any side affect, why not?
As accepting single char will be expanding 'rte_ether_unformat_addr()'
capability, it will be backward compatible, am I missing anything?
next prev parent reply other threads:[~2023-05-16 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 21:24 [PATCH] " David Christensen
2023-03-22 23:43 ` Stephen Hemminger
2023-03-23 16:45 ` David Christensen
2023-03-23 17:01 ` [PATCH v2] " David Christensen
2023-05-15 23:14 ` Ferruh Yigit
2023-05-15 23:20 ` Stephen Hemminger
2023-05-15 23:35 ` Ferruh Yigit
2023-05-16 1:28 ` Stephen Hemminger
2023-05-16 9:55 ` Ferruh Yigit [this message]
2023-06-07 18:47 ` Ferruh Yigit
2023-06-08 2:02 ` Stephen Hemminger
2023-09-29 13:48 ` Ferruh Yigit
2023-10-06 18:31 ` David Christensen
2023-10-09 9:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6163214-4612-7175-84e3-49801686bf34@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).