From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2C8842B22 for ; Tue, 16 May 2023 11:55:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 953794282D; Tue, 16 May 2023 11:55:14 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 577564068E; Tue, 16 May 2023 11:55:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQ26rQPJN/FiCsL72l8HdnPaSjyoHrswV2Gm/B92rHGBai/fejWHVjlX66aKc9ibQrpsjwuWbG+xOqpDtXbDx8v2A6zXi2iJO9WGtXyuJI3gIXfwHl1+zhCmF9UAkD20Mxomj1P09r5xw0J02j1ZrddyB2FyJZZWNzeorr3azT56ajh+iwJdNOz972okUCpCGfOgd1AQ3nsNt0uok5iwIj6sLIm0K8UnRCtfmTVFyofFt2T46LRMJ1X4BIhlmrFBbCJmlymqVpcsRR5iklkooEdi9RJo+UpQj6D0eFSD4zXjcLKr381QWuqGXgUt57/D1R/iCyJkxo48yBWMu3Aexw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1EQ6SLQStE8GPhHSarCp2ZGeS/0ryqukdAp+QQg2fI=; b=cyyf6Xlrt3NRqOp0Rp4enj2zGO3ahjm7DeRycdp+vcjRQ9DzxJ4X1TLGFNOC1coHNXztrkk8C9fPmcObAMR7bsxVqipG9HnVWVJmltZ9x2i9k+CqUpmUGkWqPekjAIu2AXwx9JOXfTuTj8/8IrUJYP9nfiaPEC4RDz6bJiNYlAvgMh/IUT9SSr9jCqRUtVxUTg6pPxpOezfqMgYcSTEPTe02o9Rn0ODhXVuGs4mycu7tgxBW7oqZH2UdoaytX4dV0WVutSp/41Ih3yEo4qU5I0XXrrFqEfI3mSQvxnT3C0sH62tn8eMPQTmkwVH9UaEph0Q9FHMRQw4JzxDgiAC8sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1EQ6SLQStE8GPhHSarCp2ZGeS/0ryqukdAp+QQg2fI=; b=PjOalGHYNg4ylX3m2VhP9N0pra8/vso/h5vq1NGs45PLIjXOa4oX3LnDNpMmxxAkHWlXV78MXYtyzTVEgIqdUESniUsJMfWTaEA13M7xDXS35tM7+iiGgDg19Ibguwzr0TyzH4+ZMZumJ8QDSzGsDUyeiQ3woRV3Mi6h124ztxg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4170.namprd12.prod.outlook.com (2603:10b6:5:219::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May 2023 09:55:10 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6387.033; Tue, 16 May 2023 09:55:10 +0000 Message-ID: Date: Tue, 16 May 2023 10:55:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Stephen Hemminger Cc: David Christensen , dev@dpdk.org, stable@dpdk.org References: <20230322212439.524725-1-drc@linux.vnet.ibm.com> <20230323170145.129901-1-drc@linux.vnet.ibm.com> <165a233b-b41b-3a65-1866-5b7c94993b40@amd.com> <20230515162032.36a4f3ec@hermes.local> <20230515182838.08e49a7c@hermes.local> From: Ferruh Yigit Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le In-Reply-To: <20230515182838.08e49a7c@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0078.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4170:EE_ X-MS-Office365-Filtering-Correlation-Id: 68af7962-a2d1-4715-abf3-08db55f3a2d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mOEj5QChNWNQSpjdAs3tL1S3beaRluvgoTZbbCL3/1jbylC1e7VBYAN7lRun1KglpZvJGB+0WYPEdZ2MHVhAJFEKY8sGHwEb5NTzjuRPIX6ESbFZ6k6nVThifpdIHOprGpXO4afnU8G83vvYtlvjUljNWkAK09nCa0EYShzDLY8j5B1oLTlmTCn5EYJSVHNTpnzGz7CHNlvanlQwI8C37SPlcgPVGW3JtIZm6sG3lTOoRj/IneEJ0a5WhpWj+eq/b4asaqex4G+7v+L6e/RfToQaudaScoftTTLefpqANEHNNQwz3mAwRHvTNG/UlzJe1Pj517TsVHENOtlMoXel6yPas6uBmGq9zKXO4e3XTy8SOegofhVVdKDULEtWDk7jnixK2w3KdX5elND0h0paI7iVclY27IX46a9++YwmuGAesdbcpNI96IqaAmwSmFyGIiYdISxluTobfRkfoZqgaNwTcjOZYdGYudgt+XeaLPL33UzQF0XieRklV+uZy8AupnSEZB8d5P1jk/AgcERjOhapPClNvJ/bfN+xHwaj0REjU0g9syMBAx/uxu4H0PVFKQLPslJ7JCeRSzIb+veiBf2ndok1ymZ/hPExTzhd/uPvfK6HI+Qqc/NxbzfmnzqkAqoOC97nKtoMepu7T5PLRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199021)(31686004)(66556008)(66476007)(6916009)(66946007)(478600001)(4326008)(316002)(31696002)(36756003)(86362001)(6666004)(83380400001)(6512007)(6506007)(26005)(2616005)(53546011)(186003)(6486002)(41300700001)(8936002)(8676002)(5660300002)(44832011)(2906002)(4744005)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHJRKzJtVEdKZDB1ZDY0SzQ4VER0NENGd1RVaHViUkpkSEF3eGY0V2s0NWtw?= =?utf-8?B?Y282UW44SFo3U0lhYUxHdmRiVm1nbmpzWUlhV2tyVU1CbjVNYnRKVXcrNWth?= =?utf-8?B?YngrZ2Zvd2VJSjBOZjZJSHdnRWhyVEt1dXBlTFROT0lsa1VMbk5ZWnVMWXA0?= =?utf-8?B?Smlnd1VDRlZIeFhxTmJ3S0NFTjNnancvKzA0Z0FWWmNHVEZtQWlxNHdNUEZH?= =?utf-8?B?MkZCLzJFU0NJam9WaHZWODl3aUZ3S0FtOEcwRXJwdVlmcEJRUTBtVlEyMXNt?= =?utf-8?B?bE9uK1ZqU3BSLzIvUVdDcVFRMDdRek85R0VUcnRnVXhUaHBjQ3VVa3lxOFMv?= =?utf-8?B?bVEycThZd0orQjVNSEVSQ3VtMy8zdCt4cm1ybXNLK3RnY0FXT0MwYTdnZmJy?= =?utf-8?B?aDFMNmZ1bEtOV0lTVFZOQ3EwVHdQNWVkbG5CZWdxVTNGZHp4RE9iM1JwTjRr?= =?utf-8?B?bk1vT01YR1BUbXlqL0dsUjBzMGRBQTJBVEtKQ3g4WlVOTFQ4L1F1M080cWJO?= =?utf-8?B?ajAxQmdVdXZuemtieXJtYWdkNFVKYVcrcnNPY3NuOGJkSW5yUDRPWDNySkVB?= =?utf-8?B?UFlGY0dPWVkvOFRvanM2RWE3ZE1XNUQvaDVScWU0RGMrSWJoekEzTE1WeWxp?= =?utf-8?B?QjFiRC9haHZHMVNqdVpFL0xzcVhSZ2pKaTMyTFJZeHRucUFaai8xcTFGV1k4?= =?utf-8?B?Nm94SzNQbnErWmpFM3pMSVRTajVvbjNYRXhwcXZCZGJWVUdEak5xVXhBRkRy?= =?utf-8?B?MkJUdEkxOHppTmFNWmxmN3p2NzQzdCtNRXFzczdMWUJPR0VNdGxvTEFsV2Zp?= =?utf-8?B?a3lPa1JwRkR2WHFZRlRvbkJjV2gzS3J1enFnWFN6RHYvTUxZbTg5SGlva3h0?= =?utf-8?B?M1hPYjVsUEtvd21ySEpLTk05M0s0RTFKWEpYMGQ0V0g4ajJrOExmZ1gxajA0?= =?utf-8?B?QndLRTZYaU1yeFVFQnRWcUdnekNQYlJUU2dnQUJwbHRqV2xoY09zWC9ZU09W?= =?utf-8?B?S0dEY283Q2xwRktHMGxINXFQWkJqYXU4Z0swVTU1akxnajBCcC9samt6MHJk?= =?utf-8?B?K3FnaXJvcWJ5SlFUOXRob2hiaDQ3MDlKb2N5dDBNNm9ZNnhuekd5WC84UEh2?= =?utf-8?B?YzhlMHlJNFFIdXVRRkQyWUZIcmZEcVpFZW5lWUZqVUpDWndoQkxSZXlsZnU1?= =?utf-8?B?aHpXUlVScUQ1Wmd2b3hoRFRmUUdKVUlKK3FEKzROUWFqWFBJcEN1V1l5SDdV?= =?utf-8?B?VG96czZJZUg3MkhpNlFtT1M0dG9nVWlLK0srOWh5cDVRUzlPd2VsemRhNU93?= =?utf-8?B?clhYN1hkZEdDVTdoaVFYenpTeElOUEhtTEEwWFRUYjQ4VFg3eitYci9zSmZ3?= =?utf-8?B?S3hxKzdaeEtDVTE2ZW1oRjRmQjhybndvT3BIa2pveVhQV25LVEo1R01mY2Va?= =?utf-8?B?dnJyWERkSmVqQWgwc3p0NTZKVmdxd0c2dFNHcWpHNzVEd3BtenJBMjhFZWVH?= =?utf-8?B?em1Walovd29QejROR2pyQVNQanlVTk1KeVo4ejNpVUFsbmUvZjQzcXZGcFNI?= =?utf-8?B?OWU5MVMxQ1NCUFlFdXliRCt1cW9Pd3RpYmplY3lCNE5FdUNKWTVwRjZCWFJK?= =?utf-8?B?ZjdkY1FDZHhQZWEvZi9GZHV5SGdVMW14YjM5cU85SldFU0JmNGpiMGVVSXVR?= =?utf-8?B?MjBOUnhiQjFCSTdzRzBBRlFNdk9EWm5uTzA4aExLMzM3TTBIMmZHdkhCMW9t?= =?utf-8?B?SzhkTDBKVnI5cHVlZDNiWjZjUHRlaFNjcHdJb0pOU0o1RlhzRU0vRzJBQS9h?= =?utf-8?B?a1lWemNhb3BzaCt2U3NiUXRGQWRZd1hvdVF6N3Znb1B0ZDEyNndteWdMeFcx?= =?utf-8?B?L0Fyc3JUOVc2cDQ5OE5ydUNSVzhxU0QwTW1NLzJKSStJcC84b2M2dHJ3NWlS?= =?utf-8?B?Vm5KUyt2Ny9FRGJVOU5HcDQvbWRnWnJqeEYyd0xNKzRmalY1OStKTXNmd25P?= =?utf-8?B?eWZLVXBRQy9ScUxsQmNXZktuVVgxamZDemdpNWxBZ1JtbUZWNFdUd3YvYlBh?= =?utf-8?B?c1BpRlhsT1loVmlhZ0M2M2hkN0RYY1BGUjNJYjlUQ2FDdWk1Nnk4OHJxalQ2?= =?utf-8?Q?JiMcjgZqePq4hoO0t7b6SiaFq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68af7962-a2d1-4715-abf3-08db55f3a2d2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 09:55:10.2698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MWAwzRy7uTL0LiTIfp8LYMgnd+zCiTNWOXiAmS77kUDki+Etx4C8+SZsEvmWZxiO X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4170 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/16/2023 2:28 AM, Stephen Hemminger wrote: > On Tue, 16 May 2023 00:35:56 +0100 > Ferruh Yigit wrote: > >> Yes only some scripts and possible applications that hotplug tap >> interface with hardcoded parameters may impacted, don't know how big is >> this amount but this ends up breaking something that was working before >> upgrading DPDK for them. >> >> And I believe the motivation is weak to break the behavior. >> >> Won't it be better to update 'rte_ether_unformat_addr()' to accept more >> flexible syntax, and use it? Is there any disadvantage of this approach? > > It is already more flexible than the standard ether_aton(). I mean to accept single chars, as 'tap' currently does, like "a:a:a:a:a:a". Agree that impact of tap change is small, but if we can eliminate it completely without any side affect, why not? As accepting single char will be expanding 'rte_ether_unformat_addr()' capability, it will be backward compatible, am I missing anything?