From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A5ED27CCD; Fri, 15 Sep 2017 11:25:48 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2017 02:25:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,396,1500966000"; d="scan'208";a="900535144" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 15 Sep 2017 02:25:44 -0700 To: "Yang, Qiming" , Thomas Monjalon Cc: "dev@dpdk.org" , "Tan, Jianfeng" , "Thotton, Shijith" , "Hu, Xuekun" , "Patil, Harish" , Gregory Etelson , "stable@dpdk.org" References: <1836615.UbEDzhAzGh@xps> From: Ferruh Yigit Message-ID: Date: Fri, 15 Sep 2017 10:25:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 09:25:49 -0000 On 9/15/2017 10:18 AM, Yang, Qiming wrote: >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Friday, September 15, 2017 4:43 PM >> To: Yang, Qiming >> Cc: dev@dpdk.org; Tan, Jianfeng ; Thotton, Shijith >> ; Hu, Xuekun ; Yigit, >> Ferruh ; Patil, Harish ; >> Gregory Etelson ; stable@dpdk.org >> Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open >> and release of device file >> >> Hi >> >> 15/09/2017 10:04, Yang, Qiming: >>> Hi, Thomas >>> We meet a urgent issue because of Shijith's patch. >>> When use DPDK version 17.08, DPDK VF driver and kernel PF driver, i40e, ixgbe >> and qede(Harish said) VF all meet initial failure. >> >> This patch has been integrated in DPDK 17.08-rc2 (2 months ago). >> Why a so obvious issue is discovered only now? >> >>> This issue only occurred when use 17.08 igb_uio, vfio-pci and 17.05 igb_uio all >> works well. >>> Considering this issue will block our vf driver develop and test work, could we >> revert this patch first and find another appropriate way? >> >> We need to be sure the revert is the right solution because it will be backported >> to the stable 17.08 release. >> >> Shijith suggests to "try removing pci_reset_function from igbuio_pci_open." >> Can we try this first? >> Are we sure the bug is not in new firmwares? > > I have tried to remove pci_reset_function, it works in my environment, but it doesn't work in someone's enviroment. > And removing this function won't it changes the original purpose of his patch? So I'm not sure it is a good solution. Yes, removing that will be functionally almost same with revert. > This bug is not a firmware version related issue, we can reproduce stably with older firmware. I also think this is not related to the firmware. But I don't see why works with one version of the Linux PF driver, but not other. > > Qiming >