From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28B90A32A2 for ; Thu, 24 Oct 2019 17:59:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EAFE31EB40; Thu, 24 Oct 2019 17:59:08 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id C190A1EB40 for ; Thu, 24 Oct 2019 17:59:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571932747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FE1ppdJt94Smns2WGAkaCU5+ld0h6cH/AmeiMrwAM+s=; b=B3EvxDD7dYGoC1K4uLsatXV7DUfLh0P/9SCKo0UgsheLS+InSn2jQZaU9bjmGNxfAVy3jo +pcjAjy+5jm9FEjRsNAKl1qV+0EWl3Z6q9UVAwMfN/HL+0gIn2ziSVyCaQdJIHZe+j6J5L HQHiu5CqO9ziBb0twQcjhvSWG2BDX8U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-vj6egkxWP2Wh3Gwrs80H_A-1; Thu, 24 Oct 2019 11:58:55 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9BE1C476; Thu, 24 Oct 2019 15:58:53 +0000 (UTC) Received: from [10.36.118.52] (unknown [10.36.118.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B1585D70D; Thu, 24 Oct 2019 15:58:52 +0000 (UTC) To: Luca Boccassi , Christian Ehrhardt , dpdk stable Cc: Thomas Monjalon References: <20191021111634.15500-1-christian.ehrhardt@canonical.com> From: Kevin Traynor Message-ID: Date: Thu, 24 Oct 2019 16:58:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: vj6egkxWP2Wh3Gwrs80H_A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH 0/3] kni: fix kernel 5.4 builds X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 21/10/2019 18:30, Luca Boccassi wrote: > On Mon, 2019-10-21 at 13:16 +0200, Christian Ehrhardt wrote: >> Hi, >> I've got a report [1] from our kernel Team which regularly pre-checks >> new kernels ahead of time. All of this is about kni/ethtool failing >> to >> build with 5.4. >> >> I know that going forward there is [2] so the master branch doesn't >> care >> anymore. >> >> To be clear, Thomas was rather straight on this topic on IRC :-) >> [11:18] cpaelzer: Drop KNI ethtool from your package! >> [11:20] That's a lot easier than maintaining this... thing >> [11:31] tmonjalo: that is true and correct for the future, >> which also reflects what happened in master branch >> [11:31] tmonjalo: but the past is the past and I guess I >> need to fix it there >> [11:34] cpaelzer: there is another way: drop it and wait >> for requests ;) >> [11:35] I'm not bold enough to do that >> [11:35] but I already have it in the not officially >> supported packages >> [11:35] so I can worst case just stop caring, but then I >> like to fix things ... >> >> But I wondered if we should keep it a bit alive at least for a while >> for >> Distributions that carry it as package. Personally for Ubuntu that >> would be >> around the time of whatever kernel is recent April next year and >> valid >> for DPDK 17.11 and 18.11. But needs surely will differ for different >> distributions. >> >> Here is a patch series intended for stable releases only, tested with >> kernel 5.3 (old behavior) and 5.4 (new behavior). We might want to >> have >> someone test other distros and other (older) kernels as well maybe? >> >> I'm throwing in the patch series as suggestion for a fix, but it >> might >> as well be just the start for a discussion to document the projects >> thoughts about released e.g. 17.11.x/18.11.x versions carrying that >> package and how they are suggested to handle kni-ethtool being sort >> of >> unmaintainable. >> I'll surely start that discussion with Luca for the Debian/Ubuntu >> scope. >> >> [1]:=20 >> https://bugs.launchpad.net/ubuntu/eoan/+source/dpdk/+bug/1848585 >> >> [2]:=20 >> https://git.dpdk.org/dpdk/commit/?id=3Dea6b39b5 >> >> >> Christian Ehrhardt (3): >> kni: fix kernel 5.4 build - merged pci_aspm.h >> kni: fix kernel 5.4 build - num_online_cpus >> kni: fix kernel 5.4 build - skb_frag_t to bio_vec >> >> kernel/linux/kni/ethtool/igb/igb_main.c | 12 ++++++++++-- >> kernel/linux/kni/ethtool/igb/kcompat.h | 10 ++++++++-- >> kernel/linux/kni/ethtool/ixgbe/kcompat.h | 10 ++++++++-- >> 3 files changed, 26 insertions(+), 6 deletions(-) >=20 > Series-acked-by: Luca Boccassi >=20 > Given we are shipping with it we need to support it for the lifetime of > the branches, so thanks for the patches. >=20 Thanks Christian and Luca, applied on 18.11 branch