From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D898A0351 for ; Mon, 17 Aug 2020 15:42:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 163CB54AE; Mon, 17 Aug 2020 15:42:37 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 469A154AE for ; Mon, 17 Aug 2020 15:42:35 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id 3so13942170wmi.1 for ; Mon, 17 Aug 2020 06:42:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=u39XRpP1TDKwHB1iX5Nop2dw6z9qVlqo3A48CW09bsM=; b=nnfX8OcdEl7kxLJpm/Z7T4U99G6SaS5vFEmShiPatofZJuU4kqxIYUs2TmnlZhV3Pb rkDk3fs1hQzE8cFrXA54lzyJRYbgCQSZ/pLTVgO1ZaJ8TpnNF2j5jXN2alQ3jA5xA8xr 2PPLUZNXW1rmSUzmQI90mEz7NXernD+FsCFxeeIVS7uLvIzlkq/jd/C6HgnFCeNPUBtX efgiCtWkRmJ+a0VJDSDtVioum3Rprxjuv35BCU4sCqnfkqAiOmuUbPDbUoeUw09YozyQ meQQO97t/mfcs+j+D+iCGTtdtBRYxm9tNHa4MG2jYmgXZJfu9Qz7wpgtte5OOgD7bdna xyUA== X-Gm-Message-State: AOAM531BwsQy5Ws/mTkdBAIwodh8VrAR75zevL/sf+3x1mGopj+DCF4E xecxDxrRCQOJSpxsN5hWnGY= X-Google-Smtp-Source: ABdhPJz4e5nZpkiqPMTW4Jxo5O/X9p/ebq/VvQxo2vLE/ON3qs1SLaL6IQZJQqXva9zkd38nsNt33w== X-Received: by 2002:a1c:66c5:: with SMTP id a188mr14228235wmc.173.1597671754920; Mon, 17 Aug 2020 06:42:34 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id f63sm29226156wmf.9.2020.08.17.06.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 06:42:33 -0700 (PDT) Message-ID: From: Luca Boccassi To: "Wei Hu (Xavier)" , stable@dpdk.org Cc: xavier.huwei@huawei.com Date: Mon, 17 Aug 2020 14:42:33 +0100 In-Reply-To: References: <20200817092532.59530-1-huwei013@chinasoftinc.com> <329c65f3192cb88ad8f785884630717f7d9fe906.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 00/24] backport for 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, 2020-08-17 at 19:54 +0800, Wei Hu (Xavier) wrote: > Hi, Luca Boccassi >=20 > On 2020/8/17 17:51, Luca Boccassi wrote: > > On Mon, 2020-08-17 at 17:25 +0800, Wei Hu (Xavier) wrote: > > > This series are backport for 19.11.4 about hns3 PMD driver, bonding > > > and testpmd. > > >=20 > > > Chengchang Tang (6): > > > net/hns3: remove restriction on setting VF MTU > > > net/hns3: support promiscuous and allmulticast mode for VF > > > net/hns3: fix adding multicast MAC address > > > net/hns3: decrease non-nearby memory access in Rx > > > net/hns3: support setting VF PVID by PF driver > > > net/hns3: cleanup duplicated code on processing TSO in Tx > > >=20 > > > Chengwen Feng (1): > > > net/hns3: get Rx/Tx queue fbd in xstats > > >=20 > > > Hao Chen (1): > > > net/hns3: optimize default RSS algorithm > > >=20 > > > Hongbo Zheng (3): > > > net/hns3: get link status change through mailbox > > > net/hns3: support TSO > > > net/hns3: check TSO segment size during Tx > > >=20 > > > Lijun Ou (4): > > > net/hns3: remove unnecessary branch > > > net/hns3: support symmetric RSS > > > net/hns3: report Tx descriptor segment limitations > > > app/testpmd: remove hardcoded descriptors limit > > >=20 > > > Wei Hu (Xavier) (8): > > > net/hns3: support setting VF MAC address by PF driver > > > net/hns3: get Tx abnormal errors in xstats > > > net/hns3: get PCI revision ID > > > net/hns3: support LRO > > > net/hns3: get device capability in primary process > > > net/hns3: support copper media type > > > net/hns3: fix reassembling multiple segment packets in Tx > > > net/hns3: fix inserted VLAN tag position in Tx > > >=20 > > > Weifeng Li (1): > > > net/bonding: change state machine to defaulted > > >=20 > > > app/test-pmd/cmdline.c | 11 +- > > > app/test-pmd/testpmd.c | 171 ++++++ > > > app/test-pmd/testpmd.h | 2 + > > > doc/guides/nics/features/hns3.ini | 2 + > > > doc/guides/nics/features/hns3_vf.ini | 4 + > > > doc/guides/nics/hns3.rst | 2 + > > > drivers/net/bonding/eth_bond_8023ad_private.h | 3 + > > > drivers/net/bonding/rte_eth_bond_8023ad.c | 21 +- > > > drivers/net/hns3/hns3_ethdev.c | 269 ++++++-- > > > drivers/net/hns3/hns3_ethdev.h | 34 +- > > > drivers/net/hns3/hns3_ethdev_vf.c | 578 +++++++++++++++= --- > > > drivers/net/hns3/hns3_flow.c | 12 +- > > > drivers/net/hns3/hns3_mbx.c | 93 +++ > > > drivers/net/hns3/hns3_mbx.h | 13 + > > > drivers/net/hns3/hns3_rss.c | 35 +- > > > drivers/net/hns3/hns3_rss.h | 6 +- > > > drivers/net/hns3/hns3_rxtx.c | 525 ++++++++++++++-= - > > > drivers/net/hns3/hns3_rxtx.h | 65 +- > > > drivers/net/hns3/hns3_stats.c | 243 +++++--- > > > drivers/net/hns3/hns3_stats.h | 3 +- > > > 20 files changed, 1779 insertions(+), 313 deletions(-) > > Hi, > >=20 > > If I understand correctly, this series adds support for 6 new features: > >=20 > > --- a/doc/guides/nics/features/hns3.ini > > +++ b/doc/guides/nics/features/hns3.ini > > @@ -8,6 +8,8 @@ Link status =3D Y > > Rx interrupt =3D Y > > MTU update =3D Y > > Jumbo frame =3D Y > > +TSO =3D Y > > +LRO =3D Y > > Promiscuous mode =3D Y > > Allmulticast mode =3D Y > > Unicast MAC filter =3D Y > >=20 > > --- a/doc/guides/nics/features/hns3_vf.ini > > +++ b/doc/guides/nics/features/hns3_vf.ini > > @@ -8,6 +8,10 @@ Link status =3D Y > > Rx interrupt =3D Y > > MTU update =3D Y > > Jumbo frame =3D Y > > +TSO =3D Y > > +LRO =3D Y > > +Promiscuous mode =3D Y > > +Allmulticast mode =3D Y > > Unicast MAC filter =3D Y > > Multicast MAC filter =3D Y > > RSS hash =3D Y > >=20 > > None of those are available in 20.02, and LRO is not available in > > 20.05. > >=20 > > What happens if a user upgrades from 19.11.4 with any of these features > > enabled to 20.02 or 20.05? >=20 > If a user upgrades from 19.11.4 to 20.02 or 20.05 based on hns3 network= =20 > engine, >=20 > some features of hns3 will not be supported. But in many cases=20 > customers prefer >=20 > to use the LTS version. We will recommend them to upgrade from 19.11.0= =20 > to 19.11.4, >=20 > and will recommend that customers upgrade from 19.11.4 to 20.11.0 after t= he >=20 > release of 20.11.0. >=20 >=20 > Regards >=20 > Xavier Sorry, but I don't feel too comfortable adding multiple new features to the LTS branch, especially as they are not available in the following release. Stable is valuable because it is stable. Since we got ABI stability now, users that want new features can upgrade to 20.02/20.05/20.08 without any application breakages. Would it be possible to break this series into a smaller bugfix-only patchset? --=20 Kind regards, Luca Boccassi