patches for DPDK stable branches
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/enic: re-enable link status change interrupt
Date: Wed, 6 Nov 2019 17:38:08 +0000
Message-ID: <a81ca36c-1308-9d1d-d565-64ca45774628@intel.com> (raw)
In-Reply-To: <20191102013502.17965-1-hyonkim@cisco.com>

On 11/2/2019 1:35 AM, Hyong Youb Kim wrote:
> When INTx is used, the interrupt handler needs to explicitly re-enable
> interrupt in order to receive another one in future. The LSC interrupt
> handler currently does not, and the link state never gets updated when
> INTx is used (e.g. uio_pci_generic). Call rte_intr_ack() at the end of
> the handler, to re-enable INTx.
> 
> Fixes: fefed3d1e62c ("enic: new driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> ---
>  drivers/net/enic/Makefile    | 1 +
>  drivers/net/enic/enic_main.c | 2 ++
>  drivers/net/enic/meson.build | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile
> index 10736a567..686efa5af 100644
> --- a/drivers/net/enic/Makefile
> +++ b/drivers/net/enic/Makefile
> @@ -13,6 +13,7 @@ EXPORT_MAP := rte_pmd_enic_version.map
>  
>  LIBABIVER := 1
>  
> +CFLAGS += -DALLOW_EXPERIMENTAL_API

Can you please add which function(s) requires this flag, as comment, both for
make and meson?
This can help figuring out when to remove this flag.

>  CFLAGS += -I$(SRCDIR)/base/
>  CFLAGS += -I$(SRCDIR)
>  CFLAGS += -O3
> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> index f5b9b0dcb..57574a5f7 100644
> --- a/drivers/net/enic/enic_main.c
> +++ b/drivers/net/enic/enic_main.c
> @@ -448,6 +448,8 @@ enic_intr_handler(void *arg)
>  	enic_link_update(dev);
>  	_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
>  	enic_log_q_error(enic);
> +	/* Re-enable irq in case of INTx */
> +	rte_intr_ack(&enic->pdev->intr_handle);
>  }
>  
>  static int enic_rxq_intr_init(struct enic *enic)
> diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build
> index 1bd7cc7e1..204c97fa0 100644
> --- a/drivers/net/enic/meson.build
> +++ b/drivers/net/enic/meson.build
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2018 Cisco Systems, Inc.
>  
> +cflags += ['-DALLOW_EXPERIMENTAL_API']
>  sources = files(
>  	'base/vnic_cq.c',
>  	'base/vnic_dev.c',
> 


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  1:35 Hyong Youb Kim
2019-11-06 17:38 ` Ferruh Yigit [this message]
2019-11-07 14:42 ` [dpdk-stable] [PATCH v2] " Hyong Youb Kim
2019-11-07 20:33   ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a81ca36c-1308-9d1d-d565-64ca45774628@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=hyonkim@cisco.com \
    --cc=johndale@cisco.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox