From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8FF048A1E for ; Wed, 29 Oct 2025 02:49:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89BC840262; Wed, 29 Oct 2025 02:49:08 +0100 (CET) Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012062.outbound.protection.outlook.com [40.93.195.62]) by mails.dpdk.org (Postfix) with ESMTP id 916F240262 for ; Wed, 29 Oct 2025 02:49:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kx1A7eECgMN/BdprrWhPs+uuvrgt6/cJzAW5qS9+JmPp48m0ys5+2v6rDRdH+a523sBYeOg5BK+om0PAVSJ/Pu+X5yj5NQMioelR54MtRkkImXEfIxg/ftSQGTla04kdRpgGeZWGgQc96h0oboRvJyROiT3moWDfVO75S+5eDqHkPTm6+uwGFJP4Tv1sA5wpvNwZTyCuouVWw+RrSALWrODQD83BxmamnYL283aEvGXMU3khOzsLhzo4vVV61xy3w94fwinJvsqWzxeibrOvGCUOxA0ioKaT3f/S2mULiCbGf+ZCfOCGV5axT2pHJCHUhTiBzkfeC2CLD5iGHF6Lkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAxcLwAM2YxRTStYZaVmj6khNj+CAjZmbnOtpDKnq2A=; b=IkeoVoIzsMwbd8+LtzQGE1WducfgvnEPk2n4062mKq8L+Lth1ASKm39DLTfhkHEx1fcVNlcR/FFhgeXUH1j6NVUfEXEW2BbDXmPytkh0ssWaipXIvnOY8Nlc2SkKxtyVPcDQ+hV0WWZnfQ3Zw4Wb5ayVcjGyVqUmh4pu4my0hrHxupu+iNoUvYws5yDl5Q7XfgfQM01UF7pUR3NFtPxCWmKvzi2bINe1ufBDcJ9Io3rAZBUhDRKh+pRZ41MExIjILwzPDdTrVKyY5HLqQCfCxFVIZS1xSJ6O9Z5d7GV3MLK99aLZO7c1KM8f/xcGJnUdDT+ZgwYihgzQWn2leWOMiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAxcLwAM2YxRTStYZaVmj6khNj+CAjZmbnOtpDKnq2A=; b=Ao3/4cdd9RAjlaBtevMwaZCdpVEWMJawGAWWnYWeAqelOdUWwG1oyIe6yg65Xc7taXVbMyo4CJJCuj9DwTA7n/4mPnu/KngZcYX3StMuqfQwW72bsN/FG2GVWMsjgXH5jafE/Q7Sr0pGL5ooOKb+BI80GKXvr8w9zBprXiIkySfQ2fm7S8oikPEJTl+x3yIirhkXFjBgQKJ8J9QVIAxh/7gp7ssIx/ww2f7HbEufiQhhs2swp9dkEbRNhVHKCwhttAbs/pd5Ly6dmbb3gloeae1g46sUMSvb8JJRi1jQZKLA90V/e1TmvemCvtT9Ylyj7lyCkEyiAF3xrjL7is3zdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB8443.namprd12.prod.outlook.com (2603:10b6:8:126::14) by DS0PR12MB9038.namprd12.prod.outlook.com (2603:10b6:8:f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.13; Wed, 29 Oct 2025 01:49:02 +0000 Received: from DS0PR12MB8443.namprd12.prod.outlook.com ([fe80::f2f9:e6e:f9c8:4b8]) by DS0PR12MB8443.namprd12.prod.outlook.com ([fe80::f2f9:e6e:f9c8:4b8%3]) with mapi id 15.20.9275.013; Wed, 29 Oct 2025 01:49:02 +0000 Message-ID: Date: Wed, 29 Oct 2025 09:48:56 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH22.11 v1] net/mlx5: fix age checking crash To: Luca Boccassi , Thomas Monjalon Cc: stable@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, michaelba@nvidia.com References: <20251028081601.1749225-1-rongweil@nvidia.com> <3058440.n97fhnxGW3@thomas> From: rongwei liu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PSBPR02CA0010.apcprd02.prod.outlook.com (2603:1096:301::20) To DS0PR12MB8443.namprd12.prod.outlook.com (2603:10b6:8:126::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB8443:EE_|DS0PR12MB9038:EE_ X-MS-Office365-Filtering-Correlation-Id: cd2ea551-6d8c-4089-7c16-08de168d561c X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dCtYNWNvbHFPU2t1L1haYmpuKzBYdWUrY0NML3dUU0dZTXVZZmE0Z0tpQWVM?= =?utf-8?B?eHpGYjVkMUcvdXd6TVppcFlieEpHbnJ6TTJQNEIwa3BXZzRBQW8yZCs1U29O?= =?utf-8?B?VFJuN2RWWGQ2M0J5R3N0cWFESTZ4RTlKc2ZSTEZFa1NxR2w1VnlWeFZodW5x?= =?utf-8?B?NlRIKzBOOXY2aXBzZEZreUN1ZnEzWHN3U0taQzJ0eWNjdEdPeDM5ZS8zV2dZ?= =?utf-8?B?SHdDOThjNmRzczhGR1BzczlXZ29kNWdIbURMYm5SUEU1Q0RXaFlucmhGMDdK?= =?utf-8?B?MXBOZFFrejE2d3dxaktBUkxDMGR0ZitmQW12clgrcmtJWGpOOVZjSzZhd0lL?= =?utf-8?B?RGIzdEF2RmNRRjZLTkVUYldrZ3dSQ09XOC9DaU5CNmpaMkNUV0N3TG1XUitT?= =?utf-8?B?eXhkRzFlb0J0YkdMdkVxbzV1VS96RWx5NFV1endxQzZjU3p3cXF3bWxlaDE3?= =?utf-8?B?U1VLTXAwVUxRRlhoNCtXMWZkYnRGeVdDbG92MDRIVWF1T21NN0VIdEdackRw?= =?utf-8?B?MXh2aGVvdFhOZzIzb3QwaUdEdHYweG5ueWFCZEovWm0rYXYySkRqREdSZWV2?= =?utf-8?B?Rk9KWWJtWnhCTm0zUDY2V2liWmZrNjRnYmhpSlVlcEY2TU9NRmFDVjErVDF3?= =?utf-8?B?NHlmUnlqSGR3bmZ6YWpKNlBobkRpeUE0TWg1Yk1TNlRDWWFzODdKdTEyVG9l?= =?utf-8?B?bW5OMS9nL0Q0Q2NTNllyTUUzOUxwRHBoSlQ4NHZUNEwxOFhGV0V4RmNzbWVn?= =?utf-8?B?V2pidWlxbm0ydTF5bS9nZmZ3V0xTS0k3Y2d4c1E2Wmw4K1BsNWFWeGpmZU43?= =?utf-8?B?eldqa3VlSVRmSWxMT1FmRUVSbjQ0K1NJSTdtNGduQUFWZ2FSbngvbE92ZGEz?= =?utf-8?B?bkZjQllQbVp6VlRJMDRNWWFXeXlXYmNsZlNFYnRRbkNVVWs0YUV0NEtyNFBy?= =?utf-8?B?NVFKSUU1R0dmbndEeG53ZUZwY2c5MjJia1hPLzVSUUdrWjFRMjhYREgwLzlw?= =?utf-8?B?RVY1dStBcEZrTThMamZvTHJlZytvQlBrVDJ2L1h6bGdjdHdMaGVPdXQ0R0sx?= =?utf-8?B?S3p5NEVuNThzK2ZKZTJ1cmFFd1lpdittaThXM0NTeFlkY0ltRVVZcDRzYktB?= =?utf-8?B?ZGdvbGhYSGVYY2dGWXEycjUrKzlkLzJXYzRNSjBXS0owc3B3Vm5EVjJzRlNP?= =?utf-8?B?UXEwbTBZaUtVNXI4S3U0aWQ1aTRPUVorQWtiK2tVM0gvMzVwbXdzdElEZkF1?= =?utf-8?B?ZG43MEZaSEhoVzlTZjMvN1ErWVMvR2xEcGNaNUhCU3pHb1RLcEU5K1lTbTRp?= =?utf-8?B?M1lvWENsQ2tUSGhFVmZZdjhUamozTFkzb3hTRktEK0JjbkpLa0loelRoV2VD?= =?utf-8?B?dkY2R3ZtcWE4MWNtZnZza3lZWlliaWNlWVVPSEtQM25WVXJKa2xmMzJ2RUwv?= =?utf-8?B?VnJCb3BhemxRbHhMYlJhZnY4ejQ0N0VFNitZMTExUVFyeFRNN2J0QU90ZzUx?= =?utf-8?B?ZUdldmpmeXRMSlVuMUlKSXBEMXVlZmxiQUJSSzZER1JmZ0ZuY2swUGFPRCtu?= =?utf-8?B?cGZPSEtnc2xCZ3UrY2xMWk5HY1BPMjN5d1ltNFZlMEw0RU1YNlVINFc2SEtD?= =?utf-8?B?eGZ3cWZxejM1WVQwWnp3V0R0ejJqajBwbCtibm5BSE94MUMzdkMwNGUraWs3?= =?utf-8?B?ZS9hZ3JOcFBBMzljU2lGcDl3Q0ZBUVlRS0JZWnc4SkdjOEMzYjhCR1VTNS9m?= =?utf-8?B?WSttS2ptc1lsWWpxOE1TWnU4M0lCQWN2alJDQTdhY2hTQ3ZLWklmV29vZWdn?= =?utf-8?B?NUZkdUhSQ2drQ2NaaTBsOEtmOEh2WXh5N1lpNEN1Qjh2dEtVODNlZ2h4L3V4?= =?utf-8?B?RTh2VEN1NEdFV3FadC9nb2hQbFczYVpJbFZVWS9YbXhLWWhkbjdWQVNaUFRE?= =?utf-8?B?R05zM1NWRjl1T1NpT3c3NUpXUEFCdWhRK0NsM1RKanBKem16YVVGYU1Ud3g3?= =?utf-8?B?akw3Z2pJWFNBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR12MB8443.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3hJdWRRRTE1MWVtc0VINndnSG84cnR4Tkl3TElYNVpXK2p6VjExMlhxL2ha?= =?utf-8?B?Z3QwL2VDNTVVVlJDaVh4bys5bDcyMll6dFpUeGtPV3hkY092N2pWRU15UXZS?= =?utf-8?B?RnlWSTBVaGFWZitDaVdLN1FISlhGMFpaOHNySDBlTUpvWk5vM1c5R3ZGb3Np?= =?utf-8?B?Mi8wcWk0Q3BCdk1mdHByd1dWQlFqVzg4WlVRUTZIYUx1a1dUVW15UGgzWFlx?= =?utf-8?B?QWJoeG1YVHM4dUcyVTVKRitaUW80SzBUWmZ0aXJja0ZkL3FQU0gvVUhYR2d1?= =?utf-8?B?TGU0NXdUWXpIRnp5VVp0MlB1UVlLUUlXSlNyNW92RFdSVUh6SUo3SW1yVFlj?= =?utf-8?B?Vm1HUUJvV0FqREpNcU9jK3RHUFlUNFhXcHVFejY5Sy9YY2xKcUlNeWhFc3hP?= =?utf-8?B?SldVekxPU0xib2tsckZFbjRlRko3MDU4TjlxMGg4RE5qZkNEa0J0YkdiaCtG?= =?utf-8?B?em41T09sQ0ljOHJpK1JCYWlxbFAvUDBZa0dMM2dJalJkOTVNcWdxa2dkQkRy?= =?utf-8?B?S05WUXQvOUNrVVlwNmdEQUxDTjh2VEY4aWhDbGZYQ2NndGRCTStzVXdXQjZs?= =?utf-8?B?bVRzeWY2Q2ZZV1p2T0VxdTBxUlZzV0dDNTlPUE9FTzZSNWY1K0hvdUpxdStL?= =?utf-8?B?RXp1aHcrQXhYeklGRThLVFpoVGxXU2Noam9mNVRJOVJjQWZzKzRPdHFzbk84?= =?utf-8?B?TFZxNnUwTGQ5Z3NDMVBvQ2RYblV2UXVhMjBnVURRaU9KdkEyTVpPSzNBL0U1?= =?utf-8?B?dVN5NkNwNHhLVkFUNzZybGl2Q2E1cUszOUJFRzlPM0QwdEtOZEhKR1hHRUtX?= =?utf-8?B?WlJxUU41aWx5RHZsdFhPb2NkQWh5YTcyeGlkWi9LOHRSM2ltVkVzNmxDclBI?= =?utf-8?B?L0tvRjl0UEIzd2VZYm9IcFdaMVQyMkV6YzZxU2FOemx6NzM0cWoyWXBNdzl2?= =?utf-8?B?Z29OMktyZXhEU2EwOWtrKzZhQk42bG9sRkpINXFmZ2ladWFwN2JDYjhlZGNL?= =?utf-8?B?RU5RZHVpWXhucTRzYzNuSnd0N2ZMNXJ6TkxZbFBTWlVFWnBlQVVmQWlvckwx?= =?utf-8?B?czFjY211NG5GYmdILzJGSFJkQnJuZU1NTUZNWlRPWC9FT2lrZUd3cEdDZ0cz?= =?utf-8?B?eXdPRWpQRXV0UnQzWEl1S04vazhvbFZpTjZKS3hUZThuUGp3YkNzbDErWlhW?= =?utf-8?B?RldZVTBxZUlPWUtOaU5jUk0vVmF2YnFNSTNEcmk5MjhDWEdVOEdPdWR1WDR5?= =?utf-8?B?KzkreE9lYUNoYjg4WGNnT2lFOFdZS2tYN2Q1UStJRFRhRDFtYjdkd2xzSlJK?= =?utf-8?B?K21MZlRKNjhuczdQZncvTHZ0RVhZV09VWGtJTjljSFh5aldZUG9SWitrZW4r?= =?utf-8?B?cGdzZXN2Nk1JK1k0MDZhL3ZIWEtFVHBQalJQSFVhdkU1Y2g5UG8xekdBVFZP?= =?utf-8?B?b2UyNDBEbnFzdTNGZU96Q1RNRmI5SmNpZ1lodUZVTDZLRlFkWWhaZllhSmVh?= =?utf-8?B?Zk5tb0xia2JGRjRpNjVCTkZMdW9HOE01UVVmWmIyQS9janpLOW5CbnQ4NHdz?= =?utf-8?B?R21LS3hpdVA5UjBnaE15UEpEVTl0V1pmbCtKbGlpellDWnlyV1A4eHZBbkhy?= =?utf-8?B?N1FqSzVSWGQzUDVCUklMbmtnQlJOZVNrQTk2UUxLL3BMcGlxSk1tSlRuSWRu?= =?utf-8?B?eEdkcjh2TStWd2pQeTByNC9EWmJ1ZTN4MW04SGhUVkRjVU9rbjhmZGpNY2wx?= =?utf-8?B?dWZlTFJjaklRZ3ZSOXpNaXIrdjM5R1JWRHd2cEFTNDk0K0ttbTBGa0tOL25H?= =?utf-8?B?VEtBMklMTjNDQVBGYS93Y2E3MlFSUWNMQ1dKM1ZoWExkZk51TklqVVEwQlhh?= =?utf-8?B?ekNMWklKMWRaNDY0NGM3RGZQWmxBOFhxcy80L1FzNFM0ajFMeUtPYnpnOSti?= =?utf-8?B?bFhxUlM5R0IxbVVJenM1cENad1dtZm9KTUJ4ZEpzcHdpSmMzTTFyUGVWR1JM?= =?utf-8?B?aUUrM3VDQk9wOUl3aGtSbC8vU05MYVFTZWFwOTJ4NE9NangrUTVoK1ZXeVpY?= =?utf-8?B?Mlh1ekdBK1JHY2Z5K3lvYlliWkpkU3RQT3dhN1dGYVBTclNORFZtSjM1UWJW?= =?utf-8?Q?UKp6y2U3TmueYJzgaZ66unq/+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd2ea551-6d8c-4089-7c16-08de168d561c X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB8443.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2025 01:49:02.7599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 09A+w1GaT6Ad9CMgxSeV2E8UJd4pwPGzS3JMWPelnEL4p8SbDC28BWlxqRv7BqIZ2KYtCPpUBpOldxKOPMN4mA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9038 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Thanks Thomas. Hi Luca: I just noticed the patch title was changed somehow when merging. Sorry for the confusion. On 2025/10/28 22:48, Luca Boccassi wrote: > On Tue, 28 Oct 2025 at 13:10, Thomas Monjalon wrote: >> >> 28/10/2025 13:13, Luca Boccassi: >>> On Tue, 28 Oct 2025 at 08:17, Rongwei Liu wrote: >>>> >>>> When aging is configured, there is a background thread >>>> which queries all the counters in the pool. >>>> >>>> Meantime, per queue flow insertion/deletion/update changes >>>> the counter pool too. It introduces a race condition between >>>> resetting counters's in_used and age_idx fields during flow deletion >>>> and reading them in the background thread. >>>> >>>> To resolve it, all key members of counter's struct >>>> are placed in a single uint32_t and they are accessed atomically. >>>> >>>> To avoid the occasional timestamp equalization with age_idx, >>>> query_gen_when_free is moved out of the union. The total memory >>>> size is kept the same. >>>> >>>> Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") >>>> Cc: michaelba@nvidia.com >>>> Cc: stable@dpdk.org >>>> Signed-off-by: Rongwei Liu >>> >>> Hi, >>> >>> I cannot seem to find a reference to this patch on the main branch? >>> Was it merged with a different commit? >> >> It seems Rongwei didn't reuse the title updated while merging in main: >> >> https://git.dpdk.org/dpdk/commit/?id=820ca7361bb >> >> Note the new title is more precise, please use it: >> net/mlx5: fix flow aging race condition > > Sounds good, thanks