From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 09769A0A0A
	for <public@inbox.dpdk.org>; Thu, 21 Jan 2021 17:33:44 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 00165140D25;
	Thu, 21 Jan 2021 17:33:43 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by mails.dpdk.org (Postfix) with ESMTP id C29E9140D04;
 Thu, 21 Jan 2021 17:33:40 +0100 (CET)
IronPort-SDR: wOznG/4j5xTKkozgWxeyDfPgVAWnw1uI/AvJCoYCmhGRkVGMMmwtkpbTCXqCnhwXoQunPAd0l7
 hSlYUydmbpgw==
X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="158476207"
X-IronPort-AV: E=Sophos;i="5.79,364,1602572400"; d="scan'208";a="158476207"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Jan 2021 08:33:39 -0800
IronPort-SDR: SjUGsU1j4+cB1/5SQceAW3DQgNU+kg6/sAUbwy/9HlbfxlICbxrpdWUEV8J1xWef3WXXFvgQXY
 nCRI6NxGjn2g==
X-IronPort-AV: E=Sophos;i="5.79,364,1602572400"; d="scan'208";a="385369414"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.196.87])
 ([10.213.196.87])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Jan 2021 08:33:38 -0800
To: Wei Huang <wei.huang@intel.com>, dev@dpdk.org, rosen.xu@intel.com,
 qi.z.zhang@intel.com
Cc: stable@dpdk.org, tianfei.zhang@intel.com
References: <1611209014-4031-1-git-send-email-wei.huang@intel.com>
 <1611209014-4031-4-git-send-email-wei.huang@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a8f465ea-b7e6-c676-8ba3-974da0810b44@intel.com>
Date: Thu, 21 Jan 2021 16:33:36 +0000
MIME-Version: 1.0
In-Reply-To: <1611209014-4031-4-git-send-email-wei.huang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE
 API for OpenStack Cyborg
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On 1/21/2021 6:03 AM, Wei Huang wrote:
> +int opae_init(int eal_init_result)
> +{
> +	int ret = 0;
> +
> +	if (!check_eal(0))
> +		return 0;
> +
> +	if (eal_init_result < 0) {
> +		if (rte_errno == EALREADY) {
> +			eal_inited = 1;
> +			opae_log_info("EAL already initialized\n");
> +		} else {
> +			opae_log_err("Cannot initialize EAL\n");
> +			ret = -1;
> +		}
> +	} else {
> +		eal_inited = 1;
> +		opae_log_info("Initialize EAL done\n");
> +	}
> +
> +	return ret;
> +}

Why an PMD API needs to know eal initialization status? This may be pointing a 
bad design, is it possible that most of the 'opae_' API code should go to the 
application?