From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id E549129C7;
 Tue,  3 Jan 2017 11:03:55 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 03 Jan 2017 02:03:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,451,1477983600"; d="scan'208";a="918380727"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.131])
 ([163.33.230.131])
 by orsmga003.jf.intel.com with ESMTP; 03 Jan 2017 02:03:53 -0800
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 thomas.monjalon@6wind.com
References: <1481881454-17382-1-git-send-email-olivier.matz@6wind.com>
Cc: stable@dpdk.org
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <a947027c-ae18-1d72-78bf-d26e9cddac50@intel.com>
Date: Tue, 3 Jan 2017 10:03:52 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <1481881454-17382-1-git-send-email-olivier.matz@6wind.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH 1/2] ethdev: fix name index in xstats Api
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 10:03:56 -0000

Been away, hence the somewhat late review..

On 16/12/2016 09:44, Olivier Matz wrote:
[..]
> Today, each 'id' returned by rte_eth_xstats_get() is equal to the index
> in the returned array, making this value useless. It also prevents a
> driver from having different indexes for names and value, like in the
> example below:

My original intention was to give free reign over what id numbers are 
used, but for reasons I've now forgotten the implementation ended up 
making everything sequential.

> CC: stable@dpdk.org
> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Remy Horton <remy.horton@intel.com>