From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Wojciech Drewek <wojciech.drewek@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Sergey Temerkhanov <sergey.temerkhanov@intel.com>,
Dan Nowlin <dan.nowlin@intel.com>,
Qiming Yang <qiming.yang@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH v1 02/12] net/ice/base: fix adding special words
Date: Fri, 5 Sep 2025 16:06:20 +0100 [thread overview]
Message-ID: <aLr8bOseRlg7Srkn@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <6e919683011310f00dcdb60ffbb66c8f721547c7.1756833701.git.anatoly.burakov@intel.com>
On Tue, Sep 02, 2025 at 06:26:52PM +0100, Anatoly Burakov wrote:
> From: Shaiq Wani <shaiq.wani@intel.com>
>
> The function ice_add_special_words() is meant to add special words (such
> as traffic direction) to the rule. The function that
> interprets/translates these additional words is ice_get_sw_fv_list().
>
> However, the ice_get_sw_fv_list() is called *before*
> ice_add_special_words(), so the "special" words weren't added at that
> point yet, hence they're not translated. This results in the driver
> ignoring whatever special words that were added. The fix is to call
> ice_get_sw_fv_list() *after* ice_add_special_words().
>
> Fixes: ed3066a3b1b0 ("net/ice/base: refactor DDP code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/ice/base/ice_switch.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-09-05 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1756833701.git.anatoly.burakov@intel.com>
2025-09-02 17:26 ` Anatoly Burakov
2025-09-05 15:06 ` Bruce Richardson [this message]
2025-09-02 17:26 ` [PATCH v1 03/12] net/ice/base: fix memory leak in HW profile handling Anatoly Burakov
2025-09-05 15:08 ` Bruce Richardson
2025-09-02 17:26 ` [PATCH v1 04/12] net/ice/base: fix memory leak in recipe handling Anatoly Burakov
2025-09-05 15:10 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLr8bOseRlg7Srkn@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dan.nowlin@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=sergey.temerkhanov@intel.com \
--cc=stable@dpdk.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).