* [PATCH] net/ice: revert count drop-all filter in Rx stats
@ 2025-10-14 5:43 Shaiq Wani
2025-10-14 8:41 ` Burakov, Anatoly
0 siblings, 1 reply; 3+ messages in thread
From: Shaiq Wani @ 2025-10-14 5:43 UTC (permalink / raw)
To: dev, bruce.richardson, aman.deep.singh; +Cc: stable
This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa
This patch caused testpmd to count packets not destined for our MAC
even when promiscuous mode is off.This behaviour is inconsistent with
other drivers and leads to incorrect Rx statistics.
Fixes: af05f9e ("net/ice: count drop-all filter in Rx stats")
Cc: stable@dpdk.org
Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
drivers/net/intel/ice/ice_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index a9a49cd924..9d0fbd2a5a 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -6353,13 +6353,12 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
pf->main_vsi->eth_stats.rx_multicast +
- ns->eth.rx_unknown_protocol +
pf->main_vsi->eth_stats.rx_broadcast -
pf->main_vsi->eth_stats.rx_discards;
stats->opackets = ns->eth.tx_unicast +
ns->eth.tx_multicast +
ns->eth.tx_broadcast;
- stats->ibytes = ns->eth.rx_bytes;
+ stats->ibytes = pf->main_vsi->eth_stats.rx_bytes;
stats->obytes = ns->eth.tx_bytes;
stats->oerrors = ns->eth.tx_errors +
pf->main_vsi->eth_stats.tx_errors;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/ice: revert count drop-all filter in Rx stats
2025-10-14 5:43 [PATCH] net/ice: revert count drop-all filter in Rx stats Shaiq Wani
@ 2025-10-14 8:41 ` Burakov, Anatoly
2025-10-14 14:07 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Burakov, Anatoly @ 2025-10-14 8:41 UTC (permalink / raw)
To: Shaiq Wani, dev, bruce.richardson, aman.deep.singh; +Cc: stable
On 10/14/2025 7:43 AM, Shaiq Wani wrote:
> This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa
>
> This patch caused testpmd to count packets not destined for our MAC
> even when promiscuous mode is off.This behaviour is inconsistent with
> other drivers and leads to incorrect Rx statistics.
>
> Fixes: af05f9e ("net/ice: count drop-all filter in Rx stats")
> Cc: stable@dpdk.org
IIRC this change is still in next-net so no need for CC stable
>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
> index a9a49cd924..9d0fbd2a5a 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -6353,13 +6353,12 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>
> stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
> pf->main_vsi->eth_stats.rx_multicast +
> - ns->eth.rx_unknown_protocol +
> pf->main_vsi->eth_stats.rx_broadcast -
> pf->main_vsi->eth_stats.rx_discards;
> stats->opackets = ns->eth.tx_unicast +
> ns->eth.tx_multicast +
> ns->eth.tx_broadcast;
> - stats->ibytes = ns->eth.rx_bytes;
> + stats->ibytes = pf->main_vsi->eth_stats.rx_bytes;
> stats->obytes = ns->eth.tx_bytes;
> stats->oerrors = ns->eth.tx_errors +
> pf->main_vsi->eth_stats.tx_errors;
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/ice: revert count drop-all filter in Rx stats
2025-10-14 8:41 ` Burakov, Anatoly
@ 2025-10-14 14:07 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2025-10-14 14:07 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: Shaiq Wani, dev, aman.deep.singh, stable
On Tue, Oct 14, 2025 at 10:41:38AM +0200, Burakov, Anatoly wrote:
> On 10/14/2025 7:43 AM, Shaiq Wani wrote:
> > This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa
> >
> > This patch caused testpmd to count packets not destined for our MAC
> > even when promiscuous mode is off.This behaviour is inconsistent with
> > other drivers and leads to incorrect Rx statistics.
> >
> > Fixes: af05f9e ("net/ice: count drop-all filter in Rx stats")
> > Cc: stable@dpdk.org
>
> IIRC this change is still in next-net so no need for CC stable
>
Well, it's in main too, I think, but again only for this release, so
dropping CC of stable on apply.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net intel.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-14 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-14 5:43 [PATCH] net/ice: revert count drop-all filter in Rx stats Shaiq Wani
2025-10-14 8:41 ` Burakov, Anatoly
2025-10-14 14:07 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).