Re: [PATCH 1/6] net/intel: fix Rx vector capability detection

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Oct 14, 2025 at 08:45:12AM +0000, Ciara Loftus wrote:
> The common function for detecting whether an rxq could use a vector
> rx path would automatically disqualify rx queues that had the
> timestamp offload enabled. This was incorrect behaviour because the
> iavf driver which uses this common function supports timestamp offload
> on its vector paths. Fix this by removing the conditional check for
> timestamp offload.
> 
> Fixes: 9eb60580d155 ("net/intel: extract common Rx vector criteria")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  drivers/net/intel/common/rx.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/intel/common/rx.h b/drivers/net/intel/common/rx.h
> index 741808f573..d3e4492ff1 100644
> --- a/drivers/net/intel/common/rx.h
> +++ b/drivers/net/intel/common/rx.h
> @@ -235,9 +235,8 @@ ci_rxq_vec_capable(uint16_t nb_desc, uint16_t rx_free_thresh, uint64_t offloads)
>  			(nb_desc % rx_free_thresh) != 0)
>  		return false;
>  
> -	/* no driver supports timestamping or buffer split on vector path */
> -	if ((offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) ||
> -			(offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT))
> +	/* no driver supports buffer split on vector path */
> +	if (offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT)
>  		return false;
>  
>  	return true;

Given that we check all offload flags later when doing final path
selection, can we drop the flags check here completely? Just have this
funciont check on the non-feature-related conditions, such as ring size
etc.

/Bruce