From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Junfeng Guo <junfengg@nvidia.com>,
Qi Zhang <qi.z.zhang@intel.com>, <vladimir.medvedkin@intel.com>,
<stable@dpdk.org>
Subject: Re: [PATCH v3 1/2] net/ice: remove indirection for FDIR filters
Date: Mon, 13 Oct 2025 13:09:04 +0100 [thread overview]
Message-ID: <aOzr4DMhgD3xAJa3@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <2f0e588a6f838f4a641c1a23b22b9dfff6912264.1760101992.git.anatoly.burakov@intel.com>
On Fri, Oct 10, 2025 at 02:13:19PM +0100, Anatoly Burakov wrote:
> Currently, when filters are created for FDIR, they are allocated
> dynamically using `ice_malloc()`. Not only this is inconsistent with hash
> filter code paths (hash uses embedded structures), this is also creating
> unnecessary indirection and complexity, and creates a memory leak where,
> if something fails during raw pattern parse, the profile memory isn't
> deallocated.
>
> Since there is no actual reason for why FDIR filter profile must use
> indirection, instead of fixing the memory leak just avoid it altogether
> by making the filter profile an embedded struct. When parsing begins, the
> entire scratch filter structure is zeroed out anyway, so there is no need
> to add any additional zero-initialization code.
>
> Fixes: 25be39cc1760 ("net/ice: enable protocol agnostic flow offloading in FDIR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Series-
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel
prev parent reply other threads:[~2025-10-13 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 11:37 [PATCH v1 1/1] net/ice: fix memory leak in raw pattern parse Anatoly Burakov
2025-10-07 12:42 ` [PATCH v2 1/2] net/ice: remove indirection for FDIR filters Anatoly Burakov
2025-10-07 12:42 ` [PATCH v2 2/2] net/ice: fix memory leak in raw pattern parse Anatoly Burakov
2025-10-07 15:22 ` Burakov, Anatoly
2025-10-10 13:13 ` [PATCH v3 1/2] net/ice: remove indirection for FDIR filters Anatoly Burakov
2025-10-10 13:13 ` [PATCH v3 2/2] net/ice: fix memory leak in raw pattern parse Anatoly Burakov
2025-10-13 12:09 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOzr4DMhgD3xAJa3@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=junfengg@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).