From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Reshma Pattan <reshma.pattan@intel.com>
Subject: Re: [PATCH v4 1/8] dumpcap: handle primary process exit
Date: Thu, 23 Oct 2025 17:13:53 +0100 [thread overview]
Message-ID: <aPpUQb-HquTd4IBx@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251023154748.38535-2-stephen@networkplumber.org>
On Thu, Oct 23, 2025 at 08:46:22AM -0700, Stephen Hemminger wrote:
> If primary process exits, then it is not possible (or needed)
> to cleanup resources. Instead just exit after closing the
> capture file.
>
> Bugzilla ID: 1760
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Makes sense.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> app/dumpcap/main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index e5ba36350b..3621c0ebe3 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -1059,6 +1059,10 @@ int main(int argc, char **argv)
> else
> pcap_dump_close(out.dumper);
>
> + /* If primary has exited, do not try and communicate with it */
> + if (!rte_eal_primary_proc_alive(NULL))
> + return 0;
> +
> cleanup_pdump_resources();
>
> rte_ring_free(r);
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-10-23 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <250811213632.16023-1-stephen@networkplumber.org>
[not found] ` <20251019165728.164929-1-stephen@networkplumber.org>
2025-10-19 16:56 ` [PATCH v3 " Stephen Hemminger
2025-10-19 16:56 ` [PATCH v3 2/8] pdump: " Stephen Hemminger
[not found] ` <20251023154748.38535-1-stephen@networkplumber.org>
2025-10-23 15:46 ` [PATCH v4 1/8] dumpcap: " Stephen Hemminger
2025-10-23 16:13 ` Bruce Richardson [this message]
2025-10-23 15:46 ` [PATCH v4 2/8] pdump: " Stephen Hemminger
2025-10-23 16:14 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPpUQb-HquTd4IBx@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).