From: Bruce Richardson <bruce.richardson@intel.com>
To: Anurag Mandal <anurag.mandal@intel.com>
Cc: <dev@dpdk.org>, <anatoly.burakov@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH v3] net/ice: add source prune configuration API
Date: Wed, 5 Nov 2025 09:13:42 +0000 [thread overview]
Message-ID: <aQsVRmR5OVpcUxDL@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251102011919.68783-1-anurag.mandal@intel.com>
On Sun, Nov 02, 2025 at 01:19:19AM +0000, Anurag Mandal wrote:
> Source prune is disabled by default to support
> VRRP advertisement packets in a vsi of ice PF.
> There is no way to enable source prune itself.
>
> This patch adds a PMD specific API to enable/disable
> source prune for all PF ports or for an individual PF port.
>
> Tested the following with VRRP advertisement packets in a
> vsi of ice PF:
> 1. Source prune default mode.
> 2. Enable source prune for an individual PF port.
> 3. Disable source prune for an individual PF port.
> 4. Enable source prune for all PF ports.
> 5. Disable source prune for all PF ports.
>
> Fixes: 6f866eb93e79 ("net/ice: fix dropped packets when using VRRP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
> ---
> drivers/net/intel/ice/ice_ethdev.c | 72 +++++++++++++++++++++++
> drivers/net/intel/ice/ice_ethdev.h | 16 ++++++
> drivers/net/intel/ice/ice_testpmd.c | 88 +++++++++++++++++++++++++++++
> 3 files changed, 176 insertions(+)
>
Rather than having a new private API for this, would a device arg (devarg)
passed on the commandline be a better choice? Private APIs are not really
nice in DPDK, and for this feature I can't see it being something that
needs enabling/disabling at runtime by apps. Just having it as a device
setting, set at init should probably work.
/Bruce
next prev parent reply other threads:[~2025-11-05 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 10:46 [PATCH] " Anurag Mandal
2025-11-01 18:29 ` [PATCH v2] " Anurag Mandal
2025-11-02 1:19 ` [PATCH v3] " Anurag Mandal
2025-11-05 9:13 ` Bruce Richardson [this message]
2025-11-05 18:30 ` [PATCH v4] net/ice: add option to enable source prune Anurag Mandal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQsVRmR5OVpcUxDL@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=anurag.mandal@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).