From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6405A04B5 for ; Thu, 29 Oct 2020 12:23:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8EDCCA2E; Thu, 29 Oct 2020 12:23:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 3AFE3CA2E for ; Thu, 29 Oct 2020 12:23:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603970628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/GCZV7/wQg9HiiyXhegnYivWsPLu8CDLUfq4TUnCl4=; b=gboZIhwIpBk+sizblCWJecV7DddtuaccnVYPCn48vR58YDYDOvRgRjQlo5w1MsDAS+OZbJ PlIOTC9PMQO4TOFGW88FDcOtKNzDfoIxg3zS5UZ0K+nTEXCDNRR4pNxJf1Ns2vZGwgIMzd AT5TA8NMgoRJHHLYK51/9YqTjCGxkoA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-mu9SLfDDNSeXAfJGRymbAw-1; Thu, 29 Oct 2020 07:23:47 -0400 X-MC-Unique: mu9SLfDDNSeXAfJGRymbAw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D5BA6D581; Thu, 29 Oct 2020 11:23:45 +0000 (UTC) Received: from [10.36.114.240] (ovpn-114-240.ams2.redhat.com [10.36.114.240]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E5001974D; Thu, 29 Oct 2020 11:23:40 +0000 (UTC) To: Ali Alnubani , NBU-Contact-Thomas Monjalon Cc: Bruce Richardson , David Marchand , dpdk stable References: <20201006120738.29125-1-ktraynor@redhat.com> From: Kevin Traynor Message-ID: Date: Thu, 29 Oct 2020 11:23:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] patch 'eal: remove useless makefiles' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 25/10/2020 11:53, Ali Alnubani wrote: > Hi, > Hi Ali, thanks for reporting. >> -----Original Message----- >> From: stable On Behalf Of Kevin Traynor >> Sent: Tuesday, October 6, 2020 3:08 PM >> To: NBU-Contact-Thomas Monjalon >> Cc: Bruce Richardson ; David Marchand >> ; dpdk stable >> Subject: [dpdk-stable] patch 'eal: remove useless makefiles' has been >> queued to LTS release 18.11.11 >> >> Hi, >> >> FYI, your patch has been queued to LTS release 18.11.11 >> > >> --- >> From 4a2be43591df63d55d9665389ff41fcba19db85a Mon Sep 17 00:00:00 >> 2001 >> From: Thomas Monjalon >> Date: Fri, 27 Mar 2020 02:15:33 +0100 >> Subject: [PATCH] eal: remove useless makefiles >> >> [ upstream commit 4448a202b61e1a373c647aa4638093d092b3f5de ] >> >> When moving files to the directory kernel/, the file BSDmakefile.meson was >> left in eal/. >> >> Also the intermediate makefiles in linuxapp/ and bsdapp/ became useless. >> >> Fixes: acaa9ee991b5 ("move kernel modules directories") >> >> Signed-off-by: Thomas Monjalon >> Acked-by: Bruce Richardson >> Acked-by: David Marchand >> > > > Backporting this patch to 18.11 started causing the following build failure with older gcc versions on RHEL and CentOS with make: It compiled locally for me on F31 and F32, but later I saw multiple build failures like this on OBS even for F31 and F32 with newer gcc. I looked last Friday and the backport looked ok and it wasn't obvious to me what the issue is. I'm sure with time and/or the right eyes it could be fixed but as it is just to remove a few unused make files, I don't think it's worth the effort. Unless someone thinks differently, I will revert the patch in 18.11 branch by tomorrow. thanks, Kevin. > """ > ... > SYMLINK-FILE include/rte_pci_dev_features.h > CC eal_memory.o > CC eal_thread.o > SYMLINK-FILE include/rte_malloc.h > CC eal_log.o > CC eal_vfio.o > SYMLINK-FILE include/rte_keepalive.h > lib/librte_eal/linuxapp/eal/eal_cpuflags.c:19:26: fatal error: rte_cpuflags.h: No such file or directory > #include > ^ > compilation terminated. > SYMLINK-FILE include/rte_time.h > lib/librte_eal/linuxapp/eal/eal_thread.c:16:24: fatal error: rte_atomic.h: No such file or directory > #include > ^ > compilation terminated. > In file included from x86_64-native-linuxapp-gcc/include/rte_eal_memconfig.h:12:0, > from lib/librte_eal/linuxapp/eal/eal.c:35: > x86_64-native-linuxapp-gcc/include/rte_malloc_heap.h:10:26: fatal error: rte_spinlock.h: No such file or directory > #include > ^ > compilation terminated. > ... > """ > > gcc version: 4.8.5 > > Regards, > Ali >