From: "Min Hu (Connor)" <humin29@huawei.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
dpdk stable <stable@dpdk.org>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Lijun Ou <oulijun@huawei.com>
Subject: Re: [dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x
Date: Tue, 1 Jun 2021 17:19:30 +0800 [thread overview]
Message-ID: <abcab811-1936-4507-c8fd-9aea10243fb8@huawei.com> (raw)
In-Reply-To: <CAATJJ0KsGPVdWE61doEkiZOXDZNqba7pABwWpjiCZs6nD+eFiA@mail.gmail.com>
Hi，Christian,
Agreed, this patch can be abandoned in 19.11x， It can backport
to 20.11.x.
在 2021/6/1 16:05, Christian Ehrhardt 写道:
> Hi,
> this was targeted for dpdk stable releases.
>
> commit b6579e3db794be36637a66e009199a1e7451e995
> Author: Huisong Li <lihuisong@huawei.com>
> Date: Tue Mar 23 21:45:51 2021 +0800
>
> net/hns3: fix reporting undefined speed
>
> It introduced
>
> [ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:
> In function 'hns3_dev_link_update':
> [ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:2618:26:
> error: 'ETH_SPEED_NUM_UNKNOWN' undeclared (first use in this function)
> [ 403s] new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
> [ 403s] ^
>
> But that requires this change from 20.11:
>
> commit 810b17d116f03783843d23ac900a3794675f6616
> Author: Thomas Monjalon <thomas@monjalon.net>
> Date: Tue Aug 11 11:52:20 2020 +0300
>
> ethdev: allow unknown link speed
>
> I'm unsure if introducing ETH_SPEED_NUM_UNKNOWN in 19.11 might break
> other bits not aware of it so for now I have removed that formerly
> queued patch from 19.11.9.
>
> If you want it applied to 19.11.9 or later please have a look and
> consider providing a backport for it - or alternatively if you think it
> is not important for 19.11.x let me know about that.
>
prev parent reply other threads:[~2021-06-01 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:05 Christian Ehrhardt
2021-06-01 9:19 ` Min Hu (Connor) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abcab811-1936-4507-c8fd-9aea10243fb8@huawei.com \
--to=humin29@huawei.com \
--cc=christian.ehrhardt@canonical.com \
--cc=oulijun@huawei.com \
--cc=stable@dpdk.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).