From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 946A242417 for ; Thu, 19 Jan 2023 11:20:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A85442D1C; Thu, 19 Jan 2023 11:20:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EEADF4068E for ; Thu, 19 Jan 2023 11:20:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674123620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JD7EcdrM6iMZITRA8oF6ksrCrBsj0Om+SqaJH59XWg8=; b=Yn9F0T3b75OgKyzHQYkfqLsRXR73bQz1l+uPlJhTR70kAMvDBUyr2cuKb3K7P1zA6rNMi1 YtDCN4CxhZ6D6Y/rDUCKTkcHvWgSLbkGVKievgjVG3pesCKuAAPtbeCfBA5XLcvOCta6YK P7oT55rUK+ptegTBgw1yEDsrsZofrJk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-BWNWUglSOZyuJUYpuBUQCQ-1; Thu, 19 Jan 2023 05:20:15 -0500 X-MC-Unique: BWNWUglSOZyuJUYpuBUQCQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 389D9811E6E; Thu, 19 Jan 2023 10:20:14 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45923140EBF4; Thu, 19 Jan 2023 10:20:13 +0000 (UTC) Message-ID: Date: Thu, 19 Jan 2023 11:20:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] vdpa/ifc: fix argument compatibility check To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, stable@dpdk.org References: <1669879940-60846-1-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1669879940-60846-1-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 12/1/22 08:32, Andy Pei wrote: > "sw_fallback_lm=0" means driver does not provide live migration assistance. > so hardware assistance is needed to support live migration. > However registers for live migration in BAR4 are not implemented. > In the case, we just return error after display some logs. > > Fixes: 4c3f55cc23ea ("net/ifc: add LM mode parameter") > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 49d68ad..9468f66 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1746,6 +1746,11 @@ struct rte_vdpa_dev_info dev_info[] = { > goto error; > } > internal->sw_lm = sw_fallback_lm; > + if (!internal->sw_lm && !internal->hw.lm_cfg) { > + DRV_LOG(ERR, "Device %s does not support HW assist live migration, please enable sw-live-migration!", > + pci_dev->name); > + goto error; > + } > > pthread_mutex_lock(&internal_list_lock); > TAILQ_INSERT_TAIL(&internal_list, list, next); Reviewed-by: Maxime Coquelin Thanks, Maxime