From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70CE7A00BE for ; Tue, 15 Mar 2022 14:23:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 489A24014F; Tue, 15 Mar 2022 14:23:44 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 0C07A4014F for ; Tue, 15 Mar 2022 14:23:43 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id u10so28973314wra.9 for ; Tue, 15 Mar 2022 06:23:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=n4jdem6PJKpYt+BOVnwf52H716AmP3FIBV6WOnoVHs4=; b=U5agDe5v2cPP5BQPYSLRuetmOiDnqDJ2x1lRCI2h2bG2KidquYrLhlaW+5y4tNK5qu DU771Ck4Fl0tooccnxsMjnqfV1ysGwCie75yDC0khMbFUzdsYc8XbfXbBcLgyGYxrNsm FAfCfXqI4mZzAYV9x6ME9utoWmv6AkhY2wEB7hCloML1z/S3Nm2CQmP0iMQ83B50cUOE ZYymUtj8fps8RRl2j0dJMiDWYozE3lQ8OLSo69CoGsKwFjxYzYCXu7Iuvxz+p7BGK77Y bHw9cpk9KGA3105RD5MQZzcfDJ9f/4suSLWIsLk9fzM186K6mLdC6GXd8Tn5vL7tJ1wi hIHw== X-Gm-Message-State: AOAM532zqA0BAtqEaZALun4eSv7qf6dPV35Ho+LUDhEjXNvTmUYi4h3H G4uebW6wQ8LtdGsIU9OENPA= X-Google-Smtp-Source: ABdhPJw/pzt8GpD8ZLTjAMOxtOf8B78zl4Tm9cuwd32q834vATep+0uKnojqk2/uAX0l3N5Zd7AVNQ== X-Received: by 2002:a5d:47ac:0:b0:1fc:f09b:c258 with SMTP id 12-20020a5d47ac000000b001fcf09bc258mr20957709wrb.618.1647350622641; Tue, 15 Mar 2022 06:23:42 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id g1-20020a1c4e01000000b003899c8053e1sm3196213wmh.41.2022.03.15.06.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 06:23:42 -0700 (PDT) Message-ID: Subject: Re: [EXT] Re: [PATCH 20.11] net/octeontx2: fix flow MCAM priority management From: Luca Boccassi To: Satheesh Paul , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda Cc: "stable@dpdk.org" Date: Tue, 15 Mar 2022 13:23:41 +0000 In-Reply-To: References: <20220315041620.2118828-1-psatheesh@marvell.com> <17d5a2164e217f962faf6d36619be8877d64ae53.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 2022-03-15 at 12:46 +0000, Satheesh Paul wrote: > Hi, >=20 > Yes, the issue is specific to 20.11. On main branch this part of the code= has been fully rewritten. (1f66919817 common/cnxk: improve MCAM entries ma= nagement). > This is now backported with this patch to address the issue. >=20 > Thanks, > Satheesh.=20 Ok, please get at least one more person to review and ack it then - I do not know nearly enough about this PMD to do a meaningful review. > -----Original Message----- > From: Luca Boccassi =20 > Sent: 15 March 2022 05:14 PM > To: Satheesh Paul ; Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram ; Kiran = Kumar Kokkilagadda > Cc: stable@dpdk.org > Subject: [EXT] Re: [PATCH 20.11] net/octeontx2: fix flow MCAM priority ma= nagement >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Tue, 2022-03-15 at 09:46 +0530, psatheesh@marvell.com wrote: > > From: Satheesh Paul > >=20 > > This patch fixes issues in rearranging the MCAM entries when user is= =20 > > creating flows with priority levels. > > The MCAM preallocation scheme and the free entry cache are removed.=20 > > For every flow created, an MCAM allocation request is made to the=20 > > kernel. Each priority level has a list of MCAM entries. For every flow= =20 > > rule added, the MCAM entry obtained from kernel is checked if it is at= =20 > > the correct user specified priority. If not, the existing rules are=20 > > moved across MCAM entries so that the user specified priority is=20 > > maintained. > >=20 > > Fixes: 29a2017c70 ("net/octeontx2: add flow mbox utility functions") > >=20 > > Signed-off-by: Satheesh Paul > > --- > > =C2=A0drivers/net/octeontx2/otx2_flow.c | 145 +---- > > =C2=A0drivers/net/octeontx2/otx2_flow.h | 33 +- > > =C2=A0drivers/net/octeontx2/otx2_flow_utils.c | 717=20 > > ++++++++++++------------ > > =C2=A03 files changed, 405 insertions(+), 490 deletions(-) >=20 > Hi, >=20 > I don't see this patch on main - is it a bug specific to 20.11? >=20 > -- > Kind regards, > Luca Boccassi