* Re: [PATCH v2] net/vmxnet3: fix return code in initializing
2023-06-02 16:44 ` [PATCH v2] net/vmxnet3: fix return code in initializing Kaijun Zeng
@ 2023-06-06 9:08 ` Ferruh Yigit
2023-06-06 15:36 ` Stephen Hemminger
2023-06-07 17:57 ` [PATCH v3] " Kaijun Zeng
2 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2023-06-06 9:08 UTC (permalink / raw)
To: Kaijun Zeng, dev; +Cc: stable, Jochen Behrens, Bruce Richardson
On 6/2/2023 5:44 PM, Kaijun Zeng wrote:
> Improve error handling
>
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaijun Zeng <corezeng@gmail.com>
> ---
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index 73ec1e4727..e615d40d09 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -1311,7 +1311,17 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)
> for (j = 0; j < VMXNET3_RX_CMDRING_SIZE; j++) {
> /* Passing 0 as alloc_num will allocate full ring */
> ret = vmxnet3_post_rx_bufs(rxq, j);
> - if (ret <= 0) {
> +
> + /* Zero number of descriptors in the configuration of the RX queue */
> + if (ret == 0) {
> + PMD_INIT_LOG(ERR,
> + "ERROR: Zero descriptor requirement in Rx queue: %d,"
> + "buffers ring: %d\n",
> + i, j);
> + return -EINVAL;
> + }
> + /* Return the errno */
> + if (ret < 0) {
> PMD_INIT_LOG(ERR,
> "ERROR: Posting Rxq: %d buffers ring: %d",
> i, j);
Looks good to me, @Jochen any objection?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] net/vmxnet3: fix return code in initializing
2023-06-02 16:44 ` [PATCH v2] net/vmxnet3: fix return code in initializing Kaijun Zeng
2023-06-06 9:08 ` Ferruh Yigit
@ 2023-06-06 15:36 ` Stephen Hemminger
2023-06-07 15:49 ` Ferruh Yigit
2023-06-07 17:57 ` [PATCH v3] " Kaijun Zeng
2 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2023-06-06 15:36 UTC (permalink / raw)
To: Kaijun Zeng; +Cc: dev, Ferruh Yigit, stable, Jochen Behrens, Bruce Richardson
On Fri, 2 Jun 2023 12:44:38 -0400
Kaijun Zeng <corezeng@gmail.com> wrote:
> + PMD_INIT_LOG(ERR,
> + "ERROR: Zero descriptor requirement in Rx queue: %d,"
> + "buffers ring: %d\n",
> + i, j);
Please don't split messages across source lines, it makes harder for developers
to use tools to scan source for message.
Often, when message is long, it means that there is redundant information or poor wording.
For example, in your message "ERROR:" is redundant.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] net/vmxnet3: fix return code in initializing
2023-06-06 15:36 ` Stephen Hemminger
@ 2023-06-07 15:49 ` Ferruh Yigit
0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2023-06-07 15:49 UTC (permalink / raw)
To: Stephen Hemminger, Kaijun Zeng
Cc: dev, stable, Jochen Behrens, Bruce Richardson
On 6/6/2023 4:36 PM, Stephen Hemminger wrote:
> On Fri, 2 Jun 2023 12:44:38 -0400
> Kaijun Zeng <corezeng@gmail.com> wrote:
>
>> + PMD_INIT_LOG(ERR,
>> + "ERROR: Zero descriptor requirement in Rx queue: %d,"
>> + "buffers ring: %d\n",
>> + i, j);
>
> Please don't split messages across source lines, it makes harder for developers
> to use tools to scan source for message.
>
> Often, when message is long, it means that there is redundant information or poor wording.
> For example, in your message "ERROR:" is redundant.
>
Agree that 'ERROR:' is redundant, and +1 to not split log message.
Kaijun,
Would you mind sending a new version with above changes?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] net/vmxnet3: fix return code in initializing
2023-06-02 16:44 ` [PATCH v2] net/vmxnet3: fix return code in initializing Kaijun Zeng
2023-06-06 9:08 ` Ferruh Yigit
2023-06-06 15:36 ` Stephen Hemminger
@ 2023-06-07 17:57 ` Kaijun Zeng
2023-06-09 18:08 ` Ferruh Yigit
2 siblings, 1 reply; 7+ messages in thread
From: Kaijun Zeng @ 2023-06-07 17:57 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Kaijun Zeng, stable, Jochen Behrens, Bruce Richardson
Improve error handling
Bugzilla ID: 1239
Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation")
Cc: stable@dpdk.org
Signed-off-by: Kaijun Zeng <corezeng@gmail.com>
---
v3:
* Improve coding style
v2:
* Improve error handling
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index a875ffec07..e6e36dca93 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -1311,11 +1311,18 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)
for (j = 0; j < VMXNET3_RX_CMDRING_SIZE; j++) {
/* Passing 0 as alloc_num will allocate full ring */
ret = vmxnet3_post_rx_bufs(rxq, j);
- if (ret <= 0) {
+
+ /* Zero number of descriptors in the configuration of the RX queue */
+ if (ret == 0) {
PMD_INIT_LOG(ERR,
- "ERROR: Posting Rxq: %d buffers ring: %d",
- i, j);
- return -ret;
+ "Invalid configuration in Rx queue: %d, buffers ring: %d\n",
+ i, j);
+ return -EINVAL;
+ }
+ /* Return the error number */
+ if (ret < 0) {
+ PMD_INIT_LOG(ERR, "Posting Rxq: %d buffers ring: %d", i, j);
+ return ret;
}
/*
* Updating device with the index:next2fill to fill the
--
2.30.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] net/vmxnet3: fix return code in initializing
2023-06-07 17:57 ` [PATCH v3] " Kaijun Zeng
@ 2023-06-09 18:08 ` Ferruh Yigit
0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2023-06-09 18:08 UTC (permalink / raw)
To: Kaijun Zeng, dev; +Cc: stable, Jochen Behrens, Bruce Richardson
On 6/7/2023 6:57 PM, Kaijun Zeng wrote:
> Improve error handling
>
> Bugzilla ID: 1239
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaijun Zeng <corezeng@gmail.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread