patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] ethdev: fix setting of MAC address
@ 2017-12-14 17:15 Olivier Matz
  2017-12-18 10:35 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
  2018-01-03 13:34 ` [dpdk-stable] [PATCH v2] net/i40e: fix setting of MAC address on i40evf Olivier Matz
  0 siblings, 2 replies; 15+ messages in thread
From: Olivier Matz @ 2017-12-14 17:15 UTC (permalink / raw)
  To: dev, Thomas Monjalon; +Cc: Laurent Hardy, stable

From: Laurent Hardy <laurent.hardy@6wind.com>

When a new mac address is set, it is saved in dev->data->mac_addrs
before the ethdev handler is called.

First, it is inconsistent with the other ethdev functions
rte_eth_dev_mac_addr_remove() and rte_eth_dev_mac_addr_add().

Moreover, it prevents the drivers from wrongly comparing the old address
and the new one, like it's done in i40evf driver:

	if (is_same_ether_addr(mac_addr, dev->data->mac_addrs))
		return;

Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF")
Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier")
Cc: stable@dpdk.org

Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
---
 lib/librte_ether/rte_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 4f492e3db..297c02a54 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2643,11 +2643,11 @@ rte_eth_dev_default_mac_addr_set(uint16_t port_id, struct ether_addr *addr)
 	dev = &rte_eth_devices[port_id];
 	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_set, -ENOTSUP);
 
+	(*dev->dev_ops->mac_addr_set)(dev, addr);
+
 	/* Update default address in NIC data structure */
 	ether_addr_copy(addr, &dev->data->mac_addrs[0]);
 
-	(*dev->dev_ops->mac_addr_set)(dev, addr);
-
 	return 0;
 }
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2018-01-08 14:23 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 17:15 [dpdk-stable] [PATCH] ethdev: fix setting of MAC address Olivier Matz
2017-12-18 10:35 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2017-12-18 10:53   ` Igor Ryzhov
2017-12-18 11:38     ` Andrew Rybchenko
2017-12-19  9:29       ` Olivier MATZ
2017-12-19  9:47         ` Andrew Rybchenko
2017-12-20 10:00           ` Andrew Rybchenko
2018-01-03 13:43             ` Olivier Matz
2018-01-03 13:54               ` Olivier Matz
2018-01-03 14:12                 ` Andrew Rybchenko
2018-01-08 11:59                   ` Ferruh Yigit
2018-01-08 14:23                     ` Olivier Matz
2018-01-03 13:34 ` [dpdk-stable] [PATCH v2] net/i40e: fix setting of MAC address on i40evf Olivier Matz
2018-01-04  7:39   ` Xing, Beilei
2018-01-08  6:43     ` [dpdk-stable] [dpdk-dev] " Zhang, Helin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).