patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Maayan Kashani <mkashani@nvidia.com>, dev@dpdk.org
Cc: dsosnowski@nvidia.com, rasland@nvidia.com, stable@dpdk.org,
	Ori Kam <orika@nvidia.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Bing Zhao <bingz@nvidia.com>
Subject: Re: [PATCH] app/testpmd: fix parsing for connection tracking item
Date: Wed, 12 Jun 2024 17:35:22 +0100	[thread overview]
Message-ID: <ae9cce66-d303-44f0-8d96-41f36669867b@amd.com> (raw)
In-Reply-To: <20240602102328.196672-1-mkashani@nvidia.com>

On 6/2/2024 11:23 AM, Maayan Kashani wrote:
> In command line translation there were missing fields for
> connection tracking item, as a result this item was not parsed
> and was missing from the items list received from test-pmd.
> 
> Fixes: 4d07cbefe3ba ("app/testpmd: add commands for conntrack")
> Cc: stable@dpdk.org
> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
>

Hi Maayan,

I can't really trace why .priv and 'parse_vc' is required, can you
please help understanding by providing more data?

What was the old testpmd command and what was old behavior with that
command, why it was wrong?
What is the new behavior and why this update was needed, how new code
solved the issue?

testpmd flow command is still somewhat cryptic to me, and without
running code and debugging it is very hard for me to detect the missing
parts.


> ---
>  app/test-pmd/cmdline_flow.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 60ee9337cf..1f9d5ebd05 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -5797,9 +5797,12 @@ static const struct token token_list[] = {
>  	[ITEM_CONNTRACK] = {
>  		.name = "conntrack",
>  		.help = "conntrack state",
> +		.priv = PRIV_ITEM(CONNTRACK,
> +				  sizeof(struct rte_flow_item_conntrack)),
>  		.next = NEXT(NEXT_ENTRY(ITEM_NEXT), NEXT_ENTRY(COMMON_UNSIGNED),
>  			     item_param),
>  		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_conntrack, flags)),
> +		.call = parse_vc,
>  	},
>  	[ITEM_PORT_REPRESENTOR] = {
>  		.name = "port_representor",


  reply	other threads:[~2024-06-12 16:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02 10:23 Maayan Kashani
2024-06-12 16:35 ` Ferruh Yigit [this message]
2024-06-17 14:14   ` Maayan Kashani
2024-07-05 11:29 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae9cce66-d303-44f0-8d96-41f36669867b@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=aman.deep.singh@intel.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=mkashani@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).