From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92CD0A0C4B for ; Thu, 11 Nov 2021 18:21:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A4C741143; Thu, 11 Nov 2021 18:21:21 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EFB1C40E03; Thu, 11 Nov 2021 18:21:18 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="231694695" X-IronPort-AV: E=Sophos;i="5.87,226,1631602800"; d="scan'208";a="231694695" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 09:21:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,226,1631602800"; d="scan'208";a="583470045" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2021 09:21:17 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 11 Nov 2021 09:21:16 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 11 Nov 2021 09:21:16 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 11 Nov 2021 09:21:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eM3GyTn4zSXbYVUzF3ErVsoqV4WaC07RSOu6f+BsXBq1vheJD0TmE4f+to4dKLc/81cO5vtU4Et4TEAcGd+LXqQumzMw9ndmz3gepN0x77Ojvpf7ooxVwr+xeZ+i7mjU+Z7X/hZQDzy2pUeVJOdu0PEHODdH6dP7XWHh1r13SqUW8K3ah17UlNjXc7CEBfe4b7MevpLjvfEoxDIgJYhbRPCqoeXHWk/BJergQmr81ovEtLZzxMyoLL1nlC/hWCQ+hU+cCf4MvxKrsHbXRiJzrvGloBFE+rZQGxqQSitXdcslKE3zEK0S0xNu1fhLCjdB0TjXU84XNeqiLz6Vrfx6OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YN1kUGzVaZzBDRHZWUAwx5oxQ8rqrXL2sEMYN3dy9Nc=; b=MEtMRBkNp4w0wSEyq51eC7yZnSlVYRPLsbDsqw7rUK+hBMCF8Qj9VnQhavJoM+L2F8wzzaYi/mtte7mq6DFP+Cu1tq16kM+NiqGCpMNhfUoczY0SwUQOHEVae+cDs3xSKFQ1PlVnsV1vvslmHqaDSRtWmklOXFslLvVix3w4z5k84OE15KAiP+y19/XNopu2iAtEQUKST+F8IaxyylHU1wixGCSNvzovOUU79qgLtNpYVTotuvl6pzL4G5g0lOAs5S3K1a7G7eyzTGIp3iDqxiKqtVCfC1Ml27UsFR7oyGmKqiJtv0660Tbo3tW8oHL4PQZnPjRWTgSlqBuSv2VlIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YN1kUGzVaZzBDRHZWUAwx5oxQ8rqrXL2sEMYN3dy9Nc=; b=SaRfXjehOPnbes29U6YFrWJ3kR098vo+CRSD8WKL1WEjFLwg78vY+d095OWupMH0SQBjqMnUuUyiWE/THtj2YRsDkG0RTrCn4bk/9i6eTFFL9irG4jx3JxW09Usj1k7vxd46YOY2/pV5V21fxnz6W/DA7wEGty9z79sDUvOf/lk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5915.namprd11.prod.outlook.com (2603:10b6:510:13c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Thu, 11 Nov 2021 17:21:14 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4669.019; Thu, 11 Nov 2021 17:21:14 +0000 Message-ID: Date: Thu, 11 Nov 2021 17:21:09 +0000 Subject: Re: [PATCH v2] net/iavf: fix pointer of meter data Content-Language: en-US To: Alvin Zhang , CC: , References: <20211111024943.7612-1-alvinx.zhang@intel.com> <20211111063147.1596-1-alvinx.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211111063147.1596-1-alvinx.zhang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0203.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0203.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19 via Frontend Transport; Thu, 11 Nov 2021 17:21:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b4e7e03-c165-4f23-7d49-08d9a537aa04 X-MS-TrafficTypeDiagnostic: PH7PR11MB5915: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OGybnRxeS7xDExWugYc5rsc9ZMtlsZoVEHqtYOrBZcxIZpkyaQFvX+1gIcDV7Iaiia3SnBa9dIFVR47uZKPJW6cx3UgY84srAYaK6GkKi0nmKuKta9kBy2tgqxf3BRQ/ctw23L8DTXlc042mv7mxSkQ9wsD5EOn4xzL9eumX2TGhif7nm2RoeUDOKMdAQRvQJ/WdTRk1oHnIt3M2yzDP1rxDdFSlf6BG+piYpKnayxVSHiLl+eOfzPYC0icpdzOpS5hbGEay0zVvcKxBMT8cbq/b63PO87EbW/boRn+VPfzKV5KEm9t03hu0MqBiJn4Zy8kPhMiFvCSGKG/fO40b0nH0moFffgWJ+O5KxTz4cAh7imCaigLUHipvyGpcxzAX0RLEvRx+AMdreK5OXG5zjpfqQhyozldxOwaOH2p0CSKzJrTKRC/qEqPInJxstlUSq8Fqi7BPEANnsDJQrGffQ9UF/bXuXRJ34ZaVKINryFPdo4z9MMU/vm7vgsVnuqS2Uwe+khiXiShlDtUp97kq1uYQsdF3+/QXVZjzZUgGhuSShJxSGbY6h03RVGC+3Fo+ULd5+GXBegK5+ZLZjclF2534FySNIfFFg2N41I+XGxA5extupxmzgxpnjvHHx2KBJXqhkfFt7vQepg/LAcemSb5f3FuP999XifIPgF49RgR5TzYQH3B62CED4Qt36UmTgE7jqD01fg/S/esj8Jvoxg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(82960400001)(186003)(2616005)(38100700002)(450100002)(956004)(16576012)(4326008)(2906002)(6486002)(8936002)(86362001)(66476007)(8676002)(66946007)(53546011)(316002)(5660300002)(508600001)(31686004)(83380400001)(26005)(6666004)(6636002)(44832011)(66556008)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWZrL1IwT0kzMWViSGZraDNSSkl4cEpnckkxOHhaWkFab3luQVYvL0lWRlJR?= =?utf-8?B?akpXb1pxSmdMZE0xVUJxWmEzTmUxQjNMVVJvZHZLV3VqSmVPYmlwTnNiSGlU?= =?utf-8?B?bVJ2N0JCN0txRnE4K2NrM3pYaEQ3ZVJIN0l3bzN2eERKY3FWcDBwS0MwOG1B?= =?utf-8?B?ZWJlQyszQUFRcVBHeldEZUpOcHArdC9tZzFCWWsvdjc1THlhdE4reDMwd2FM?= =?utf-8?B?SnRrYU96RHU4a2l1dEZXSjBmWEdTendBaG9ubVo4MTF6aGV4RTZSZUdTTkxF?= =?utf-8?B?VllWVkkxUWVhTzJNUFdpQ0tlZXRyVzF6RGRLWG9WVlJ6aHJBMEtncTV5Y0tY?= =?utf-8?B?VkwxK3NOUTdaMVRjMXNyK3Q0L1NyeExodGFNV29uUnFzZ1YrQ0pSeWozQ08r?= =?utf-8?B?RG4rSm5YYVVDZUh5K2wybU5zUndNMjQybGptdFpocnpLSFk2eGJTcHQ3Mnoz?= =?utf-8?B?VW9tSGZ6dFF6SFpYUFl0RGxDYmZwTkEvTHdBUmZZVnZkQW1tVnUvQ3hUNTNI?= =?utf-8?B?UW5KZG1pWkxzeEFDS1lkOWMycytJMm03SXlnbUJLNTl5bnNXaHRUZFBib3Fi?= =?utf-8?B?ejV2OVpoOUtqS1pQN1N2ejVIWXQvKzRqTk8vblBUTk82cC96Q1VpdzJzbVZU?= =?utf-8?B?QS9aYUFyQ0dDRTN5VHhDTllmNGpnTW4yKzdpT2hBdGNWQlN2SHFqdnR4b1hm?= =?utf-8?B?NGVhSytaeDVJakpZS1NLVDRPZWZwenhrditMait4bDQxM1k1c2NSb3JhSzVE?= =?utf-8?B?bUZOSVVDK3dwTE1tMjBFempYTjliK2t3MElLUFdIcHJTdjhETkRUbk8zb094?= =?utf-8?B?RkJYTjJ5NUIrTjVUNmRUWk9QY1BJT214MmMxMHNveWpvdUsremQ2MTNCMnoz?= =?utf-8?B?NnJGRXllZzJBblhlSmVtUjVGNytyaTFCeVZFMUVYTmo2VHRRdEJDbStUWTdT?= =?utf-8?B?NjVidXFMZFJyUVhjdmMvYWJZL2JWQ25iWGxoeGl5aG5oTnBSaExWcnVUR1M2?= =?utf-8?B?QWt1cjNqVWNqWHRmbjV0YmNOd2VUNjlGNGJPV1o0VGVGd3lSNVJLZXBTN0lt?= =?utf-8?B?Q01DeFpPSWZNRUh4cm05WUpwSFpDYzNmTmhUZXRDSmxKNndGUEZNc0pSQmlx?= =?utf-8?B?dHltL1ZocFRqRkQ0WGdmdkVsRkpDT2Q4ZEpLQXNkL0kwc0JhdjRyK2lXSmxJ?= =?utf-8?B?c1BNb0pHR1V3NlRZVFU4QW40L0MydE1uRG1BSm9DT2hTbXpJM1ljdEFSekho?= =?utf-8?B?WHhZd0xTS0hMbzYwZGNUYWc3VDJKRzdsR0o5ci94ZDdSUGxHalYvdUljcXpK?= =?utf-8?B?WGliaDVLa0JaOXlwSkdMaVRGeW1DL2kvenlNczc2dkFnTUhEVjVKS2cvVFVL?= =?utf-8?B?VXBNUXZ3RW1nYTlqMy9zZkdBMHIwWGNtaVkzbnR1TFlzWEttcDBONzBUNndY?= =?utf-8?B?alJmc1A4UWdnVmw4QzhMV1pWaFVDTVhFZTRWeVo1dXAwOFltTHFUZzlUYitn?= =?utf-8?B?ZUpncFY2N1ZJR3VrWm9RZHR2bzdYeU1SdFlUMjhYTUQ5RER2cUQ2NDNRMUd2?= =?utf-8?B?VXc1dVI4a1lqRDlxRkNYbUhMaTJYcEtkYkRMV1JoZ2hDQVdkb3A3WTVGMFUz?= =?utf-8?B?NDducUhmOE13VkM3Y1V3c2ZYVmVHYU1JblZDM21xUUwwUnVCM201bDgxaFVs?= =?utf-8?B?Q0lhTG5iYzBuTzYvaE1KNCtJTHdqeWxhSnVWZ2RwZFFBdzBQcVVVTXQyaEFS?= =?utf-8?B?bVV3dEFpblBOZVFYajdCNkNZbEVjVVYwcW84VG93N3UvV0pkN2syQmxHbXY5?= =?utf-8?B?VHJoUXlEMWRtUlQxekNOcGNUWFo2ZW9yazQzOE5pZ3dGMHRpUXhkNEFqUVY1?= =?utf-8?B?dzBVQ0E2OTlKR0hVUFh1L1Z6bkVBL1YraUFHSHAxREFIeTJZK08rSVEyUjJ5?= =?utf-8?B?SmZBTTRMOTVHVUlCSWlBWEJuS1lWeGEydmRjalJzNkZ3UEtoZElVc0FoZE1K?= =?utf-8?B?d0JDdkU1em9lVzRZdmdObGEvd1RFaWJUTGkyemtpamxjK3N0ZmE3UlZ6NldR?= =?utf-8?B?bGJHdklwQWhpS2xZQk95U0hETWlVQ29EWXl5VUwxUkk5dG1FUnFLS251SmEx?= =?utf-8?B?WURURzdOTnhKT2JZTDdYcDdhQWxyUGRMdldNeURVcVZzVzlpcUU1SjB2ZVFv?= =?utf-8?Q?j0jsYWcPtGc6A+n8eSnLIdc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9b4e7e03-c165-4f23-7d49-08d9a537aa04 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 17:21:14.6608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dztKIxQ1QwqBfm2ZjeJO/dzKTX0VnyGvsLjNgb+lNNg/zRPcMBRxP/MpHdOIIiG3/nLKeyuv1SCBuXlhDpxsDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5915 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/11/2021 6:31 AM, Alvin Zhang wrote: > This patch fixes coverity issue by directly passing the address > of the meter data to lower function. > > Coverity issue: 373867 > > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") As far as I can see fixed commit is: Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") I will update in the next-net, can you please double check? > Cc: stable@dpdk.org > > Signed-off-by: Alvin Zhang > --- > drivers/net/iavf/iavf_hash.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c > index 55d8a11..5e0888e 100644 > --- a/drivers/net/iavf/iavf_hash.c > +++ b/drivers/net/iavf/iavf_hash.c > @@ -1261,10 +1261,9 @@ struct rss_attr_type { > static int > iavf_hash_parse_action(struct iavf_pattern_match_item *match_item, > const struct rte_flow_action actions[], > - uint64_t pattern_hint, void **meta, > + uint64_t pattern_hint, struct iavf_rss_meta *rss_meta, > struct rte_flow_error *error) > { > - struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta; > struct virtchnl_proto_hdrs *proto_hdrs; > enum rte_flow_action_type action_type; > const struct rte_flow_action_rss *rss; > @@ -1378,7 +1377,7 @@ struct rss_attr_type { > goto error; > > ret = iavf_hash_parse_action(pattern_match_item, actions, phint, > - (void **)&rss_meta_ptr, error); > + rss_meta_ptr, error); > > error: > if (!ret && meta) >