From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BA83641DAC
	for <public@inbox.dpdk.org>; Wed,  1 Mar 2023 15:08:28 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AE8D441181;
	Wed,  1 Mar 2023 15:08:28 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id CD2B84113C;
 Wed,  1 Mar 2023 15:08:26 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D4E9A59;
 Wed,  1 Mar 2023 17:08:25 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D4E9A59
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1677679705;
 bh=nFeSGQgqIPtJeWgz6Lzy4tnJskt+hydpIVNUkMu0FK4=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=AbvgT9sbbw8ym2tqx/kZ3nyxnnEtAOf+E4/ApfKQFGg822fOGDD92yElMAmrSQHc5
 DaKg6Kjh5gwjwULoVOPh+ISN3JM3F4jwjRrsRKo0iajyc3NXpCtwD341irgF9Nd2Yt
 58WjzqArCWEGogJ6WBv05Y/MzCqUwn7k4/LWkCKI=
Message-ID: <b0f38b16-a016-e443-6b66-46849b236625@oktetlabs.ru>
Date: Wed, 1 Mar 2023 17:08:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
Content-Language: en-US
To: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>, dev@dpdk.org,
 stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>
References: <20230228180230.3066738-1-ferruh.yigit@amd.com>
 <9988058.nnTZe4vzsl@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <9988058.nnTZe4vzsl@thomas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

On 3/1/23 14:37, Thomas Monjalon wrote:
> 28/02/2023 19:02, Ferruh Yigit:
>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
>> which is exposed via ehtdev stat APIs.
>>
>> But telemetry exposes this field to user via "/ethdev/info",
>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>>
>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>>
>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> ---
>> -	rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
>> -			eth_dev->data->rx_mbuf_alloc_failed);
> 
> Good catch, thanks.
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>