Re: [PATCH v2 3/9] baseband/acc: add explicit mbuf append for soft output

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 2/10/23 18:58, Nicolas Chautru wrote:
> Adding an explicit mbuf append in the case of soft output
> mbuf being provided.
> 
> Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I don't remember having put my R-by on this patch.

As I suggested to Hernan, one way to avoid such mistakes is to start the
next revision by applying the patchwork version. Just get the series
link from patchwork and apply it.

E.g. for this specific case:

$ curl http://patches.dpdk.org/series/26933/mbox/ | git am -3

There may be other ways, but that's how I do it.

The patch looks good to me, based on your explanation on V1, so don't
remove it in next revision (if any).

Maxime
> ---
>   drivers/baseband/acc/rte_vrb_pmd.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
> index fc68f47ca6..b1134f244d 100644
> --- a/drivers/baseband/acc/rte_vrb_pmd.c
> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
> @@ -2066,6 +2066,10 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
>   		}
>   	}
>   
> +	if (op->ldpc_dec.soft_output.length > 0)
> +		mbuf_append(op->ldpc_dec.soft_output.data, op->ldpc_dec.soft_output.data,
> +				op->ldpc_dec.soft_output.length);
> +
>   #ifdef RTE_LIBRTE_BBDEV_DEBUG
>   	rte_memdump(stderr, "FCW", &desc->req.fcw_ld,
>   			sizeof(desc->req.fcw_ld) - 8);