From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16CD541D3C for ; Wed, 22 Feb 2023 12:20:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1220B40693; Wed, 22 Feb 2023 12:20:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6920640689 for ; Wed, 22 Feb 2023 12:20:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677064809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n1iuxCSyjo2Fu9KaUqYkKfSFhw7qM0G8V2n9223Sm5M=; b=F4xBXH3YzlWQ24lB/9CVDW1VZYDvcDzKhTz9CLCecMPcFTrU5bJCZ9fm0jBAOgA4DgC5io edwrmkPSvGgVSffjiroFQi4f/jd+P70DlTnINzIpV1vOsL5+svrTg2TWIxZzaEYCu5jA8U sC5KmnER5RfTC6yA3ln7DkKmg+DxD+0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-549-HDqsxgJuOSCrRD3bfeSRIQ-1; Wed, 22 Feb 2023 06:20:06 -0500 X-MC-Unique: HDqsxgJuOSCrRD3bfeSRIQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B659800B23; Wed, 22 Feb 2023 11:20:06 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 661FF492B00; Wed, 22 Feb 2023 11:20:05 +0000 (UTC) Message-ID: Date: Wed, 22 Feb 2023 12:20:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Nicolas Chautru , dev@dpdk.org Cc: hernan.vargas@intel.com, stable@dpdk.org References: <20230209221929.265059-2-nicolas.chautru@intel.com> <20230210175841.303450-1-nicolas.chautru@intel.com> <20230210175841.303450-4-nicolas.chautru@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v2 3/9] baseband/acc: add explicit mbuf append for soft output In-Reply-To: <20230210175841.303450-4-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/10/23 18:58, Nicolas Chautru wrote: > Adding an explicit mbuf append in the case of soft output > mbuf being provided. > > Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru > Reviewed-by: Maxime Coquelin I don't remember having put my R-by on this patch. As I suggested to Hernan, one way to avoid such mistakes is to start the next revision by applying the patchwork version. Just get the series link from patchwork and apply it. E.g. for this specific case: $ curl http://patches.dpdk.org/series/26933/mbox/ | git am -3 There may be other ways, but that's how I do it. The patch looks good to me, based on your explanation on V1, so don't remove it in next revision (if any). Maxime > --- > drivers/baseband/acc/rte_vrb_pmd.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c > index fc68f47ca6..b1134f244d 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -2066,6 +2066,10 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, > } > } > > + if (op->ldpc_dec.soft_output.length > 0) > + mbuf_append(op->ldpc_dec.soft_output.data, op->ldpc_dec.soft_output.data, > + op->ldpc_dec.soft_output.length); > + > #ifdef RTE_LIBRTE_BBDEV_DEBUG > rte_memdump(stderr, "FCW", &desc->req.fcw_ld, > sizeof(desc->req.fcw_ld) - 8);