From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BEE442850 for ; Thu, 30 Mar 2023 10:54:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56D94410D3; Thu, 30 Mar 2023 10:54:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 17BBA40E25 for ; Thu, 30 Mar 2023 10:54:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680166480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LjAOBRPD+teT/HbyZR+kkvA7SZEyD9asKTyzkMIa5ZU=; b=h/pwuzHsGlFm7/3aLHfoYruYmuJoKXauny2LIpHvLK+5YDORdk72qCmAAEQAM8f2VsRVQ3 5ZL2OdOGILgMUsKlxGlYXHG+SwLz/RctXzIi3JSAbxENcU8J4nR7rYKdq/9WbykWvU0F8s +TABzyThQquT4I/Uk0ceCddaMFtdcNs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-YscDyLjWOgq89YqOzLnrAA-1; Thu, 30 Mar 2023 04:54:37 -0400 X-MC-Unique: YscDyLjWOgq89YqOzLnrAA-1 Received: by mail-wm1-f71.google.com with SMTP id n19-20020a05600c3b9300b003ef63ef4519so7904997wms.3 for ; Thu, 30 Mar 2023 01:54:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680166476; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LjAOBRPD+teT/HbyZR+kkvA7SZEyD9asKTyzkMIa5ZU=; b=MWrbEc8TT9qiX4hyUtxFAiJqewvjsJSoVysaVz26nS+L/D7zHFhdSaVpiCZl0OR1XZ 9dZb9bWacURNb7V1J6IWiJCbgN5BiY0p7VghTeD4mJLyF8acjHao9+lZfTjKNxLVnHWE p0t2SbPQlEcWJ5eyzgiYrKY/dAFrKVjhibWKAo2Tuv+RITR+ZqTVvAjQTBxpV9Pvey+F RWL8noT0N7AjXUe+DsoKkpkzQqzdoLIJ63i7hBe0z7FxD5F9C+ckgYPDX1QG0ewRZqwr ztRiBaJpsVXCr7cVqH+emnawyROuL1TFOHC05dcIDG6KXUIkMw+ZFrpLdxdf47eyATgw OUag== X-Gm-Message-State: AAQBX9da9vI+MgicAMuea3M2we1GKKiAezOTWh18WI6AMUAF7gi8smWP gsF+5rEg8IrhDoaBQRsW6D3eBkPMHi1il8K5fhdDH6HHpukPObG/cbbZG40Zr6GLS8Tl1EJ+5Ei VV+KxKWI= X-Received: by 2002:adf:e282:0:b0:2ce:a8e9:bb3c with SMTP id v2-20020adfe282000000b002cea8e9bb3cmr17949836wri.15.1680166476444; Thu, 30 Mar 2023 01:54:36 -0700 (PDT) X-Google-Smtp-Source: AKy350YwpTjsXdGi6Fql3KzAfOMGTLOd/vjjvTkBunhv27/g9yc6Qm4AGVb7L0Uzi5KxODazDhPDxA== X-Received: by 2002:adf:e282:0:b0:2ce:a8e9:bb3c with SMTP id v2-20020adfe282000000b002cea8e9bb3cmr17949814wri.15.1680166476096; Thu, 30 Mar 2023 01:54:36 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id g16-20020a5d4890000000b002de99432fc8sm12656152wrq.49.2023.03.30.01.54.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Mar 2023 01:54:35 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 09:54:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , stable@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , Chaoyong He References: <20230322154824.948054-1-niklas.soderlund@corigine.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] net/nfp: fix MTU configuration order In-Reply-To: <20230322154824.948054-1-niklas.soderlund@corigine.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 22/03/2023 15:48, Niklas Söderlund wrote: > From: Peng Zhang > > [ upstream commit 4352a3bcee3a4cc20c8accb71d683d5add3c6f80 ] > > If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the > NFP driver setup fails. This is because the default values evaluated > when setting the MTU are initialized in the rte_eth_rx_queue_setup() > code path. Fix this by instead initializing the MTU default values in > the device initialization, in nfp_net_init() and the check also is > conducted in nfp_net_start(), so it doesn't influence the result. > > This was found by using DPDK with OVS. > > Fixes: dbad6f64f921 ("net/nfp: fix internal buffer size and MTU check") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfp_common.c | 4 ++-- > drivers/net/nfp/nfp_common.h | 1 + > drivers/net/nfp/nfp_ethdev.c | 1 + > drivers/net/nfp/nfp_ethdev_vf.c | 1 + > 4 files changed, 5 insertions(+), 2 deletions(-) > Thanks Niklas. Applied and pushed to 21.11 branch. Kevin.