patches for DPDK stable branches
 help / color / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: David Marchand <david.marchand@redhat.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix unitialized data warning
Date: Wed, 4 Dec 2019 15:17:03 +0300
Message-ID: <b2156e57-a47d-9eab-d418-264c56fa7653@solarflare.com> (raw)
In-Reply-To: <CAJFAV8ws+FdjQgqzrb4p5HGkvSjKhxhxuw8Emts9xvH83Rs85Q@mail.gmail.com>

On 12/4/19 2:12 PM, David Marchand wrote:
> Fixed title s/unitialized/uninitialized/
> 
> On Wed, Nov 27, 2019 at 11:32 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>>
>> Valgrind reports that eal interrupt thread is calling epoll_ctl
>> with uninitialized data.  Trivial to fix by initializing it.
> 
> Added a note on it being a Valgrind false positive.
> 
> 
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
> 
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: David Marchand <david.marchand@redhat.com>
> 
> Applied, thanks.

It breaks build on RHEL 7.6 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36):

lib/librte_eal/linux/eal/eal_interrupts.c: In function
‘eal_intr_thread_main’:
lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing
initializer for field ‘events’ of ‘struct epoll_event’
[-Werror=missing-field-initializers]
   struct epoll_event ev = { };
          ^
In file included from lib/librte_eal/linu/eal/eal_interrupts.c:15:0:
/usr/include/sys/epoll.h:89:12: note: ‘events’ declared here
    uint32_t events; /* Epoll events */
             ^


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 22:32 [dpdk-stable] " Stephen Hemminger
2019-11-29  8:25 ` David Marchand
2019-11-29 17:02   ` Stephen Hemminger
2019-12-04 11:12 ` David Marchand
2019-12-04 12:17   ` Andrew Rybchenko [this message]
2019-12-04 12:31     ` [dpdk-stable] [dpdk-dev] " David Marchand

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2156e57-a47d-9eab-d418-264c56fa7653@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox