From: Luca Boccassi <luca.boccassi@gmail.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>, stable@dpdk.org
Cc: nd@arm.com, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 20.11] config: add arch define for Arm
Date: Mon, 21 Feb 2022 11:06:11 +0000 [thread overview]
Message-ID: <b25dd69f39fe23b104849f9549e9cbcfab2d3bb2.camel@gmail.com> (raw)
In-Reply-To: <20220221031718.1160060-1-ruifeng.wang@arm.com>
On Mon, 2022-02-21 at 11:17 +0800, Ruifeng Wang wrote:
> [ upstream commit 9cc217a28310d21fba56e5eceb740b4feb7e0949 ]
>
> As per design document, RTE_ARCH is the name of the architecture.
> However, the definition was missing on Arm with meson build.
> It impacts applications that refers to this string.
>
> Added for Arm builds.
>
> Fixes: b1d48c41189a ("build: support ARM with meson")
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> config/arm/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index fcbcf1ca56..bb72f40c65 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -137,12 +137,14 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)
> if dpdk_conf.get('RTE_ARCH_32')
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> dpdk_conf.set('RTE_ARCH_ARMv7', 1)
> + dpdk_conf.set('RTE_ARCH', 'armv7')
> # the minimum architecture supported, armv7-a, needs the following,
> # mk/machine/armv7a/rte.vars.mk sets it too
> machine_args += '-mfpu=neon'
> else
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> dpdk_conf.set('RTE_ARCH_ARM64', 1)
> + dpdk_conf.set('RTE_ARCH', 'armv8')
>
>
> machine = []
> cmd_generic = ['generic', '', '', 'default', '']
Thanks, applied and pushed.
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2022-02-21 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 3:17 Ruifeng Wang
2022-02-21 11:06 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b25dd69f39fe23b104849f9549e9cbcfab2d3bb2.camel@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).