* [PATCH 20.11] config: add arch define for Arm
@ 2022-02-21 3:17 Ruifeng Wang
2022-02-21 11:06 ` Luca Boccassi
0 siblings, 1 reply; 2+ messages in thread
From: Ruifeng Wang @ 2022-02-21 3:17 UTC (permalink / raw)
To: stable; +Cc: luca.boccassi, nd, Ruifeng Wang, Stephen Hemminger
[ upstream commit 9cc217a28310d21fba56e5eceb740b4feb7e0949 ]
As per design document, RTE_ARCH is the name of the architecture.
However, the definition was missing on Arm with meson build.
It impacts applications that refers to this string.
Added for Arm builds.
Fixes: b1d48c41189a ("build: support ARM with meson")
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/arm/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index fcbcf1ca56..bb72f40c65 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -137,12 +137,14 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)
if dpdk_conf.get('RTE_ARCH_32')
dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
dpdk_conf.set('RTE_ARCH_ARMv7', 1)
+ dpdk_conf.set('RTE_ARCH', 'armv7')
# the minimum architecture supported, armv7-a, needs the following,
# mk/machine/armv7a/rte.vars.mk sets it too
machine_args += '-mfpu=neon'
else
dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
dpdk_conf.set('RTE_ARCH_ARM64', 1)
+ dpdk_conf.set('RTE_ARCH', 'armv8')
machine = []
cmd_generic = ['generic', '', '', 'default', '']
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 20.11] config: add arch define for Arm
2022-02-21 3:17 [PATCH 20.11] config: add arch define for Arm Ruifeng Wang
@ 2022-02-21 11:06 ` Luca Boccassi
0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2022-02-21 11:06 UTC (permalink / raw)
To: Ruifeng Wang, stable; +Cc: nd, Stephen Hemminger
On Mon, 2022-02-21 at 11:17 +0800, Ruifeng Wang wrote:
> [ upstream commit 9cc217a28310d21fba56e5eceb740b4feb7e0949 ]
>
> As per design document, RTE_ARCH is the name of the architecture.
> However, the definition was missing on Arm with meson build.
> It impacts applications that refers to this string.
>
> Added for Arm builds.
>
> Fixes: b1d48c41189a ("build: support ARM with meson")
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> config/arm/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index fcbcf1ca56..bb72f40c65 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -137,12 +137,14 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)
> if dpdk_conf.get('RTE_ARCH_32')
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> dpdk_conf.set('RTE_ARCH_ARMv7', 1)
> + dpdk_conf.set('RTE_ARCH', 'armv7')
> # the minimum architecture supported, armv7-a, needs the following,
> # mk/machine/armv7a/rte.vars.mk sets it too
> machine_args += '-mfpu=neon'
> else
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> dpdk_conf.set('RTE_ARCH_ARM64', 1)
> + dpdk_conf.set('RTE_ARCH', 'armv8')
>
>
> machine = []
> cmd_generic = ['generic', '', '', 'default', '']
Thanks, applied and pushed.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-21 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 3:17 [PATCH 20.11] config: add arch define for Arm Ruifeng Wang
2022-02-21 11:06 ` Luca Boccassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).