From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D023843DCA for ; Mon, 8 Apr 2024 10:51:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA30B402C9; Mon, 8 Apr 2024 10:51:00 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2126.outbound.protection.outlook.com [40.107.243.126]) by mails.dpdk.org (Postfix) with ESMTP id 49DD540041; Mon, 8 Apr 2024 10:50:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LTEBGGr5oIQD5D+8eh2ETAVnu5+yBWSHBA+mSj54iDD8fsbqUfDeJ1ZlmhxxwL2alK8uDlRuX0Gs0cLa2ylKb11//63UNQboTYrBT4oKOHHUXOs3tHgUmWMMjYTX/+bvZDzcZdKWGuZVZgGVZ5wlbfFvLE4P2Ba+cbyFysdWxEEeXe0BCP8PnR8Rltxp+InrKVf0n2NSg1m7kXeF6Kw2RchJKRG6D5Mh0gA0qIVChhif/6dOTZvgEQobpAERb3OhUejM8smmXlXEeCE+hkery4T9/mrBOdpcevhZsCX21gkC9EwHhg+yXFlghSQqpD2AyKcOR0OYEqNt1xoeB2FB+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMmHs3PwGTQVtWfDwIxh5xkOGehu17ZFcboIoEmoq3s=; b=Mu3au7JwIAO0lKbxxjQBbP8nm+NHEWyzD0Oh6FQOE1+eGWozyRW7FrVMRiJlWRnD675Jr9xOOhBvoxULjOlLm5YUPUaizV87Gmyxrpr3GdGhC/i9KiHrgpTuvGt25VjFj3DeewOagZk3xK87x4LpLlzjSSY69bAAyAMP/KSYHiktLwKlC3wm3DqFcPJQp4QlfvNje++BfHh7iohxG2WbwIU1SO/4cdHJbBGeNdbSoaabNE1FyvavqvEO/M6ZpDPhpzew8jfcTcPwvhiwZZasfQvtxP+NPE2jzmGR3lO4c89lF7EZXb4wsssRWCpQm0iCAp1vckKeiJxmWMDmtB3DIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMmHs3PwGTQVtWfDwIxh5xkOGehu17ZFcboIoEmoq3s=; b=F8ruJ67x9ivD8n+MmnX7WGb5iFEbZPfYgLRj8cl4uhlzUwRBmlhRNRPyRDlDsVsS9wcE7xGiqn6FHrjlQftJHjYgZKqHMnaWqXjm5wj/Fkb6YQlZ9x0VZXloPSuXgqjTViSvql35Br3g+9AFyS5Kbn9Z+UNDwiadfBrtiNdnIDw= Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB4400.namprd12.prod.outlook.com (2603:10b6:806:95::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Mon, 8 Apr 2024 08:50:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7409.053; Mon, 8 Apr 2024 08:50:55 +0000 Message-ID: Date: Mon, 8 Apr 2024 09:50:51 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h To: Ashish Sadanandan , Thomas Monjalon Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com, stable@dpdk.org References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> <20240318024415.555614-1-ashish.sadanandan@gmail.com> <1836105.FMhQkTaH9n@thomas> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0132.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB4400:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m6ewuxZy6rWAoTOXbXlVyl1uJZo8/HTCTLp4IgjV1ZTnJ4bLcUWC1EOvRD+NjsKkLCaWwVihxsPnD/uAuXVg9MdpjJCY7iEr+UGlngH7wn9d9SI9ihGHmQGJWJDHgFpWV9xw3nmSQ4h09O+uCv1pIDJ6ezDbTLLMdOK5gB3JnX8ripBT2lHz6f533RS5RATWYhL4HHiQ6KRIKm5d8GIvxo8xLvJtiQeUxXzI4dji7I60YeLS89aZz246VExGlnIFZVs3bubmsQAFl9BQrPwQKK6NPsZ05coiYAMTUltUY+i/QeNlDpO7zdeeuVyKkrMa/8UDtu+atIrTEAd7F+OAU9nhCJl19y8iIF9zzxz6p2i0Dn8wc0JUJOzC1lYh/jy8vBNLSb2t3fn+Gm/rm5xRrqgnXmXwbKOkrx4EtVOiCae7rJtIqgbjKH0SyoyrzoZrRnOX4zOkvDeOVa9NrDxKTV5Iuuz+63Ik5Zlx8XcsbFr4biZlZDCXP/KCRIL/St2bl//rEqLR5LobbEwTJG27MOmCbFtd2n4lRHxpqGGG0FExZCB8VmAhCUl0C+JIkPm0lQKjv2zdZbg9aifhejLsOZdSpBW4gzKAn3O9J5LfIFNmUzGU7961TF3+cALhZvFeMem02/RYTaI/n3zZ2y2/dBlJEGY04x3UBfNHIaq1Atk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWRxYXNZOXNvSll3Y0JhdDRTVGZ6WVFuM0h1U1I0ZGhVVnlzU1Y1SExaZGkw?= =?utf-8?B?d2tjajdLLytqRFFTWHFwdWthVFNlbmpkbzlORXN1YzlibjJNcWlJR1pCS1ZE?= =?utf-8?B?OC9EL2RJRGllZ3VPd2FzVHpKZThHaFVWYnN2ZG9JVEx5VXp4V1ZrYmxxekZv?= =?utf-8?B?ZFNXUzVCcmk1Rm5SUGt3TnZHalFzeEw2eEpaMnllWTl0L1k1azRxaG0rYzRJ?= =?utf-8?B?dHY5aGJGVnl0b1ZGcTNyR2gwUE1LSXMvZGdOdWFFV2RFelZlV3VMWGg1K3RZ?= =?utf-8?B?SlFBWnZkazExSjdiL3d4OEVpUkNZZlFqVGEweG01K29VTlEvVnZVMjF2U25p?= =?utf-8?B?TzgxZkM0cnZlSWdqU29ZelJraUZ2aHlPS1ArV21nZm1seEc1ZU05N1FLcC9R?= =?utf-8?B?OHRqVHZjK1F6SzBvK1NZWmRsZ1Aybjl0dUZJYm1kem1ucVJzZkpHRHhaRTRP?= =?utf-8?B?aVBpSGtxMkd0WHV6aDE3NmM2ZTJrOHViOWdReDdneGQ0Y3BvSTg2dXVRLzVW?= =?utf-8?B?V29rdStFT28rdFJST1J1NUpuNmFNbHh2Sys0Y3hyYldvZy96ZWVGSHc4WWVV?= =?utf-8?B?QWUvZ0YzWXhjRks4SlJTMmZQN2pNMzN0RWdjajBtVTQvTG9wU1c2Z1ZPZXZ5?= =?utf-8?B?VG5pRmxvczgyOXJHa2dnbXR0ZFAyQUFSbGttTWFqNVZheWlTYVVwQStzdmRX?= =?utf-8?B?YmNWZlNDVTladWhyWUNhSndKWjVmaS9DODVrUEhmWURYL1gvc3N4UkFRK3hY?= =?utf-8?B?V3BobGdEMmdEVkV4STdKVE1XS2x5Mlg0K0NOQzBXUGk3b1NqMXdyR3kxSmoz?= =?utf-8?B?WVE3VDRRdENpaU1ZNWc0OGJvdlQwS1lIeHFFNUI4aGRjd2x3S0RJRkltYWZI?= =?utf-8?B?dkZ2cmJza1AwaXhpRDdleEtGOHZaQVhPTDJnQjdqU2E1K2labDBuUFArL0w5?= =?utf-8?B?Q2VDbmFyNDBKTWdKbG9yaVdiNnZNUWtZSEtxR0pCbUtDblJ3V2JKMmdoR3dj?= =?utf-8?B?QnUwcUl3YmpjVWVCbDZzUlNxTUVFcW1UVW44czduSE1rNG5NcnZ2QmQ3dDRO?= =?utf-8?B?eWdvSUlmc0E5QVFCTDg3Qm44Q1pQNUgvWndybEJPR0syWHRwcWZxai9aSEFh?= =?utf-8?B?OHNJRTNLSFdRQUZmeDYxNmNocG1Lb0pBRUFueHdyZklObXd6YWRhR1RoMjJD?= =?utf-8?B?b3crWktQOXdXRkx6T1FMQjc2bHdYU3ZBajhaR05pOHhrdnl5SXhoc0pTZElO?= =?utf-8?B?c25mblgzakx3TWVrTXF1TUlYNTRKWjVhOEtjUWhFZWs2cEtVQnp4Smk1UzB4?= =?utf-8?B?VWlTYWhyOU1SYjRTa1BFYlpyOHdsM2N0ODlNUEQ2RFRvaWN5QisvSkZ0ZGVj?= =?utf-8?B?bVVuSHVDRjFCVmZtSnZYSTdGR0tPeGdIRFFPeENaZTM4WjVaUExYL1YzRy9o?= =?utf-8?B?SGIwam5iQUcxTFRyeThWUU1QNzU3TzgwMDJlUTZUWWRHMFBXYlVOZkRQS2VH?= =?utf-8?B?MWVUQUtQMHhtL09Hb3ZYL1U1bDlDVW15emRVQkJlQmZ0Ylh5YnpDVWdneWYy?= =?utf-8?B?QkZwbG9pVlFkeDJJZGVMOXc5bTRyQTFRaUZKUzhrcEI4ejVaSmt2ckg3U01k?= =?utf-8?B?ZEF3Y3dDS2Jwblk5bU0xMFNnK2cwMTRpdS9HRXZwKzA4dGtOcXlvYjdCSFpJ?= =?utf-8?B?dmZsczBOMGc3ZnlvZld1UDRPTExKUEVsdkJFRzh1NGpaUVI2UlJNd0wvMHNr?= =?utf-8?B?THRBZWZGeWZFZld4TlpVQTk5Z1NpTjMvaUhXcGZHdnd0eHRxdENkNnVtMDVS?= =?utf-8?B?N0NxK0tPVVZ0NTdPclFYZlh3T0twalVWVVZxdFdUZjVqcXhRaWFrd3FTVWNp?= =?utf-8?B?M3NrTlY4UUtaLzJjSFJ6akZlY3pFS290ZFdBeWR6SWhKZUFLNmllS2tIUFds?= =?utf-8?B?Q0ZPaE9jeWFJdFlCamVGaVhSZWhSbm5qRGR4bzZiMWpmdWxIU2QxZEVUUStj?= =?utf-8?B?dHFRRnM0VXY5UUZWU2Z2cjI1eFVra0VVcmg5Zms3T1dVRjdZM3BOWUxJays5?= =?utf-8?B?cUxNVFkzVTVGMkREaWVVeGM1Y1lQTFFtTDYyekFFTnN0azRib1JmR254c1Nt?= =?utf-8?Q?rv69xfzcgPi07VjT9Y1eB1ZsX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fcd895b-2b32-461f-8149-08dc57a900d1 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 08:50:55.6436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hypKTDOLF7Yy9v73j+52AE4GSeXel3I3MPT/rx3nNWY/yxsCSm7mCGOipxALrYh5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4400 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 4/7/2024 2:30 AM, Ashish Sadanandan wrote: > > > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon > wrote: > > 02/04/2024 18:03, Ashish Sadanandan: > > Hi everyone, > > I've made the updates as suggested. Could someone please review > the latest > > patchset? Not sure if I followed the new patchset instructions > correctly, > > I've always had trouble with that part. > > I remember we were discussing about aligning all files. > I was waiting for a patch applying the rule we discussed. > > I missed the part where people were volunteering me for additional work :) > > The consensus seems to be that the extern "C" directives should only be > in public headers, not private ones. Can you please tell me if there's > an easy way to get a list of public headers?  > Public headers are installed as part of ninja install target, so one option is you can install a build to a custom folder and get the list from there. Or they are listed in meson.build files in 'headers' variable, you can parse them. Don't get confused with 'driver_sdk_headers' variable in meson files, that is the list of headers required for driver development, and installed if sdk ('enable_driver_sdk') meson option is enabled. > > > On Sun, Mar 17, 2024 at 8:44 PM Ashish Sadanandan < > > ashish.sadanandan@gmail.com > > wrote: > > > > > The header was missing the extern "C" directive which causes name > > > mangling of functions by C++ compilers, leading to linker errors > > > complaining of undefined references to these functions. > > > > > > Also updated the coding style contribution guideline with a new > > > "Language Linkage" section stating `extern "C"` block should be > added to > > > public headers. > > > > > > Fixes: 86c743cf9140 ("eal: define generic vector types") > > > Cc: nelio.laranjeiro@6wind.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Ashish Sadanandan > > > > --- > > >  .mailmap                                 |  2 +- > > >  doc/guides/contributing/coding_style.rst | 21 +++++++++++++++++++++ > > >  lib/eal/include/generic/rte_vect.h       |  8 ++++++++ > > >  3 files changed, 30 insertions(+), 1 deletion(-) > > > > > > --- a/doc/guides/contributing/coding_style.rst > > > +++ b/doc/guides/contributing/coding_style.rst > > > +Language Linkage > > > +~~~~~~~~~~~~~~~~ > > > + > > > +Public headers should enclose all function and variable > declarations and > > > definitions in an ``extern "C"`` block to facilitate > interoperability with > > > C++. > > > + > > > +.. code-block:: c > > > + > > > +   #ifndef _FILE_H_ > > > +   #define _FILE_H_ > > > + > > > +   #ifdef __cplusplus > > > +   extern "C" { > > > +   #endif > > > + > > > +   /* Code */ > > > + > > > +   #ifdef __cplusplus > > > +   } > > > +   #endif > > > + > > > +   #endif /* _FILE_H_ */ > > This is not describing where the includes should be placed. >   > > Will address this along with the rest of the headers. > > Regards, > Ashish.