From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD086A00C5 for ; Thu, 15 Sep 2022 13:34:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A647E4021D; Thu, 15 Sep 2022 13:34:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7237240156 for ; Thu, 15 Sep 2022 13:34:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663241641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wj5im89xCO758c6Sq+aNrgeUWhJsX4yw7q5SViX4gW0=; b=XTiUu2rIaeCyV5ZV065TEbwU3bwENlJgFnwdKhN/ewD6kn1kpu1LB8HmQYQ3HQ4yF3A11w yQjaEycouJKvCL2YIWFNTpfvQrQP5qR5msi7+TEyvMemQxWTZx34ebNp14gyEDcr4mkW8c dOcGWqE6/CSvpu+y0/o8nnAI/3DhSr8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-365-_tqMhbvvPkOpklvUwj1RgA-1; Thu, 15 Sep 2022 07:33:59 -0400 X-MC-Unique: _tqMhbvvPkOpklvUwj1RgA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BD88185A7AC; Thu, 15 Sep 2022 11:33:59 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA915200BA63; Thu, 15 Sep 2022 11:33:57 +0000 (UTC) Message-ID: Date: Thu, 15 Sep 2022 13:33:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 36/37] baseband/acc100: make HARQ layout memory 4GB To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-37-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-37-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > HARQ layout memory should be 4GB instead of 2GB. > > Fixes: 4cf90079797 ("baseband/acc100: add HW register definitions") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/acc100_pmd.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc100/acc100_pmd.h b/drivers/baseband/acc100/acc100_pmd.h > index 27801767b7..f9ccb1ea8e 100644 > --- a/drivers/baseband/acc100/acc100_pmd.h > +++ b/drivers/baseband/acc100/acc100_pmd.h > @@ -61,8 +61,10 @@ > #define ACC100_SIZE_64MBYTE (64*1024*1024) > /* Number of elements in an Info Ring */ > #define ACC100_INFO_RING_NUM_ENTRIES 1024 > -/* Number of elements in HARQ layout memory */ > -#define ACC100_HARQ_LAYOUT (64*1024*1024) > +/* Number of elements in HARQ layout memory > + * 128M x 32kB = 4GB addressable memory > + */ > +#define ACC100_HARQ_LAYOUT (128*1024*1024) > /* Assume offset for HARQ in memory */ > #define ACC100_HARQ_OFFSET (32*1024) > #define ACC100_HARQ_OFFSET_SHIFT 15 Please move it to the top of the series for next revision. Reviewed-by: Maxime Coquelin Thanks, Maxime