From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99A2A4235C for ; Wed, 11 Oct 2023 08:47:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 902C6402ED; Wed, 11 Oct 2023 08:47:01 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id BC37F4028A; Wed, 11 Oct 2023 08:46:59 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 89F351377; Wed, 11 Oct 2023 08:46:59 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 7E5B313F4; Wed, 11 Oct 2023 08:46:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.6 X-Spam-Score: -1.5 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 3B22614C7; Wed, 11 Oct 2023 08:46:58 +0200 (CEST) Message-ID: Date: Wed, 11 Oct 2023 08:46:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] eventdev: fix symbol export for port maintenance Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Jerin Jacob , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= References: <20231010140029.66159-1-david.marchand@redhat.com> From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20231010140029.66159-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2023-10-10 16:00, David Marchand wrote: > Trying to call rte_event_maintain out of the eventdev library triggers > a link failure, as the tracepoint symbol associated to this inline > helper was not exported. > > Fixes: 54f17843a887 ("eventdev: add port maintenance API") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > Caught by the CI when testing the dispatcher library. > See for example: > https://github.com/ovsrobot/dpdk/actions/runs/6460514355/job/17538348529#step:19:5506 > > --- > lib/eventdev/version.map | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > index b03c10d99f..249eb115b1 100644 > --- a/lib/eventdev/version.map > +++ b/lib/eventdev/version.map > @@ -5,6 +5,7 @@ DPDK_24 { > __rte_eventdev_trace_deq_burst; > __rte_eventdev_trace_enq_burst; > __rte_eventdev_trace_eth_tx_adapter_enqueue; > + __rte_eventdev_trace_maintain; > __rte_eventdev_trace_timer_arm_burst; > __rte_eventdev_trace_timer_arm_tmo_tick_burst; > __rte_eventdev_trace_timer_cancel_burst; I can't say I know why it's needed, but the change seems consistent with other Eventdev trace points. Maybe Jerin can comment on this? If not, I can dig into the details.