From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79E27A00C3 for ; Tue, 20 Sep 2022 11:36:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45FE140DFB; Tue, 20 Sep 2022 11:36:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EA44F4069B for ; Tue, 20 Sep 2022 11:36:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663666567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NLpV+FwK/rm271g+arQ/xtizowwWi39jh3gCepyp99c=; b=BQRyzr4PiKR+xs+6GAo1TAmlagDexH3538Lnda/y0+T9pEddlM0ybJfXjYUIJXYZAfSFxL B8ckNMNSmk9Io/E1j3Gl62G5yt0dJKhOcCQN9LNgFlgXv2tFrBE2g6yrv4E5qnBXL+Dgmm swKmLGO+QY+lS5F5UUzOAsp6XOdKKJU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-5Hs7M5LDM4aEgN0meLeGHg-1; Tue, 20 Sep 2022 05:36:06 -0400 X-MC-Unique: 5Hs7M5LDM4aEgN0meLeGHg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1385D299E755; Tue, 20 Sep 2022 09:36:06 +0000 (UTC) Received: from [10.39.208.16] (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9A6C492B05; Tue, 20 Sep 2022 09:36:04 +0000 (UTC) Message-ID: Date: Tue, 20 Sep 2022 11:36:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 To: "stable@dpdk.org" , Kevin Traynor , Luca Boccassi , Christian Ehrhardt , Xueming Li From: Maxime Coquelin Cc: Michael Phelan Subject: Early backport of Vhost regression fix in LTS branches X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi LTS maintainers, We have discovered a regression causing deadlock in application using the Vhost library (when vIOMMU is used & NUMA reallocation happens). The faulty commit [0] got backported in all maintained LTS branches, following minor releases are impacted: - V21.11.1+ - V20.11.5+ - V19.11.12+ The fix for this regression is already in main branch, and will be part of next v22.11 release. Discussing with Kevin, he suggested the fix to be backported early to all the LTS branches. Below is the fix to be backported: ====================================================================== commit 0b2a2ca35037d6a5168f0832c11d9858b8ae946a Author: David Marchand Date: Mon Jul 25 22:32:03 2022 +0200 vhost: fix virtqueue use after free on NUMA reallocation translate_ring_addresses (via numa_realloc) may change a virtio device and virtio queue. The virtqueue object must be refreshed before accessing the lock. Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin ====================================================================== The fix can be backported without conflicts to all the LTS branches, except for v19.11, for which the Vhost directory rename can cause issues. It can be overcome using below command: git cherry-pick -Xfind-renames=5% 0b2a2ca350 Is that OK for you? Please let me know if any issue. Thanks, Maxime [0]: https://git.dpdk.org/dpdk/commit/?id=04c27cb673b9