From: Kevin Traynor <ktraynor@redhat.com>
To: Ciara Power <ciara.power@intel.com>, stable@dpdk.org
Cc: brian.dooley@intel.com, arkadiuszx.kusztal@intel.com
Subject: Re: [PATCH 22.11 21.11] test/crypto: fix vector global buffer overflow
Date: Tue, 7 May 2024 15:25:47 +0100 [thread overview]
Message-ID: <b5229182-7d11-4c00-918f-2c95ba5d4e07@redhat.com> (raw)
In-Reply-To: <20240507134053.5586-1-ciara.power@intel.com>
On 07/05/2024 14:40, Ciara Power wrote:
> When doing a memcpy of the test vector into a local union variable,
> the size of the union was used. This meant extra bytes were being copied
> from the test vector address in the case the vector was smaller in size
> than the union. This caused a global buffer overflow error detected by
> Address Sanitizer.
>
> To fix this, the size of the test vector is also stored alongside the
> address, so when copying takes place, the minimum of the union and test
> vector can be used as the size reference.
>
> Fixes: 488f5a23c219 ("test/crypto: check asymmetric crypto")
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> This issue was fixed by a rework in 2023, so this fix is only applicable
> to 21.11 and 22.11 LTS releases that are currently maintained.
> It is not applicable to 23.11 LTS, or current upstream releases.
> ---
> app/test/test_cryptodev_asym.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
Thanks Ciara, will apply to the tree and it will be part of the next
release.
prev parent reply other threads:[~2024-05-07 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 13:40 Ciara Power
2024-05-07 14:25 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5229182-7d11-4c00-918f-2c95ba5d4e07@redhat.com \
--to=ktraynor@redhat.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=brian.dooley@intel.com \
--cc=ciara.power@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).