patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] bus/vdev: fix devargs memory leak
@ 2023-09-01  7:24 Mingjin Ye
  2023-09-12  9:07 ` Ling, WeiX
  2024-02-02 14:52 ` Burakov, Anatoly
  0 siblings, 2 replies; 6+ messages in thread
From: Mingjin Ye @ 2023-09-01  7:24 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, yidingx.zhou, Mingjin Ye, stable, Anatoly Burakov

When a device is created by a secondary process, an empty devargs is
temporarily generated and bound to it. This causes the device to not
be associated with the correct devargs, and the empty devargs are not
released when the resource is freed.

This patch fixes the issue by matching the devargs when inserting a
device in secondary process.

Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
Fixes: a16040453968 ("eal: extract vdev infra")
Cc: stable@dpdk.org

Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
 drivers/bus/vdev/vdev.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 7974b27295..fe39a98a9c 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -259,6 +259,22 @@ alloc_devargs(const char *name, const char *args)
 	return devargs;
 }
 
+static struct rte_devargs *
+vdev_devargs_lookup(const char *name)
+{
+	struct rte_devargs *devargs;
+	char dev_name[32];
+
+	RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
+		devargs->bus->parse(devargs->name, &dev_name);
+		if (strcmp(dev_name, name) == 0) {
+			VDEV_LOG(INFO, "**Devargs matched %s", dev_name);
+			return devargs;
+		}
+	}
+	return NULL;
+}
+
 static int
 insert_vdev(const char *name, const char *args,
 		struct rte_vdev_device **p_dev,
@@ -271,7 +287,11 @@ insert_vdev(const char *name, const char *args,
 	if (name == NULL)
 		return -EINVAL;
 
-	devargs = alloc_devargs(name, args);
+	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+		devargs = alloc_devargs(name, args);
+	else
+		devargs = vdev_devargs_lookup(name);
+
 	if (!devargs)
 		return -ENOMEM;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] bus/vdev: fix devargs memory leak
  2023-09-01  7:24 [PATCH] bus/vdev: fix devargs memory leak Mingjin Ye
@ 2023-09-12  9:07 ` Ling, WeiX
  2023-09-15  8:56   ` Ye, MingjinX
  2024-02-02 14:52 ` Burakov, Anatoly
  1 sibling, 1 reply; 6+ messages in thread
From: Ling, WeiX @ 2023-09-12  9:07 UTC (permalink / raw)
  To: Ye, MingjinX, dev
  Cc: Yang, Qiming, Zhou, YidingX, Ye, MingjinX, stable, Burakov, Anatoly

> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Sent: Friday, September 1, 2023 3:24 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: [PATCH] bus/vdev: fix devargs memory leak
>
> When a device is created by a secondary process, an empty devargs is
> temporarily generated and bound to it. This causes the device to not be
> associated with the correct devargs, and the empty devargs are not released
> when the resource is freed.
>
> This patch fixes the issue by matching the devargs when inserting a device in
> secondary process.
>
> Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> Fixes: a16040453968 ("eal: extract vdev infra")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---

Tested-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] bus/vdev: fix devargs memory leak
  2023-09-12  9:07 ` Ling, WeiX
@ 2023-09-15  8:56   ` Ye, MingjinX
  2023-11-07  6:56     ` Ye, MingjinX
  2023-11-17 10:29     ` Ye, MingjinX
  0 siblings, 2 replies; 6+ messages in thread
From: Ye, MingjinX @ 2023-09-15  8:56 UTC (permalink / raw)
  To: Burakov, Anatoly, dev; +Cc: Yang, Qiming, Zhou, YidingX, stable, Ling, WeiX

Hi Anatoly,

Could you please review and provide suggestions if any.

Thanks,
Mingjin

> -----Original Message-----
> From: Ling, WeiX <weix.ling@intel.com>
> Sent: Tuesday, September 12, 2023 5:08 PM
> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: RE: [PATCH] bus/vdev: fix devargs memory leak
> 
> > -----Original Message-----
> > From: Mingjin Ye <mingjinx.ye@intel.com>
> > Sent: Friday, September 1, 2023 3:24 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> > <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> > stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> > Subject: [PATCH] bus/vdev: fix devargs memory leak
> >
> > When a device is created by a secondary process, an empty devargs is
> > temporarily generated and bound to it. This causes the device to not
> > be associated with the correct devargs, and the empty devargs are not
> > released when the resource is freed.
> >
> > This patch fixes the issue by matching the devargs when inserting a
> > device in secondary process.
> >
> > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> > Fixes: a16040453968 ("eal: extract vdev infra")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > ---
> 
> Tested-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] bus/vdev: fix devargs memory leak
  2023-09-15  8:56   ` Ye, MingjinX
@ 2023-11-07  6:56     ` Ye, MingjinX
  2023-11-17 10:29     ` Ye, MingjinX
  1 sibling, 0 replies; 6+ messages in thread
From: Ye, MingjinX @ 2023-11-07  6:56 UTC (permalink / raw)
  To: Ye, MingjinX, Burakov, Anatoly, dev; +Cc: Yang, Qiming, stable, Ling, WeiX

Hi Anatoly,

can you please take a look at this patch.

Thanks,
Mingjin

> -----Original Message-----
> From: Ye, MingjinX <mingjinx.ye@intel.com>
> Sent: Friday, September 15, 2023 4:56 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; stable@dpdk.org; Ling, WeiX
> <weix.ling@intel.com>
> Subject: RE: [PATCH] bus/vdev: fix devargs memory leak
> 
> Hi Anatoly,
> 
> Could you please review and provide suggestions if any.
> 
> Thanks,
> Mingjin
> 
> > -----Original Message-----
> > From: Ling, WeiX <weix.ling@intel.com>
> > Sent: Tuesday, September 12, 2023 5:08 PM
> > To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> > <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> > stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> > Subject: RE: [PATCH] bus/vdev: fix devargs memory leak
> >
> > > -----Original Message-----
> > > From: Mingjin Ye <mingjinx.ye@intel.com>
> > > Sent: Friday, September 1, 2023 3:24 PM
> > > To: dev@dpdk.org
> > > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> > > <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> > > stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> > > Subject: [PATCH] bus/vdev: fix devargs memory leak
> > >
> > > When a device is created by a secondary process, an empty devargs is
> > > temporarily generated and bound to it. This causes the device to not
> > > be associated with the correct devargs, and the empty devargs are
> > > not released when the resource is freed.
> > >
> > > This patch fixes the issue by matching the devargs when inserting a
> > > device in secondary process.
> > >
> > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> > > Fixes: a16040453968 ("eal: extract vdev infra")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > > ---
> >
> > Tested-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] bus/vdev: fix devargs memory leak
  2023-09-15  8:56   ` Ye, MingjinX
  2023-11-07  6:56     ` Ye, MingjinX
@ 2023-11-17 10:29     ` Ye, MingjinX
  1 sibling, 0 replies; 6+ messages in thread
From: Ye, MingjinX @ 2023-11-17 10:29 UTC (permalink / raw)
  To: Ye, MingjinX, Burakov, Anatoly, dev
  Cc: Yang, Qiming, Zhou, YidingX, stable, Ling, WeiX

Hi Burakov,

can you please take a look at this patch.

Thanks,
Mingjin

> > -----Original Message-----
> > From: Ling, WeiX <weix.ling@intel.com>
> > Sent: Tuesday, September 12, 2023 5:08 PM
> > To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> > <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> > stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> > Subject: RE: [PATCH] bus/vdev: fix devargs memory leak
> >
> > > -----Original Message-----
> > > From: Mingjin Ye <mingjinx.ye@intel.com>
> > > Sent: Friday, September 1, 2023 3:24 PM
> > > To: dev@dpdk.org
> > > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> > > <yidingx.zhou@intel.com>; Ye, MingjinX <mingjinx.ye@intel.com>;
> > > stable@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>
> > > Subject: [PATCH] bus/vdev: fix devargs memory leak
> > >
> > > When a device is created by a secondary process, an empty devargs is
> > > temporarily generated and bound to it. This causes the device to not
> > > be associated with the correct devargs, and the empty devargs are
> > > not released when the resource is freed.
> > >
> > > This patch fixes the issue by matching the devargs when inserting a
> > > device in secondary process.
> > >
> > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> > > Fixes: a16040453968 ("eal: extract vdev infra")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > > ---
> >
> > Tested-by: Wei Ling <weix.ling@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] bus/vdev: fix devargs memory leak
  2023-09-01  7:24 [PATCH] bus/vdev: fix devargs memory leak Mingjin Ye
  2023-09-12  9:07 ` Ling, WeiX
@ 2024-02-02 14:52 ` Burakov, Anatoly
  1 sibling, 0 replies; 6+ messages in thread
From: Burakov, Anatoly @ 2024-02-02 14:52 UTC (permalink / raw)
  To: Mingjin Ye, dev; +Cc: qiming.yang, yidingx.zhou, stable

On 9/1/2023 9:24 AM, Mingjin Ye wrote:
> When a device is created by a secondary process, an empty devargs is
> temporarily generated and bound to it. This causes the device to not
> be associated with the correct devargs, and the empty devargs are not
> released when the resource is freed.
> 
> This patch fixes the issue by matching the devargs when inserting a
> device in secondary process.
> 
> Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> Fixes: a16040453968 ("eal: extract vdev infra")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-02-02 14:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01  7:24 [PATCH] bus/vdev: fix devargs memory leak Mingjin Ye
2023-09-12  9:07 ` Ling, WeiX
2023-09-15  8:56   ` Ye, MingjinX
2023-11-07  6:56     ` Ye, MingjinX
2023-11-17 10:29     ` Ye, MingjinX
2024-02-02 14:52 ` Burakov, Anatoly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).