From: Kevin Traynor <ktraynor@redhat.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>, stable@dpdk.org
Cc: bluca@debian.org, christian.ehrhardt@canonical.com, xuemingl@nvidia.com
Subject: Re: [PATCH] net/mlx5: fix error packets drop in the regular Rx
Date: Thu, 18 Apr 2024 13:16:27 +0100 [thread overview]
Message-ID: <b5d14ced-7902-4262-8280-8fe28423a548@redhat.com> (raw)
In-Reply-To: <20240311181405.51125-1-viacheslavo@nvidia.com>
On 11/03/2024 18:14, Viacheslav Ovsiienko wrote:
> [ upstream commit ef296e8f6140ea469b50c7bfe73501b1c9ef86e1 ]
>
> When packet gets received with error it is reported in CQE
> structure and PMD analyzes the error syndrome and provides
> two options - either reset the entire queue for the critical
> errors, or just ignore the packet.
>
> The non-vectorized rx_burst did not ignore the non-critical
> error packets, and in case of packet length exceeding the
> mbuf data buffer length it took the next element in the queue
> WQE ring, resulting in CQE/WQE consume indices synchronization
> lost.
>
> Fixes: aa67ed308458 ("net/mlx5: ignore non-critical syndromes for Rx queue")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_rx.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
fyi - for 21.11 branch, I had already rebased and applied this. It seems
to be on 22.11 and 23.11 branches (or queued) also.
https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=c52e6e0ecda72ad163fc7757abe825105d7a16c8
next prev parent reply other threads:[~2024-04-18 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 18:14 Viacheslav Ovsiienko
2024-04-18 12:16 ` Kevin Traynor [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-20 11:45 Viacheslav Ovsiienko
2024-02-20 14:04 ` Dariusz Sosnowski
2024-02-27 16:16 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d14ced-7902-4262-8280-8fe28423a548@redhat.com \
--to=ktraynor@redhat.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).