From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5826A43EA2 for ; Thu, 18 Apr 2024 14:16:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EF40402CC; Thu, 18 Apr 2024 14:16:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7806E40042 for ; Thu, 18 Apr 2024 14:16:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713442594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fj4bJMHr5cheuJlrmY4UQekIr3OMt3myA4QLIYF79Sg=; b=XtKs3iDzvdJ3JMlDDLyrJn296z52gMd+S+vtmGUaZkOeB+Zw/SncmG4G84M9XIkO0qgxXM pJhePXnF58G59Zf0owtwfdofWwOZqDwwu4OnqkCYj36CtuoN8gUjS10QMsWGt5kXKLzSj0 8+gBtUbCopA1Tx1a9uMmYOSe7Rqai6M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-7sz26Sy9P1y1wxzYsuYrAw-1; Thu, 18 Apr 2024 08:16:30 -0400 X-MC-Unique: 7sz26Sy9P1y1wxzYsuYrAw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-41485831b2dso6791995e9.3 for ; Thu, 18 Apr 2024 05:16:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713442589; x=1714047389; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fj4bJMHr5cheuJlrmY4UQekIr3OMt3myA4QLIYF79Sg=; b=e8yrFQfP/YOTVwRRF4K/i65l84ij38tOKluOP7W/DRR8O+XRcVKsP2Zc7gQXQ0128u Hvr2nGmAMTmGEde6fmW9ONF6s8EGUYa17xe4ODZk03F/7mV9pGvK4xMzTANdM2HzQxGJ iTd2zV7+kveG3KzQho5G2RFCzcuc/MRdCfxu+KATjIoztUhb1r1OlB+A0FCoBbtwNJdz UkVfRTCKIVx2HHA5d38Hv1BWGJjaU5Ckz+UgJClPZaTO/oLJ1VchGk4cjn7SR1lfo6gR /6YMOa2KF/kp1AoGpIQCMlZqWBQYrhJgh8vcDXxPsBlUIpahQGXZbwkuCuwyWUT3s8mM RXSg== X-Forwarded-Encrypted: i=1; AJvYcCWiTbv0baOTaT5HHS85Gh7c8sa8O+nPrYN3BGXCRmMFTk2HI0oLBCuv36icgyLXlsdRTgznGYO7sF0ipqFdEJo= X-Gm-Message-State: AOJu0YzmjyS1Wz6P8mD3fZm1ZB7OtZ6vvIr0BzUFUveku8rD47xnGg67 YQyAphfV56x4aN3vwV4d9aeyfyzlL5fiJfU+ae+RhnCirYRHWuDlfXEFRkJV8/6jFVfBAKiLffY hDSdErYH6d6ia8kBmOXEek6+e0X6RmrAs5uSOj+L1uk14 X-Received: by 2002:adf:ed07:0:b0:344:12c:a0be with SMTP id a7-20020adfed07000000b00344012ca0bemr2017611wro.40.1713442589593; Thu, 18 Apr 2024 05:16:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHre1gdbFb2/hMVJwRH9LVugVjt+fCJQB7pHS509HOMhemSYKLXV9m/VmS0jUAt2SyhoeYh+Q== X-Received: by 2002:adf:ed07:0:b0:344:12c:a0be with SMTP id a7-20020adfed07000000b00344012ca0bemr2017594wro.40.1713442589291; Thu, 18 Apr 2024 05:16:29 -0700 (PDT) Received: from [192.168.0.36] ([78.17.184.177]) by smtp.gmail.com with ESMTPSA id y5-20020adfe6c5000000b003436cb45f7esm1714925wrm.90.2024.04.18.05.16.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 05:16:28 -0700 (PDT) Message-ID: Date: Thu, 18 Apr 2024 13:16:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/mlx5: fix error packets drop in the regular Rx To: Viacheslav Ovsiienko , stable@dpdk.org Cc: bluca@debian.org, christian.ehrhardt@canonical.com, xuemingl@nvidia.com References: <20240311181405.51125-1-viacheslavo@nvidia.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20240311181405.51125-1-viacheslavo@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/03/2024 18:14, Viacheslav Ovsiienko wrote: > [ upstream commit ef296e8f6140ea469b50c7bfe73501b1c9ef86e1 ] > > When packet gets received with error it is reported in CQE > structure and PMD analyzes the error syndrome and provides > two options - either reset the entire queue for the critical > errors, or just ignore the packet. > > The non-vectorized rx_burst did not ignore the non-critical > error packets, and in case of packet length exceeding the > mbuf data buffer length it took the next element in the queue > WQE ring, resulting in CQE/WQE consume indices synchronization > lost. > > Fixes: aa67ed308458 ("net/mlx5: ignore non-critical syndromes for Rx queue") > Cc: stable@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rx.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > fyi - for 21.11 branch, I had already rebased and applied this. It seems to be on 22.11 and 23.11 branches (or queued) also. https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=c52e6e0ecda72ad163fc7757abe825105d7a16c8