From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4B03A0527 for ; Wed, 25 Nov 2020 11:59:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 988E1C93E; Wed, 25 Nov 2020 11:59:17 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id EAFA4C93E for ; Wed, 25 Nov 2020 11:59:14 +0100 (CET) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CgyYf6Lxqz15MYK; Wed, 25 Nov 2020 18:58:46 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Nov 2020 18:59:02 +0800 To: Luca Boccassi , CC: References: <1605274630-23414-1-git-send-email-oulijun@huawei.com> <1606274683-41536-1-git-send-email-oulijun@huawei.com> <1606274683-41536-4-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: Date: Wed, 25 Nov 2020 18:59:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-stable] [PATCH v2 19.11.6 3/7] net/hns3: report Tx descriptor segment limitations X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 在 2020/11/25 17:16, Luca Boccassi 写道: > On Wed, 2020-11-25 at 11:24 +0800, Lijun Ou wrote: >> [ upstream commit eb8b3a0d829bc109dfb13de9c8cdeacda5449e69 ] >> >> According to the user manual of Kunpeng920 SoC, the max allowed number >> of segments per whole packet is 63 and the max number of segments per >> packet is 8 in datapath. >> >> This patch reports the Two segment parameters of Tx descriptor >> limitations to DPDK framework. >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu (Xavier) >> --- >> drivers/net/hns3/hns3_ethdev.c | 2 ++ >> drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c >> index 3a92bd4..7fd0f7f 100644 >> --- a/drivers/net/hns3/hns3_ethdev.c >> +++ b/drivers/net/hns3/hns3_ethdev.c >> @@ -2499,6 +2499,8 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) >> .nb_max = HNS3_MAX_RING_DESC, >> .nb_min = HNS3_MIN_RING_DESC, >> .nb_align = HNS3_ALIGN_RING_DESC, >> + .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT, >> + .nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT, >> }; >> >> info->vmdq_queue_num = 0; >> diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c >> index 4359b2e..0b5d3d4 100644 >> --- a/drivers/net/hns3/hns3_ethdev_vf.c >> +++ b/drivers/net/hns3/hns3_ethdev_vf.c >> @@ -866,6 +866,8 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) >> .nb_max = HNS3_MAX_RING_DESC, >> .nb_min = HNS3_MIN_RING_DESC, >> .nb_align = HNS3_ALIGN_RING_DESC, >> + .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT, >> + .nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT, >> }; >> >> info->vmdq_queue_num = 0; > > Hi, > > Thanks for the series, but it fails to build, because of this patch: > > ../drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_infos_get’: > ../drivers/net/hns3/hns3_ethdev.c:2502:17: error: ‘HNS3_MAX_TSO_BD_PER_PKT’ undeclared (first use in this function); did you mean ‘HNS3_MAX_TX_BD_PER_PKT’? > .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT, > ^~~~~~~~~~~~~~~~~~~~~~~ > HNS3_MAX_TX_BD_PER_PKT > ../drivers/net/hns3/hns3_ethdev.c:2502:17: note: each undeclared identifier is reported only once for each function it appears in > ../drivers/net/hns3/hns3_ethdev.c:2503:21: error: ‘HNS3_MAX_NON_TSO_BD_PER_PKT’ undeclared (first use in this function); did you mean ‘HNS3_MAX_TX_BD_PER_PKT’? > .nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > HNS3_MAX_TX_BD_PER_PKT > [3/32] Compiling C object 'drivers/a715181@@tmp_rte_pmd_hns3@sta/net_hns3_hns3_intr.c.o'. > ninja: build stopped: subcommand failed. > Sorry， I will remove it and send the V3.